* [PATCH] hwmon: (lm75) Add support for TMP75B
[not found] <7082731b-ccd8-d16c-8f10-6f4e550ecd18@codethink.co.uk>
@ 2019-04-26 7:42 ` Iker Perez del Palomar
2019-04-26 12:44 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Iker Perez del Palomar @ 2019-04-26 7:42 UTC (permalink / raw)
To: linux-hwmon, Guenter Roeck
The TMP75B has a different control register, supports 12-bit
resolution and the default conversion rate is 37 Hz.
dt-bindings: hwmon: Add tmp75b to lm75.txt
Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
---
Documentation/devicetree/bindings/hwmon/lm75.txt | 1 +
Documentation/hwmon/lm75 | 5 +++--
drivers/hwmon/lm75.c | 11 +++++++++++
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt
b/Documentation/devicetree/bindings/hwmon/lm75.txt
index 12d8cf7cf592..586b5ed70be7 100644
--- a/Documentation/devicetree/bindings/hwmon/lm75.txt
+++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
@@ -25,6 +25,7 @@ Required properties:
"ti,tmp175",
"ti,tmp275",
"ti,tmp75",
+ "ti,tmp75b",
"ti,tmp75c",
- reg: I2C bus address of the device
diff --git a/Documentation/hwmon/lm75 b/Documentation/hwmon/lm75
index 010583608f12..baf052935761 100644
--- a/Documentation/hwmon/lm75
+++ b/Documentation/hwmon/lm75
@@ -47,8 +47,8 @@ Supported chips:
Addresses scanned: none
Datasheet: Publicly available at the ST website
https://www.st.com/resource/en/datasheet/stlm75.pdf
- * Texas Instruments TMP100, TMP101, TMP105, TMP112, TMP75, TMP75C,
TMP175, TMP275
- Prefixes: 'tmp100', 'tmp101', 'tmp105', 'tmp112', 'tmp175',
'tmp75', 'tmp75c', 'tmp275'
+ * Texas Instruments TMP100, TMP101, TMP105, TMP112, TMP75, TMP75B,
TMP75C, TMP175, TMP275
+ Prefixes: 'tmp100', 'tmp101', 'tmp105', 'tmp112', 'tmp175',
'tmp75', 'tmp75b', 'tmp75c', 'tmp275'
Addresses scanned: none
Datasheet: Publicly available at the Texas Instruments website
http://www.ti.com/product/tmp100
@@ -56,6 +56,7 @@ Supported chips:
http://www.ti.com/product/tmp105
http://www.ti.com/product/tmp112
http://www.ti.com/product/tmp75
+ http://www.ti.com/product/tmp75b
http://www.ti.com/product/tmp75c
http://www.ti.com/product/tmp175
http://www.ti.com/product/tmp275
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index 447af07450f1..5e730788bf5f 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -59,6 +59,7 @@ enum lm75_type { /* keep sorted in alphabetical order */
tmp175,
tmp275,
tmp75,
+ tmp75b,
tmp75c,
};
@@ -378,6 +379,11 @@ lm75_probe(struct i2c_client *client, const struct
i2c_device_id *id)
data->resolution = 12;
data->sample_time = MSEC_PER_SEC / 2;
break;
+ case tmp75b:
+ clr_mask |= 1 << 15; /* not one-shot mode */
+ data->resolution = 12;
+ data->sample_time = MSEC_PER_SEC / 4;
+ break;
case tmp75c:
clr_mask |= 1 << 5; /* not one-shot mode */
data->resolution = 12;
@@ -438,6 +444,7 @@ static const struct i2c_device_id lm75_ids[] = {
{ "tmp175", tmp175, },
{ "tmp275", tmp275, },
{ "tmp75", tmp75, },
+ { "tmp75b", tmp75b, },
{ "tmp75c", tmp75c, },
{ /* LIST END */ }
};
@@ -537,6 +544,10 @@ static const struct of_device_id lm75_of_match[] = {
.data = (void *)tmp75
},
{
+ .compatible = "ti,tmp75b",
+ .data=(void *)tmp75b
+ },
+ {
.compatible = "ti,tmp75c",
.data = (void *)tmp75c
},
--
2.11.0
--
Iker Perez del Palomar, Software Engineer
Codethink Ltd 35 Dale St, Manchester M1 2HF
http://www.codethink.co.uk/ Manchester, M1 2JW, United Kingdom
We respect your privacy. See https://www.codethink.co.uk/privacy.html
_______________________________________________
Ts005-internal mailing list
Ts005-internal@lists.codethink.co.uk
https://lists.codethink.co.uk/cgi-bin/mailman/listinfo/ts005-internal
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (lm75) Add support for TMP75B
2019-04-26 7:42 ` [PATCH] hwmon: (lm75) Add support for TMP75B Iker Perez del Palomar
@ 2019-04-26 12:44 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-04-26 12:44 UTC (permalink / raw)
To: Iker Perez del Palomar, linux-hwmon
On 4/26/19 12:42 AM, Iker Perez del Palomar wrote:
> The TMP75B has a different control register, supports 12-bit
> resolution and the default conversion rate is 37 Hz.
>
> dt-bindings: hwmon: Add tmp75b to lm75.txt
>
> Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
This patch is corrupted (line wraps as far as I can see). Also, please
version your patches, and add a version log, as described in
Documentation/process/submitting-patches.rst.
Also, please run checkpatch and fix the problems it reports.
That includes the line wraps, but there is also a bad assignment.
Thanks,
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/lm75.txt | 1 +
> Documentation/hwmon/lm75 | 5 +++--
> drivers/hwmon/lm75.c | 11 +++++++++++
> 3 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt
> b/Documentation/devicetree/bindings/hwmon/lm75.txt
> index 12d8cf7cf592..586b5ed70be7 100644
> --- a/Documentation/devicetree/bindings/hwmon/lm75.txt
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -25,6 +25,7 @@ Required properties:
> "ti,tmp175",
> "ti,tmp275",
> "ti,tmp75",
> + "ti,tmp75b",
> "ti,tmp75c",
>
> - reg: I2C bus address of the device
> diff --git a/Documentation/hwmon/lm75 b/Documentation/hwmon/lm75
> index 010583608f12..baf052935761 100644
> --- a/Documentation/hwmon/lm75
> +++ b/Documentation/hwmon/lm75
> @@ -47,8 +47,8 @@ Supported chips:
> Addresses scanned: none
> Datasheet: Publicly available at the ST website
> https://www.st.com/resource/en/datasheet/stlm75.pdf
> - * Texas Instruments TMP100, TMP101, TMP105, TMP112, TMP75, TMP75C,
> TMP175, TMP275
> - Prefixes: 'tmp100', 'tmp101', 'tmp105', 'tmp112', 'tmp175',
> 'tmp75', 'tmp75c', 'tmp275'
> + * Texas Instruments TMP100, TMP101, TMP105, TMP112, TMP75, TMP75B,
> TMP75C, TMP175, TMP275
> + Prefixes: 'tmp100', 'tmp101', 'tmp105', 'tmp112', 'tmp175',
> 'tmp75', 'tmp75b', 'tmp75c', 'tmp275'
> Addresses scanned: none
> Datasheet: Publicly available at the Texas Instruments website
> http://www.ti.com/product/tmp100
> @@ -56,6 +56,7 @@ Supported chips:
> http://www.ti.com/product/tmp105
> http://www.ti.com/product/tmp112
> http://www.ti.com/product/tmp75
> + http://www.ti.com/product/tmp75b
> http://www.ti.com/product/tmp75c
> http://www.ti.com/product/tmp175
> http://www.ti.com/product/tmp275
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 447af07450f1..5e730788bf5f 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -59,6 +59,7 @@ enum lm75_type { /* keep sorted in alphabetical order */
> tmp175,
> tmp275,
> tmp75,
> + tmp75b,
> tmp75c,
> };
>
> @@ -378,6 +379,11 @@ lm75_probe(struct i2c_client *client, const struct
> i2c_device_id *id)
> data->resolution = 12;
> data->sample_time = MSEC_PER_SEC / 2;
> break;
> + case tmp75b:
> + clr_mask |= 1 << 15; /* not one-shot mode */
> + data->resolution = 12;
> + data->sample_time = MSEC_PER_SEC / 4;
> + break;
> case tmp75c:
> clr_mask |= 1 << 5; /* not one-shot mode */
> data->resolution = 12;
> @@ -438,6 +444,7 @@ static const struct i2c_device_id lm75_ids[] = {
> { "tmp175", tmp175, },
> { "tmp275", tmp275, },
> { "tmp75", tmp75, },
> + { "tmp75b", tmp75b, },
> { "tmp75c", tmp75c, },
> { /* LIST END */ }
> };
> @@ -537,6 +544,10 @@ static const struct of_device_id lm75_of_match[] = {
> .data = (void *)tmp75
> },
> {
> + .compatible = "ti,tmp75b",
> + .data=(void *)tmp75b
> + },
> + {
> .compatible = "ti,tmp75c",
> .data = (void *)tmp75c
> },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-26 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <7082731b-ccd8-d16c-8f10-6f4e550ecd18@codethink.co.uk>
2019-04-26 7:42 ` [PATCH] hwmon: (lm75) Add support for TMP75B Iker Perez del Palomar
2019-04-26 12:44 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).