From: Guenter Roeck <linux@roeck-us.net>
To: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
Cc: patrick@stwcx.xyz, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Date: Mon, 24 Apr 2023 06:49:31 -0700 [thread overview]
Message-ID: <321a84c6-6d74-4042-a6ce-6229073c8d30@roeck-us.net> (raw)
In-Reply-To: <20230424101352.28117-2-Delphine_CC_Chiu@Wiwynn.com>
On Mon, Apr 24, 2023 at 06:13:49PM +0800, Delphine CC Chiu wrote:
> Add a device tree bindings for ltc4286 driver.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> ---
> .../bindings/hwmon/lltc,ltc4286.yaml | 47 +++++++++++++++++++
> MAINTAINERS | 9 ++++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> new file mode 100644
> index 000000000000..c1c8e310f9c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTC4286 power monitors
> +
> +maintainers:
> + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> +
> +properties:
> + compatible:
> + enum:
> + - lltc,ltc4286
> + - lltc,ltc4287
There is no LTC4287, at least according to the Analog website.
> +
> + reg:
> + maxItems: 1
> +
> + vrange_select_25p6:
> + description:
> + This property is a bool parameter to represent the
> + voltage range is 25.6 or not for this chip.
Existing attributes are adi,vrange-high-enable, ti,extended-range-enable,
ti,bus-range-microvolt, adi,range-double. I would suggest to use
adi,vrange-high-enable.
> +
> + rsense-micro-ohms:
> + description:
> + Resistor value in micro-Ohm
I would suggest either shunt-resistor-micro-ohms or
sense-resistor-micro-ohms as used by other bindings.
> +
> +required:
> + - compatible
> + - reg
> + - rsense-micro-ohms
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + status = "okay";
> + ltc4286@40 {
> + compatible = "lltc,ltc4286";
> + reg = <0x40>;
> + vrange_select_25p6;
> + rsense-micro-ohms = <300>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c6545eb54104..930bdba0f73c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12183,6 +12183,15 @@ S: Maintained
> F: Documentation/hwmon/ltc4261.rst
> F: drivers/hwmon/ltc4261.c
>
> +LTC4286 HARDWARE MONITOR DRIVER
> +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> +L: linux-i2c@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> +F: drivers/hwmon/pmbus/Kconfig
> +F: drivers/hwmon/pmbus/Makefile
> +F: drivers/hwmon/pmbus/ltc4286.c
> +
> LTC4306 I2C MULTIPLEXER DRIVER
> M: Michael Hennerich <michael.hennerich@analog.com>
> L: linux-i2c@vger.kernel.org
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-04-24 13:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 10:13 [PATCH v1 0/2] LTC4286 and LTC4287 driver support Delphine CC Chiu
2023-04-24 10:13 ` [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings Delphine CC Chiu
2023-04-24 13:28 ` Rob Herring
2023-04-24 13:49 ` Guenter Roeck [this message]
2023-07-24 2:12 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-07-24 3:21 ` Guenter Roeck
2023-08-02 5:31 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-08-04 15:56 ` Guenter Roeck
2023-04-24 10:13 ` [PATCH v1 2/2] hwmon: pmbus: Add ltc4286 driver Delphine CC Chiu
2023-04-24 14:13 ` Guenter Roeck
2023-07-24 6:03 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-07-24 6:56 ` Guenter Roeck
2023-08-15 9:08 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-04-25 4:48 ` kernel test robot
2023-04-25 13:45 ` Andi Shyti
2023-04-25 14:09 ` Guenter Roeck
2023-07-24 2:07 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-07-24 2:22 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-04-30 17:30 ` kernel test robot
2023-05-05 23:14 ` kernel test robot
2023-07-24 10:05 ` [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings Delphine CC Chiu
2023-07-24 10:05 ` [PATCH 2/2] hwmon: pmbus: Add ltc4286 driver Delphine CC Chiu
2023-07-24 13:55 ` Guenter Roeck
2023-07-26 15:42 ` Andi Shyti
2023-07-24 10:09 ` [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings Krzysztof Kozlowski
2023-07-26 16:44 ` Rob Herring
2023-08-08 2:35 ` Delphine_CC_Chiu/WYHQ/Wiwynn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321a84c6-6d74-4042-a6ce-6229073c8d30@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).