From: Guenter Roeck <linux@roeck-us.net>
To: "Tremblay, Eric" <etremblay@distech-controls.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v6 1/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips
Date: Sat, 2 Nov 2019 08:30:06 -0700 [thread overview]
Message-ID: <32a41dac-9648-0d7f-afd9-79af0c3eed65@roeck-us.net> (raw)
In-Reply-To: <DM6PR01MB4844A7A2E7DCA9168D44F34195610@DM6PR01MB4844.prod.exchangelabs.com>
On 10/29/19 8:04 AM, Tremblay, Eric wrote:
> dt-bindings: hwmon: Add TMP512/513
>
> Add dt-binding for TMP512/513 sensor chips
>
> Signed-off-by: Eric Tremblay <etremblay@distech-controls.com>
I do get the following warnings:
Documentation/hwmon/tmp513.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent.
Documentation/hwmon/tmp513.rst: WARNING: document isn't included in any toctree
The .rst file needs to be added to Documentation/hwmon/index.rst. No idea what
the first problem is.
Guenter
> ---
> .../devicetree/bindings/hwmon/ti,tmp513.yaml | 88 +++++++++++++++++++
> 1 file changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
> new file mode 100644
> index 000000000000..e5f3c72ff548
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2018 Linaro Ltd.
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,tmp513.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TMP513/512 system monitor sensor
> +
> +maintainers:
> + - Eric Tremblay <etremblay@distech-controls.com>
> +
> +description: |
> + The TMP512 (dual-channel) and TMP513 (triple-channel) are system monitors that include
> + remote sensors, a local temperature sensor, and a high-side current shunt monitor.
> + These system monitors have the capability of measuring remote temperatures,
> + on-chip temperatures, and system voltage/power/current consumption.
> +
> + Datasheets:
> + http://www.ti.com/lit/gpn/tmp513
> + http://www.ti.com/lit/gpn/tmp512
> +
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tmp512
> + - ti,tmp513
> +
> + reg:
> + maxItems: 1
> +
> + shunt-resistor-micro-ohms:
> + description: |
> + If 0, the calibration process will be skiped and the current and power
> + measurement engine will not work. Temperature and voltage measurement
> + will continue to work.
> + The shunt value also need to respect : rshunt <= pga-gain * 40 * 1000 * 1000.
> + If not, it's not possible to compute a valid calibration value.
> + default: 1000
> +
> + ti,pga-gain:
> + description: |
> + The gain value for the PGA function. This is 8, 4, 2 or 1.
> + The PGA gain affect the shunt voltage range.
> + The range will be equal to: pga-gain * 40mV
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2, 4, 8]
> + default: 8
> +
> + ti,bus-voltage-range-volt:
> + description: |
> + This is the operating range of the bus voltage
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [16, 32]
> + default: 32
> +
> + ti,nfactor:
> + description: |
> + Array of three(TMP513) or two(TMP512) n-Factor value for each remote
> + temperature channel.
> + See datasheet Table 11 for n-Factor range list and value interpretation.
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/uint8-array
> + - minItems: 2
> + maxItems: 3
> + items:
> + default: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c {
> + tmp513@5c {
> + compatible = "ti,tmp513";
> + reg = <0x5C>;
> + shunt-resistor-micro-ohms = <330000>;
> + ti,bus-voltage-range-volts = <32>;
> + ti,pga-gain = <8>;
> + ti,nfactor = [01 F3 00];
> + };
> + };
>
next prev parent reply other threads:[~2019-11-02 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 15:04 [PATCH v6 1/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips Tremblay, Eric
2019-11-02 15:15 ` Guenter Roeck
2019-11-02 15:30 ` Guenter Roeck [this message]
2019-11-04 14:28 ` Tremblay, Eric
2019-11-04 21:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a41dac-9648-0d7f-afd9-79af0c3eed65@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=etremblay@distech-controls.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).