From: Guenter Roeck <linux@roeck-us.net>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: robh+dt@kernel.org, jdelvare@suse.com, mark.thoren@analog.com,
ardeleanalex@gmail.com
Subject: Re: [PATCH v2 2/4] docs: hwmon: (ltc2945): change type of val to ULL in ltc2945_val_to_reg()
Date: Wed, 11 Nov 2020 06:54:03 -0800 [thread overview]
Message-ID: <41f86559-9165-40f9-e7f3-3e7f5eca7315@roeck-us.net> (raw)
In-Reply-To: <20201111091259.46773-3-alexandru.ardelean@analog.com>
On 11/11/20 1:12 AM, Alexandru Ardelean wrote:
> In order to account for any potential overflows that could occur.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Thinking about it, this can only really happen if the user provides
excessive values for limit attributes. Those are currently clamped
later, after the conversion. I think it would be better to modify
the code to apply a clamp _before_ the conversion as well instead
of trying to solve the overflow problem with unsigned long long.
Either case, can you send me a register dump for this chip ?
I'd like to write a module test script to actually check if there
are any over/underflows or other problems.
Thanks,
Guenter
> ---
> drivers/hwmon/ltc2945.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c
> index 1cea710df668..6d4569a25471 100644
> --- a/drivers/hwmon/ltc2945.c
> +++ b/drivers/hwmon/ltc2945.c
> @@ -155,7 +155,7 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg)
> }
>
> static int ltc2945_val_to_reg(struct device *dev, u8 reg,
> - unsigned long val)
> + unsigned long long val)
> {
> struct ltc2945_state *st = dev_get_drvdata(dev);
> struct regmap *regmap = st->regmap;
> @@ -181,14 +181,14 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg,
> return ret;
> if (control & CONTROL_MULT_SELECT) {
> /* 25 mV * 25 uV = 0.625 uV resolution. */
> - val = DIV_ROUND_CLOSEST(val, 625);
> + val = DIV_ROUND_CLOSEST_ULL(val, 625);
> } else {
> /*
> * 0.5 mV * 25 uV = 0.0125 uV resolution.
> * Divide first to avoid overflow;
> * accept loss of accuracy.
> */
> - val = DIV_ROUND_CLOSEST(val, 25) * 2;
> + val = DIV_ROUND_CLOSEST_ULL(val, 25) * 2;
> }
> break;
> case LTC2945_VIN_H:
> @@ -197,7 +197,7 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg,
> case LTC2945_MAX_VIN_THRES_H:
> case LTC2945_MIN_VIN_THRES_H:
> /* 25 mV resolution. */
> - val /= 25;
> + val = div_u64(val, 25);
> break;
> case LTC2945_ADIN_H:
> case LTC2945_MAX_ADIN_H:
> @@ -219,7 +219,7 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg,
> * dividing the reported current by the sense resistor value
> * in mOhm.
> */
> - val = DIV_ROUND_CLOSEST(val, 25);
> + val = DIV_ROUND_CLOSEST_ULL(val, 25);
> break;
> default:
> return -EINVAL;
> @@ -247,7 +247,7 @@ static ssize_t ltc2945_value_store(struct device *dev,
> struct ltc2945_state *st = dev_get_drvdata(dev);
> struct regmap *regmap = st->regmap;
> u8 reg = attr->index;
> - unsigned long val;
> + unsigned long long val;
> u8 regbuf[3];
> int num_regs;
> int regval;
>
next prev parent reply other threads:[~2020-11-11 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 9:12 [PATCH v2 0/4] hwmon: (ltc2945): add support for sense resistor Alexandru Ardelean
2020-11-11 9:12 ` [PATCH v2 1/4] hwmon: (ltc2945): wrap regmap into an ltc2945_state struct Alexandru Ardelean
2020-11-11 9:12 ` [PATCH v2 2/4] docs: hwmon: (ltc2945): change type of val to ULL in ltc2945_val_to_reg() Alexandru Ardelean
2020-11-11 14:54 ` Guenter Roeck [this message]
2020-11-11 15:28 ` Alexandru Ardelean
2020-11-11 15:44 ` Guenter Roeck
2020-11-18 14:40 ` Alexandru Ardelean
2020-11-18 15:19 ` Guenter Roeck
2020-11-13 7:25 ` kernel test robot
2020-11-11 9:12 ` [PATCH v2 3/4] hwmon: (ltc2945): add support for sense resistor Alexandru Ardelean
2020-11-18 14:43 ` Alexandru Ardelean
2020-11-18 15:21 ` Guenter Roeck
2020-11-11 9:12 ` [PATCH v2 4/4] dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945 Alexandru Ardelean
2020-11-16 17:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f86559-9165-40f9-e7f3-3e7f5eca7315@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.thoren@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).