From: Guenter Roeck <linux@roeck-us.net>
To: Guru Das Srinagesh <gurus@codeaurora.org>, linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org, "Kamil Debski" <kamil@wypas.org>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v10 02/12] hwmon: pwm-fan: Use 64-bit division macro
Date: Thu, 19 Mar 2020 14:12:02 -0700 [thread overview]
Message-ID: <4c99e36b-4705-a6a2-0769-301b5e9b5006@roeck-us.net> (raw)
In-Reply-To: <b8d8e51723f99844abc6a3f637ac42be3e084709.1584650604.git.gurus@codeaurora.org>
On 3/19/20 1:50 PM, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_args.period's datatype
> to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle
> a 64-bit dividend.
>
> Cc: Kamil Debski <kamil@wypas.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-hwmon@vger.kernel.org
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
https://patchwork.kernel.org/patch/11430549/
includes my previous Ack. v9 included it, in v10 it is dropped.
I don't see a change in the patch. Please explain.
Guenter
> ---
> drivers/hwmon/pwm-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> index 42ffd2e..283423a 100644
> --- a/drivers/hwmon/pwm-fan.c
> +++ b/drivers/hwmon/pwm-fan.c
> @@ -437,7 +437,7 @@ static int pwm_fan_resume(struct device *dev)
> return 0;
>
> pwm_get_args(ctx->pwm, &pargs);
> - duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM);
> + duty = DIV_ROUND_UP_ULL(ctx->pwm_value * (pargs.period - 1), MAX_PWM);
> ret = pwm_config(ctx->pwm, duty, pargs.period);
> if (ret)
> return ret;
>
next prev parent reply other threads:[~2020-03-19 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1584650604.git.gurus@codeaurora.org>
2020-03-19 20:50 ` [PATCH v10 02/12] hwmon: pwm-fan: Use 64-bit division macro Guru Das Srinagesh
2020-03-19 21:12 ` Guenter Roeck [this message]
2020-03-20 1:13 ` Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c99e36b-4705-a6a2-0769-301b5e9b5006@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gurus@codeaurora.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).