From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A291CC3A589 for ; Tue, 20 Aug 2019 09:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 831EA2070B for ; Tue, 20 Aug 2019 09:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728545AbfHTJWQ convert rfc822-to-8bit (ORCPT ); Tue, 20 Aug 2019 05:22:16 -0400 Received: from enpas.org ([46.38.239.100]:39178 "EHLO mail.enpas.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729194AbfHTJWQ (ORCPT ); Tue, 20 Aug 2019 05:22:16 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 99F0910006F; Tue, 20 Aug 2019 09:22:13 +0000 (UTC) Date: Tue, 20 Aug 2019 11:22:12 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: <20190819121618.16557-1-max@enpas.org> <20190819121618.16557-3-max@enpas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH v5 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision To: Geert Uytterhoeven CC: Linux I2C , linux-hwmon@vger.kernel.org, Wolfram Sang , Jean Delvare , Guenter Roeck , Linux/m68k , Linux Kernel Mailing List , John Paul Adrian Glaubitz , Bartosz Golaszewski From: Max Message-ID: <55E57575-B53F-495F-BDBC-E69E69752CDA@enpas.org> Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On August 20, 2019 11:18:36 AM GMT+02:00, Geert Uytterhoeven wrote: >Since commit d3e1b617ae20c459 ("i2c: allow specify device properties in >i2c_board_info"), the properties could be provided by info->properties, >too. >However, according to the comments for device_add_properties(), this is >valid only if there is a real firmware node present. > >If that is true, Max' use is correct, while e.g. commit >6a7836ba7fb4abf6 >("ARM: imx: pca100: use device properties for at24 eeprom") isn't? Yup, I saw that too. Any hints would be greatly appreciated! Max