Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
@ 2019-02-12 11:38 Jagan Teki
  2019-02-20 17:22 ` Jagan Teki
  2019-02-28 15:15 ` Rob Herring
  0 siblings, 2 replies; 7+ messages in thread
From: Jagan Teki @ 2019-02-12 11:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland
  Cc: linux-hwmon, devicetree, linux-kernel, Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
-  Add all compatible nodes available in lm75.

 .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt

diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
new file mode 100644
index 000000000000..12d8cf7cf592
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
@@ -0,0 +1,37 @@
+*LM75 hwmon sensor.
+
+Required properties:
+- compatible: manufacturer and chip name, one of
+		"adi,adt75",
+		"dallas,ds1775",
+		"dallas,ds75",
+		"dallas,ds7505",
+		"gmt,g751",
+		"national,lm75",
+		"national,lm75a",
+		"national,lm75b",
+		"maxim,max6625",
+		"maxim,max6626",
+		"maxim,max31725",
+		"maxim,max31726",
+		"maxim,mcp980x",
+		"st,stds75",
+		"st,stlm75",
+		"microchip,tcn75",
+		"ti,tmp100",
+		"ti,tmp101",
+		"ti,tmp105",
+		"ti,tmp112",
+		"ti,tmp175",
+		"ti,tmp275",
+		"ti,tmp75",
+		"ti,tmp75c",
+
+- reg: I2C bus address of the device
+
+Example:
+
+sensor@48 {
+	compatible = "st,stlm75";
+	reg = <0x48>;
+};
-- 
2.18.0.321.gffc6fa0e3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-12 11:38 [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75 Jagan Teki
@ 2019-02-20 17:22 ` Jagan Teki
  2019-02-21 14:02   ` Guenter Roeck
  2019-02-28 15:15 ` Rob Herring
  1 sibling, 1 reply; 7+ messages in thread
From: Jagan Teki @ 2019-02-20 17:22 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland
  Cc: linux-hwmon, devicetree, linux-kernel

On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Add missing dt-binding documentation for lm75 hwmon sensor.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> -  Add all compatible nodes available in lm75.
>
>  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt

Any comments on this? It is blocking some dts changes to get merge
into Mainline.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-20 17:22 ` Jagan Teki
@ 2019-02-21 14:02   ` Guenter Roeck
  2019-02-26  6:04     ` Jagan Teki
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2019-02-21 14:02 UTC (permalink / raw)
  To: Jagan Teki, Jean Delvare, Rob Herring, Mark Rutland
  Cc: linux-hwmon, devicetree, linux-kernel

On 2/20/19 9:22 AM, Jagan Teki wrote:
> On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>>
>> Add missing dt-binding documentation for lm75 hwmon sensor.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> Changes for v2:
>> -  Add all compatible nodes available in lm75.
>>
>>   .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> 
> Any comments on this? It is blocking some dts changes to get merge
> into Mainline.
> 

Waiting for Rob's Ack.

Guenter

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-21 14:02   ` Guenter Roeck
@ 2019-02-26  6:04     ` Jagan Teki
  0 siblings, 0 replies; 7+ messages in thread
From: Jagan Teki @ 2019-02-26  6:04 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Mark Rutland, linux-hwmon,
	devicetree, linux-kernel

Rob,

On Thu, Feb 21, 2019 at 7:32 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 2/20/19 9:22 AM, Jagan Teki wrote:
> > On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >>
> >> Add missing dt-binding documentation for lm75 hwmon sensor.
> >>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> ---
> >> Changes for v2:
> >> -  Add all compatible nodes available in lm75.
> >>
> >>   .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
> >>   1 file changed, 37 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> >
> > Any comments on this? It is blocking some dts changes to get merge
> > into Mainline.
> >
>
> Waiting for Rob's Ack.

Any comments?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-12 11:38 [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75 Jagan Teki
  2019-02-20 17:22 ` Jagan Teki
@ 2019-02-28 15:15 ` Rob Herring
  2019-02-28 17:30   ` Jagan Teki
  1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2019-02-28 15:15 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Jean Delvare, Guenter Roeck, Mark Rutland, linux-hwmon,
	devicetree, linux-kernel

On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote:
> Add missing dt-binding documentation for lm75 hwmon sensor.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> -  Add all compatible nodes available in lm75.
> 
>  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..12d8cf7cf592
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,37 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: manufacturer and chip name, one of
> +		"adi,adt75",
> +		"dallas,ds1775",
> +		"dallas,ds75",
> +		"dallas,ds7505",
> +		"gmt,g751",
> +		"national,lm75",
> +		"national,lm75a",
> +		"national,lm75b",
> +		"maxim,max6625",
> +		"maxim,max6626",
> +		"maxim,max31725",
> +		"maxim,max31726",
> +		"maxim,mcp980x",
> +		"st,stds75",
> +		"st,stlm75",
> +		"microchip,tcn75",
> +		"ti,tmp100",
> +		"ti,tmp101",
> +		"ti,tmp105",
> +		"ti,tmp112",
> +		"ti,tmp175",
> +		"ti,tmp275",
> +		"ti,tmp75",
> +		"ti,tmp75c",

Some of these are in trivial-devices.yaml already. So you either need to 
remove them from there. Or you can move all these to trivial-devices and 
benefit from having a schema. I prefer the latter, but either way is 
fine. You can remove them from trivial-devices.yaml in a separate patch, 
so:

Acked-by: Rob Herring <robh@kernel.org>

Rob

P.S. Third option is convert this doc to DT schema. Don't tell anyone, 
but you'll be a the top of my review queue.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-28 15:15 ` Rob Herring
@ 2019-02-28 17:30   ` Jagan Teki
  2019-02-28 17:39     ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Jagan Teki @ 2019-02-28 17:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Mark Rutland, linux-hwmon,
	devicetree, linux-kernel

On Thu, Feb 28, 2019 at 8:45 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote:
> > Add missing dt-binding documentation for lm75 hwmon sensor.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > -  Add all compatible nodes available in lm75.
> >
> >  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> > new file mode 100644
> > index 000000000000..12d8cf7cf592
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> > @@ -0,0 +1,37 @@
> > +*LM75 hwmon sensor.
> > +
> > +Required properties:
> > +- compatible: manufacturer and chip name, one of
> > +             "adi,adt75",
> > +             "dallas,ds1775",
> > +             "dallas,ds75",
> > +             "dallas,ds7505",
> > +             "gmt,g751",
> > +             "national,lm75",
> > +             "national,lm75a",
> > +             "national,lm75b",
> > +             "maxim,max6625",
> > +             "maxim,max6626",
> > +             "maxim,max31725",
> > +             "maxim,max31726",
> > +             "maxim,mcp980x",
> > +             "st,stds75",
> > +             "st,stlm75",
> > +             "microchip,tcn75",
> > +             "ti,tmp100",
> > +             "ti,tmp101",
> > +             "ti,tmp105",
> > +             "ti,tmp112",
> > +             "ti,tmp175",
> > +             "ti,tmp275",
> > +             "ti,tmp75",
> > +             "ti,tmp75c",
>
> Some of these are in trivial-devices.yaml already. So you either need to
> remove them from there. Or you can move all these to trivial-devices and
> benefit from having a schema. I prefer the latter, but either way is
> fine. You can remove them from trivial-devices.yaml in a separate patch,
> so:

Thanks, Rob.

I will remove trivial devices from here wrt trivial-devices.yaml in
separate patch.

Guenter, could you please pick this.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
  2019-02-28 17:30   ` Jagan Teki
@ 2019-02-28 17:39     ` Guenter Roeck
  0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2019-02-28 17:39 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Rob Herring, Jean Delvare, Mark Rutland, linux-hwmon, devicetree,
	linux-kernel

On Thu, Feb 28, 2019 at 11:00:44PM +0530, Jagan Teki wrote:
> On Thu, Feb 28, 2019 at 8:45 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote:
> > > Add missing dt-binding documentation for lm75 hwmon sensor.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
[ ... ]

> 
> Guenter, could you please pick this.

Applied to hwmon-next (and pushed).

Guenter

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 11:38 [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75 Jagan Teki
2019-02-20 17:22 ` Jagan Teki
2019-02-21 14:02   ` Guenter Roeck
2019-02-26  6:04     ` Jagan Teki
2019-02-28 15:15 ` Rob Herring
2019-02-28 17:30   ` Jagan Teki
2019-02-28 17:39     ` Guenter Roeck

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox