Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: ina3221.c: Add of_node_put() before return
Date: Thu, 11 Jul 2019 11:59:16 +0530
Message-ID: <61a5ea30-9b9d-77c4-58b8-acb0c553e9e5@gmail.com> (raw)
In-Reply-To: <20190708181633.GA15102@roeck-us.net>

On 08/07/19 11:46 PM, Guenter Roeck wrote:
> On Sat, Jul 06, 2019 at 06:51:30PM +0530, Nishka Dasgupta wrote:
>> Each iteration of for_each_child_of_node puts the previous
>> node, but in the case of a return from the middle of the loop, there is
>> no put, thus causing a memory leak. Hence add an of_node_put before the
>> return.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> 
> Applied. For future patches, please don't put source file extensions
> into the subject line.

I will keep that in mind, thank you.

Thanking you,
Nishka

> Thanks,
> Guenter
> 
>> ---
>>   drivers/hwmon/ina3221.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
>> index 55943b4dcc7b..0037e2bdacd6 100644
>> --- a/drivers/hwmon/ina3221.c
>> +++ b/drivers/hwmon/ina3221.c
>> @@ -713,8 +713,10 @@ static int ina3221_probe_from_dt(struct device *dev, struct ina3221_data *ina)
>>   
>>   	for_each_child_of_node(np, child) {
>>   		ret = ina3221_probe_child_from_dt(dev, child, ina);
>> -		if (ret)
>> +		if (ret) {
>> +			of_node_put(child);
>>   			return ret;
>> +		}
>>   	}
>>   
>>   	return 0;


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-06 13:21 Nishka Dasgupta
2019-07-08 18:16 ` Guenter Roeck
2019-07-11  6:29   ` Nishka Dasgupta [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a5ea30-9b9d-77c4-58b8-acb0c553e9e5@gmail.com \
    --to=nishkadg.linux@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox