From: "Liu, Xiaoting" <xiaoting.liu@hxt-semitech.com>
To: Guenter Roeck <linux@roeck-us.net>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Yang, Shunyong" <shunyong.yang@hxt-semitech.com>,
"Wang, Dongsheng" <dongsheng.wang@hxt-semitech.com>
Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon: add dps650ab documentation
Date: Tue, 8 Jan 2019 08:57:19 +0000 [thread overview]
Message-ID: <6d28f64bd2f441d09819d66b55537e0b@HXTBJIDCEMVIW02.hxtcorp.net> (raw)
In-Reply-To: 568735a3-1de2-3880-5fe1-7be38a55f33f@roeck-us.net
On 2019/1/7 21:58, Guenter Roeck wrote:
> On 1/7/19 3:00 AM, Xiaoting Liu wrote:
>> Bindings for DPS650AB power, voltage, temperature, and fan monitering.
>>
>> Signed-off-by: Xiaoting Liu <xiaoting.liu@hxt-semitech.com>
>> ---
>> v2:
>> Change the patch subject.
>> ---
>> Documentation/devicetree/bindings/hwmon/dps650ab.txt | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/dps650ab.txt b/Documentation/devicetree/bindings/hwmon/dps650ab.txt
>> new file mode 100644
>> index 000000000000..6bbbff89f6d5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/dps650ab.txt
>> @@ -0,0 +1,11 @@
>> +Bindings for DPS650AB power, voltage, temperature, and fan monitering
>> +
> Assuming this is the Delta Electronics DPS-650-AB power supply, I think
> you should mention that here.
I will update commit message as mentioned.
>
>> +Required properties:
>> +- compatible : "dps650ab"
> Again, assuming this is the Delta Electronics power supply, this should
> probably be something like "delta,dps650ab".
OK, I will add delta to compatible property.
Thanks,
Xiaoting
>
> Thanks,
> Guenter
>
>> +- reg : I2C address, one of 0x58, 0x59.
>> +
>> +Example:
>> + dps650ab@58 {
>> + compatible = "dps650ab";
>> + reg = <0x58>;
>> + };
>> --
>> 1.8.3.1
>>
>>
>>
>>
next prev parent reply other threads:[~2019-01-08 8:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1546851856.git.xiaoting.liu@hxt-semitech.com>
2019-01-07 10:57 ` [PATCH v2 1/4] pmbus: associate PMBUS_SKIP_STATUS_CHECK with driver_data Xiaoting Liu
2019-01-07 14:04 ` Guenter Roeck
2019-01-08 8:44 ` Liu, Xiaoting
2019-01-07 11:00 ` [PATCH v2 2/4] dt-bindings: hwmon: add dps650ab documentation Xiaoting Liu
2019-01-07 13:58 ` Guenter Roeck
2019-01-08 8:57 ` Liu, Xiaoting [this message]
2019-01-07 11:06 ` [PATCH v2 4/4] hwmon: (pmbus) add support for DPS-650AB Xiaoting Liu
2019-01-07 14:04 ` Guenter Roeck
2019-01-08 9:13 ` Liu, Xiaoting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d28f64bd2f441d09819d66b55537e0b@HXTBJIDCEMVIW02.hxtcorp.net \
--to=xiaoting.liu@hxt-semitech.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=shunyong.yang@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).