From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marcello Sylvester Bauer <sylv@sylv.io>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add max6639
Date: Fri, 21 Apr 2023 09:37:53 +0200 [thread overview]
Message-ID: <76e57634-75dd-01e8-9c56-36ed7de17812@linaro.org> (raw)
In-Reply-To: <20230420111759.2687001-1-Naresh.Solanki@9elements.com>
On 20/04/2023 13:17, Naresh Solanki wrote:
> From: Marcello Sylvester Bauer <sylv@sylv.io>
>
> Add Devicetree binding documentation for Maxim MAX6639 temperature
> monitor with PWM fan-speed controller.
>
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> ...
Wrong syntax. '...' do not mean anything, it's ---
> Changes in V2:
> - Update subject
> - Drop blank lines
> ---
> .../bindings/hwmon/maxim,max6639.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> new file mode 100644
> index 000000000000..1aaedfd7cee0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim max6639
What is this device? fan controller?
> +
> +maintainers:
> + - Naresh Solanki <Naresh.Solanki@9elements.com>
> +
> +description: |
> + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
> + fan-speed controller. It monitors its own temperature and one external
> + diode-connected transistor or the temperatures of two external diode-connected
> + transistors, typically available in CPUs, FPGAs, or GPUs.
> +
> + Datasheets:
> + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max6639
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
Why do you need these two properties?
Anyway, the binding looks incomplete. Where are the supplies? Interrupts?
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@10 {
> + compatible = "maxim,max6639";
> + reg = <0x10>;
> + };
> + };
> +...
>
> base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-21 7:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 11:17 [PATCH v2 1/2] dt-bindings: hwmon: Add max6639 Naresh Solanki
2023-04-20 11:17 ` [PATCH v2 2/2] hwmon: (max6639) Add compatible string Naresh Solanki
2023-04-21 7:37 ` Krzysztof Kozlowski [this message]
2023-04-24 9:18 ` [PATCH v2 1/2] dt-bindings: hwmon: Add max6639 Naresh Solanki
2023-04-24 9:42 ` Krzysztof Kozlowski
2023-04-24 9:53 ` Naresh Solanki
2023-05-03 8:26 ` Naresh Solanki
2023-05-03 16:18 ` Krzysztof Kozlowski
2023-05-04 9:47 ` Naresh Solanki
2023-05-04 10:47 ` Krzysztof Kozlowski
2023-05-04 11:36 ` Naresh Solanki
2023-05-04 11:44 ` Krzysztof Kozlowski
2023-07-19 17:39 ` Guenter Roeck
2023-07-20 7:51 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e57634-75dd-01e8-9c56-36ed7de17812@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=robh+dt@kernel.org \
--cc=sylv@sylv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).