From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C42C4332F for ; Thu, 13 Oct 2022 15:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiJMPyX (ORCPT ); Thu, 13 Oct 2022 11:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiJMPyU (ORCPT ); Thu, 13 Oct 2022 11:54:20 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C20B9100BD5 for ; Thu, 13 Oct 2022 08:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665676459; x=1697212459; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=YeSfn7nIC0sOEZ9+1/uJh1GJEZWR1dKDgYzX2UYq9nU=; b=gX1OKDmtC/1HEVa04Sjn/ORpkZYQYOZ4Qqq8apZlYdAGmLCRV0CJaOGc QYtvgxvwz58h/JbY9dk+73iUYEzz2uD/CGjt7TWEPbRJQurlGyRA3/cFC btlRufqoUjhDgD0Si7CcMfW4dxZn5ZiL7CmgG6+RmSt00YDWblh2U+42f 3+hSPE2x3+iOhadVH1JoTf+CsS1nqitwUP9IvacQ02W55epBFRDyeT50r 2W4Ud0yaUHc53gD8chJ4TbGg4sH/K/jguz1OPyaQ8yufy789J0k8nl+V7 y3OQrCpUdT84kDJGcinaq45tzEukuLf24qmlwSuIZtihZCzrVkspsG4RI Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="292457258" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="292457258" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:19 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="622210656" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="622210656" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.216.120]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:18 -0700 Date: Thu, 13 Oct 2022 08:54:17 -0700 Message-ID: <87bkqfsora.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: Badal Nilawar , intel-gfx@lists.freedesktop.org, linux-hwmon@vger.kernel.org, andi.shyti@intel.com, tvrtko.ursulin@intel.com, anshuman.gupta@intel.com, dri-devel@lists.freedesktop.org, jon.ewins@intel.com, riana.tauro@intel.com, Jani Nikula , Joonas Lahtinen Subject: Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage In-Reply-To: References: <20220927055020.3499420-1-badal.nilawar@intel.com> <20220927055020.3499420-5-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, 30 Sep 2022 09:52:28 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Tue, Sep 27, 2022 at 11:20:17AM +0530, Badal Nilawar wrote: > > From: Dale B Stimson > > > > Use i915 HWMON to display device level energy input. > > > > v2: Updated the date and kernel version in feature description > > v3: > > - Cleaned up hwm_energy function and removed unused function > > i915_hwmon_energy_status_get (Ashutosh) > > v4: KernelVersion: 6.2, Date: February 2023 in doc (Tvrtko) > > > > Signed-off-by: Dale B Stimson > > Signed-off-by: Ashutosh Dixit > > Signed-off-by: Riana Tauro > > Signed-off-by: Badal Nilawar > > Acked-by: Guenter Roeck > > Reviewed-by: Ashutosh Dixit > > Reviewed-by: Anshuman Gupta > > --- > > .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ > > drivers/gpu/drm/i915/i915_hwmon.c | 107 +++++++++++++++++- > > drivers/gpu/drm/i915/intel_mchbar_regs.h | 2 + > > 3 files changed, 115 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index 16e697b1db3d..7525db243d74 100644 > > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > +++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > @@ -25,3 +25,11 @@ Contact: dri-devel@lists.freedesktop.org > > Description: RO. Card default power limit (default TDP setting). > > > > Only supported for particular Intel i915 graphics platforms. > > + > > +What: /sys/devices/.../hwmon/hwmon/energy1_input > > +Date: February 2023 > > +KernelVersion: 6.2 > > +Contact: dri-devel@lists.freedesktop.org > > I'm sorry for being late on the review here, and I know that others > already looked at the date and other details here in this doc. > So I'm curious why we have decided for the dri-devel mailing list > and not for the intel-gfx since intel-gfx is the only one we have > listed for i915 dir in the MAINTAINERS file: > L: intel-gfx@lists.freedesktop.org I have changed the contact to intel-gfx@lists.freedesktop.org in v9 for all patches. Thanks. -- Ashutosh