From: Quan Nguyen <quan@os.amperecomputing.com>
To: Rob Herring <robh@kernel.org>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers
Date: Wed, 14 Apr 2021 15:28:25 +0700 [thread overview]
Message-ID: <8eb27308-03e3-1a90-28a3-d8b3ad720cc4@os.amperecomputing.com> (raw)
In-Reply-To: <20210413134906.GA1538655@robh.at.kernel.org>
On 13/04/2021 20:49, Rob Herring wrote:
> On Fri, Apr 09, 2021 at 10:13:29AM +0700, Quan Nguyen wrote:
>> Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware
>> reference platform with Ampere's Altra Processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> .../bindings/hwmon/ampere,ac01-hwmon.yaml | 28 +++++
>> .../devicetree/bindings/mfd/ampere,smpro.yaml | 105 ++++++++++++++++++
>> 2 files changed, 133 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
>> create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
>> new file mode 100644
>> index 000000000000..fbf7ec754160
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
>> @@ -0,0 +1,28 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/ampere,ac01-hwmon.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Hardware monitoring driver for the Ampere Altra SMPro
>> +
>> +maintainers:
>> + - Quan Nguyen <quan@os.amperecomputing.com>
>> +
>> +description: |
>> + This module is part of the Ampere Altra SMPro multi-function device. For more
>> + details see ../mfd/ampere,smpro.yaml.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ampere,ac01-hwmon
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> diff --git a/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>> new file mode 100644
>> index 000000000000..5613c420869e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>> @@ -0,0 +1,105 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/ampere,smpro.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Ampere Altra SMPro firmware driver
>> +
>> +maintainers:
>> + - Quan Nguyen <quan@os.amperecomputing.com>
>> +
>> +description: |
>> + Ampere Altra SMPro firmware may contain different blocks like hardware
>> + monitoring, error monitoring and other miscellaneous features.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ampere,smpro
>
> Again, not very specific. There's only 1 version of 'smpro' h/w or
> firmware? Are the firmware version and features discoverable? If not,
> you need to be more specific (or better yet, make them discoverable).
>
Hi Rob,
So far, there's nothing to guarantee this is the only version of SMPro
and neither firmware version nor features that are discoverable.
In fact, it was "ampere,ac01-smpro" specifically in my v1. But this is
the "ampere,smpro" in arch/arm/boot/dts/nuvoton-npcm730-kudo.dts, that
is why it got changed to "ampere,smpro" to avoid changes in that dts file.
I'm thinking about change it back to "ampere,ac01-smpro" in next version
to make this compatible string more specific.
>> +
>> + reg:
>> + description:
>> + I2C device address.
>> + maxItems: 1
>> +
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> +patternProperties:
>> + "^hwmon(@[0-9a-f]+)?$":
>> + $ref: ../hwmon/ampere,ac01-hwmon.yaml
>> +
>> + "^misc(@[0-9a-f]+)?$":
>
> You don't need these child nodes in DT if there are no resources
> associated with them. The parent driver can instantiate all the
> sub-functions.
>
From v3, there is a "reg" property introduced for the child driver,
especially for the misc driver. This is unavoidable because other
properties might be introduced in future for other misc features.
>> + type: object
>> + description: |
>> + This module is part of the Ampere Altra SMPro multi-function device
>> + to support miscellaneous features
>> + properties:
>> + compatible:
>> + enum:
>> + - ampere,ac01-misc
>> + reg:
>> + maxItems: 1
>> +
>> + required:
>> + - compatible
>> + - reg
>> +
>> + "^errmon(@[0-9a-f]+)?$":
>> + type: object
>> + description: |
>> + This module is part of the Ampere Altra SMPro multi-function device
>> + that supports error monitoring feature.
>> +
>> + properties:
>> + compatible:
>> + enum:
>> + - ampere,ac01-errmon
>> + reg:
>> + maxItems: 1
>> +
>> + required:
>> + - compatible
>> + - reg
>> +
>> +required:
>> + - "#address-cells"
>> + - "#size-cells"
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + smpro@4f {
>> + compatible = "ampere,smpro";
>> + reg = <0x4f>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + hwmon@10 {
>> + compatible = "ampere,ac01-hwmon";
>> + reg = <0x10>;
>> + };
>> +
>> + misc@b0 {
>> + compatible = "ampere,ac01-misc";
>> + reg = <0xb0>;
>> + };
>> +
>> + errmon@80 {
>> + compatible = "ampere,ac01-errmon";
>> + reg = <0x80>;
>> + };
>> +
>> + };
>> + };
>> --
>> 2.28.0
>>
next prev parent reply other threads:[~2021-04-14 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 3:13 [PATCH v3 0/4] Add Ampere's Altra SMPro hwmon driver Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers Quan Nguyen
2021-04-13 13:49 ` Rob Herring
2021-04-14 8:28 ` Quan Nguyen [this message]
2021-04-15 12:33 ` Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support Quan Nguyen
2021-04-14 11:52 ` kernel test robot
2021-04-14 12:21 ` Guenter Roeck
2021-04-15 4:15 ` Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-04-14 12:33 ` Guenter Roeck
2021-04-15 4:13 ` Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 4/4] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb27308-03e3-1a90-28a3-d8b3ad720cc4@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).