Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Marcel Bocu <marcel.p.bocu@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, "Woods, Brian" <Brian.Woods@amd.com>,
	Clemens Ladisch <clemens@ladisch.de>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h
Date: Fri, 19 Jul 2019 06:27:01 -0700
Message-ID: <91c6b4cb-2ae4-c2fb-faf4-110b2c426901@roeck-us.net> (raw)
In-Reply-To: <690c10a3-0f5f-6ba7-9dc9-b7150b300dd1@gmail.com>

Hi Marcel,

On 7/19/19 12:40 AM, Marcel Bocu wrote:
> On 18/07/2019 22:33, Guenter Roeck wrote:
>> On Thu, Jul 18, 2019 at 09:26:16PM +0300, Marcel Bocu wrote:
>>> The AMD Ryzen gen 3 processors came with a different PCI IDs for the
>>> function 3 & 4 which are used to access the SMN interface. The root
>>> PCI address however remained at the same address as the model 30h.
>>>
>>> Adding the F3/F4 PCI IDs respectively to the misc and link ids appear
>>> to be sufficient for k10temp, so let's add them and follow up on the
>>> patch if other functions need more tweaking.
>>>
>>> Signed-off-by: Marcel Bocu <marcel.p.bocu@gmail.com>
>>> Tested-by: Marcel Bocu <marcel.p.bocu@gmail.com>
>>>
>>
>> How is this version of the patch series different to the first version ?
> 
> They seem pretty much identical except for the macro's name (71h vs 70h)

Normally (or at least so far) the device ID specifications are for a group
of models, not just for one chip in the group. Traditionally, AMD uses the
same PCI ID for model numbers 7xh, so 70h would probably be more appropriate.
Of course, that is hard to say without documentation from AMD, and I don't
see anything published for Ryzen 3000.

> and the fact that I already Cc:ed the x86 crew. I had checked this
> weekend if there were patches already for this, but I guess Vicki sent
> his patches right after I checked. Sorry for the noise!
> 
> Could anyone add Vicki Pfau (I don't have his email address because I
> subscribed to this list after he sent his patches), and then we can ask
> him if he already submited his patches to x86 or not.
> 
> In any case, whatever patchset gets selected for inclusion, I suggest we
> both sign off on the commit (I do not care about authorship). I will
> anyway try to follow up with other patches to access the chipset's
> temperature and the fan speed.
> 

Wouldn't that require patches to the Super-IO chip on your board ?
That seems orthogonal to this patch series (and to the R3000 CPU).

> Sorry again for the noise!

Sorry myself, I didn't realize that the patches were from different people
since they looked similar.

Guenter

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 18:26 Marcel Bocu
2019-07-18 18:26 ` [PATCH 2/2] hwmon/k10temp: Add support for AMD family 17h, model 71h CPUs Marcel Bocu
2019-07-22 17:46   ` [PATCH v2 2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs Marcel Bocu
2019-07-22 18:23     ` Guenter Roeck
2019-07-22 21:12       ` Marcel Bocu
     [not found] ` <20190718193330.GA23809@roeck-us.net>
2019-07-19  7:40   ` [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h Marcel Bocu
2019-07-19 13:27     ` Guenter Roeck [this message]
2019-07-19 15:30       ` Marcel Bocu
2019-07-19 16:08         ` Guenter Roeck
2019-07-22  8:59           ` Thomas Gleixner
2019-07-22  9:12             ` Borislav Petkov
2019-07-22 16:04               ` Woods, Brian
2019-07-22 16:51                 ` Guenter Roeck
2019-07-22 17:39                   ` Woods, Brian
2019-07-22 18:04                     ` Marcel Bocu
2019-07-22 18:11                       ` Vicki Pfau
2019-07-22 21:09                         ` Marcel Bocu
2019-07-22 22:01                           ` Guenter Roeck
2019-07-22 17:45 ` [PATCH v2 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 70h Marcel Bocu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91c6b4cb-2ae4-c2fb-faf4-110b2c426901@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Brian.Woods@amd.com \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=marcel.p.bocu@gmail.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git