From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15509C25B4E for ; Tue, 24 Jan 2023 15:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234703AbjAXPKB (ORCPT ); Tue, 24 Jan 2023 10:10:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234477AbjAXPKA (ORCPT ); Tue, 24 Jan 2023 10:10:00 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6278648A0B for ; Tue, 24 Jan 2023 07:09:48 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id d14so10504789wrr.9 for ; Tue, 24 Jan 2023 07:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bd7QOS6DKQNvC+u0Ay2yK9OLDkUOBEv/PXTWAR2BBBM=; b=uQujS7Lb/d8GruUmQRDuEQniQPoaVA1Bue2lzduwBpvn9y5qiBepZ04DLH4S++hCO/ v0dfmjIKlKVT+qHGTnGDPfL/zog/atFMKIwaq7F4MNVmmx8rHwb7sg0gWMZ05SK2MCfU E35HnauqPSRCqlIAQb4e8jek6nmkK2Zka6e2c5CboM9qTYyQkKyL0v/LfSJFm+rQyctX pg8dy1o1MXGQVftjW5pmF4eAdnwKS/wV2WqwbBRC+/GKQjmQ/lbLDRU2S+R78xs0nAgD HL0dskJh1CNqjtgu+sZCqPnY9TRC2FAWnjIWgWKGil1CYQydhefziT36iRjZQ3Pkrr8q 2LVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bd7QOS6DKQNvC+u0Ay2yK9OLDkUOBEv/PXTWAR2BBBM=; b=lNoTreziVsrI7uPThNYR2ui7D/l68+InTZ9FN1XpezYX8SIzKnIdzvxuL5gw0yJFOi Tab5KgANAh0XI7cb/y/NeVQXBlX3WD1TLYjyJo2GTSvbSdA27HuVO+8fQ76w9AbRuJCU wlRzGvJ1a1XQWF4qOuexuPZLHPAvWr6zH7RVxYFzaHGUmfUffBNyaJYFSMan9SfYpMKj ji+GbtF2KFNfC3NvBJSeN6R1FfQ8FhaHHEpq+xY82bml45PegZ6QbXl9kv/PjaALnrpV rJssg7RkRKLz+2s0E0f4thH+X8HKQ8CJL5pLYAAIqILFowuoJmZR6v1Imbkw3Wp5F8ie F0WQ== X-Gm-Message-State: AFqh2kpqsUGan+ON24yeuTqlRwl3iokWhE5ZTECqu0hTaCX/o568bnMH lXcVgijbFlSXbkj/Wehiv9bQVg== X-Google-Smtp-Source: AMrXdXuc/zx2xSMvHW7hkFLFb09tioxWpLyLzKdpmMKXs1CBsxLR9q9g0BwnxuyCYKDy1ki6ArsXmw== X-Received: by 2002:a5d:5949:0:b0:2bb:ea1d:e36e with SMTP id e9-20020a5d5949000000b002bbea1de36emr23455035wri.15.1674572986894; Tue, 24 Jan 2023 07:09:46 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g9-20020adfa489000000b002b065272da2sm2180246wrb.13.2023.01.24.07.09.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 07:09:46 -0800 (PST) Message-ID: <94176a1b-f9ad-b096-fc39-5e333f4eb09f@linaro.org> Date: Tue, 24 Jan 2023 16:09:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator Content-Language: en-US To: Naresh Solanki , Guenter Roeck , Jean Delvare Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , linux-kernel@vger.kernel.org References: <20230124144847.423129-1-Naresh.Solanki@9elements.com> <20230124144847.423129-2-Naresh.Solanki@9elements.com> From: Krzysztof Kozlowski In-Reply-To: <20230124144847.423129-2-Naresh.Solanki@9elements.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 24/01/2023 15:48, Naresh Solanki wrote: > From: Patrick Rudolph > > Add the pmbus driver for the Infineon TDA38640 voltage regulator. > > Signed-off-by: Patrick Rudolph > Signed-off-by: Naresh Solanki > --- (...) > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include "pmbus.h" > + > +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { > + PMBUS_REGULATOR("vout", 0), > +}; > + > +static struct pmbus_driver_info tda38640_info = { > + .pages = 1, > + .format[PSC_VOLTAGE_IN] = linear, > + .format[PSC_VOLTAGE_OUT] = linear, > + .format[PSC_CURRENT_OUT] = linear, > + .format[PSC_CURRENT_IN] = linear, > + .format[PSC_POWER] = linear, > + .format[PSC_TEMPERATURE] = linear, > + > + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT > + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP > + | PMBUS_HAVE_IIN > + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT > + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT > + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, > +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) > + .num_regulators = 1, > + .reg_desc = tda38640_reg_desc, > +#endif > +}; > + > +static int tda38640_probe(struct i2c_client *client) > +{ > + return pmbus_do_probe(client, &tda38640_info); > +} > + > +static const struct i2c_device_id tda38640_id[] = { > + {"tda38640", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, tda38640_id); > + > +static const struct of_device_id __maybe_unused tda38640_of_match[] = { > + { .compatible = "infineon,tda38640"}, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tda38640_of_match); No improvements here. Do not send new version without solving the feedback (or finishing the discussion). Its usage is still missing in your i2c_driver. Best regards, Krzysztof