* [PATCH v3 1/2] dt-bindings: trivial-devices: Add Infineon TDA38640 Voltage Regulator @ 2023-01-24 14:48 Naresh Solanki 2023-01-24 14:48 ` [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for " Naresh Solanki 0 siblings, 1 reply; 5+ messages in thread From: Naresh Solanki @ 2023-01-24 14:48 UTC (permalink / raw) To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski Cc: linux-hwmon, krzysztof.kozlowski, Naresh Solanki, Rob Herring, devicetree, linux-kernel Infineon TDA38640 is PMBUS compliant voltage regulator. Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index f5c0a6283e61..a28b02036489 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280 base-commit: 4d891f76a30d3be4194a805c5e4277786140ef05 -- 2.38.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator 2023-01-24 14:48 [PATCH v3 1/2] dt-bindings: trivial-devices: Add Infineon TDA38640 Voltage Regulator Naresh Solanki @ 2023-01-24 14:48 ` Naresh Solanki 2023-01-24 15:09 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Naresh Solanki @ 2023-01-24 14:48 UTC (permalink / raw) To: Guenter Roeck, Jean Delvare Cc: linux-hwmon, krzysztof.kozlowski, Patrick Rudolph, Naresh Solanki, linux-kernel From: Patrick Rudolph <patrick.rudolph@9elements.com> Add the pmbus driver for the Infineon TDA38640 voltage regulator. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> --- drivers/hwmon/pmbus/Kconfig | 16 ++++++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 73 ++++++++++++++++++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 drivers/hwmon/pmbus/tda38640.c diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig index 30448e049486..9f4bbb9c487a 100644 --- a/drivers/hwmon/pmbus/Kconfig +++ b/drivers/hwmon/pmbus/Kconfig @@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640. + + This driver can also be built as a module. If so, the module will + be called tda38640. + +config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator. + config SENSORS_TPS40422 tristate "TI TPS40422" help diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile index d9d2fa4bd6f7..3ae019916267 100644 --- a/drivers/hwmon/pmbus/Makefile +++ b/drivers/hwmon/pmbus/Makefile @@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o diff --git a/drivers/hwmon/pmbus/tda38640.c b/drivers/hwmon/pmbus/tda38640.c new file mode 100644 index 000000000000..6099a3cc568e --- /dev/null +++ b/drivers/hwmon/pmbus/tda38640.c @@ -0,0 +1,73 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Hardware monitoring driver for Infineon TDA38640 + * + * Copyright (c) 2023 9elements GmbH + * + */ + +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { + PMBUS_REGULATOR("vout", 0), +}; + +static struct pmbus_driver_info tda38640_info = { + .pages = 1, + .format[PSC_VOLTAGE_IN] = linear, + .format[PSC_VOLTAGE_OUT] = linear, + .format[PSC_CURRENT_OUT] = linear, + .format[PSC_CURRENT_IN] = linear, + .format[PSC_POWER] = linear, + .format[PSC_TEMPERATURE] = linear, + + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP + | PMBUS_HAVE_IIN + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators = 1, + .reg_desc = tda38640_reg_desc, +#endif +}; + +static int tda38640_probe(struct i2c_client *client) +{ + return pmbus_do_probe(client, &tda38640_info); +} + +static const struct i2c_device_id tda38640_id[] = { + {"tda38640", 0}, + {} +}; +MODULE_DEVICE_TABLE(i2c, tda38640_id); + +static const struct of_device_id __maybe_unused tda38640_of_match[] = { + { .compatible = "infineon,tda38640"}, + { }, +}; +MODULE_DEVICE_TABLE(of, tda38640_of_match); + +/* This is the driver that will be inserted */ +static struct i2c_driver tda38640_driver = { + .driver = { + .name = "tda38640", + }, + .probe_new = tda38640_probe, + .id_table = tda38640_id, +}; + +module_i2c_driver(tda38640_driver); + +MODULE_AUTHOR("Patrick Rudolph <patrick.rudolph@9elements.com>"); +MODULE_DESCRIPTION("PMBus driver for Infineon TDA38640"); +MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(PMBUS); -- 2.38.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator 2023-01-24 14:48 ` [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for " Naresh Solanki @ 2023-01-24 15:09 ` Krzysztof Kozlowski 2023-01-24 15:14 ` Naresh Solanki 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2023-01-24 15:09 UTC (permalink / raw) To: Naresh Solanki, Guenter Roeck, Jean Delvare Cc: linux-hwmon, Patrick Rudolph, linux-kernel On 24/01/2023 15:48, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Add the pmbus driver for the Infineon TDA38640 voltage regulator. > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > --- (...) > + > +#include <linux/err.h> > +#include <linux/i2c.h> > +#include <linux/init.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/regulator/driver.h> > +#include "pmbus.h" > + > +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { > + PMBUS_REGULATOR("vout", 0), > +}; > + > +static struct pmbus_driver_info tda38640_info = { > + .pages = 1, > + .format[PSC_VOLTAGE_IN] = linear, > + .format[PSC_VOLTAGE_OUT] = linear, > + .format[PSC_CURRENT_OUT] = linear, > + .format[PSC_CURRENT_IN] = linear, > + .format[PSC_POWER] = linear, > + .format[PSC_TEMPERATURE] = linear, > + > + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT > + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP > + | PMBUS_HAVE_IIN > + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT > + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT > + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, > +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) > + .num_regulators = 1, > + .reg_desc = tda38640_reg_desc, > +#endif > +}; > + > +static int tda38640_probe(struct i2c_client *client) > +{ > + return pmbus_do_probe(client, &tda38640_info); > +} > + > +static const struct i2c_device_id tda38640_id[] = { > + {"tda38640", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, tda38640_id); > + > +static const struct of_device_id __maybe_unused tda38640_of_match[] = { > + { .compatible = "infineon,tda38640"}, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tda38640_of_match); No improvements here. Do not send new version without solving the feedback (or finishing the discussion). Its usage is still missing in your i2c_driver. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator 2023-01-24 15:09 ` Krzysztof Kozlowski @ 2023-01-24 15:14 ` Naresh Solanki 2023-01-24 17:41 ` Guenter Roeck 0 siblings, 1 reply; 5+ messages in thread From: Naresh Solanki @ 2023-01-24 15:14 UTC (permalink / raw) To: Krzysztof Kozlowski, Guenter Roeck, Jean Delvare Cc: linux-hwmon, Patrick Rudolph, linux-kernel On 24-01-2023 08:39 pm, Krzysztof Kozlowski wrote: > On 24/01/2023 15:48, Naresh Solanki wrote: >> From: Patrick Rudolph <patrick.rudolph@9elements.com> >> >> Add the pmbus driver for the Infineon TDA38640 voltage regulator. >> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> >> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >> --- > > (...) > >> + >> +#include <linux/err.h> >> +#include <linux/i2c.h> >> +#include <linux/init.h> >> +#include <linux/kernel.h> >> +#include <linux/module.h> >> +#include <linux/regulator/driver.h> >> +#include "pmbus.h" >> + >> +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { >> + PMBUS_REGULATOR("vout", 0), >> +}; >> + >> +static struct pmbus_driver_info tda38640_info = { >> + .pages = 1, >> + .format[PSC_VOLTAGE_IN] = linear, >> + .format[PSC_VOLTAGE_OUT] = linear, >> + .format[PSC_CURRENT_OUT] = linear, >> + .format[PSC_CURRENT_IN] = linear, >> + .format[PSC_POWER] = linear, >> + .format[PSC_TEMPERATURE] = linear, >> + >> + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT >> + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP >> + | PMBUS_HAVE_IIN >> + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT >> + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT >> + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, >> +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) >> + .num_regulators = 1, >> + .reg_desc = tda38640_reg_desc, >> +#endif >> +}; >> + >> +static int tda38640_probe(struct i2c_client *client) >> +{ >> + return pmbus_do_probe(client, &tda38640_info); >> +} >> + >> +static const struct i2c_device_id tda38640_id[] = { >> + {"tda38640", 0}, >> + {} >> +}; >> +MODULE_DEVICE_TABLE(i2c, tda38640_id); >> + >> +static const struct of_device_id __maybe_unused tda38640_of_match[] = { >> + { .compatible = "infineon,tda38640"}, >> + { }, >> +}; >> +MODULE_DEVICE_TABLE(of, tda38640_of_match); > > No improvements here. Do not send new version without solving the > feedback (or finishing the discussion). Its usage is still missing in > your i2c_driver. I realized I missed reference to tda38640_of_match below. static struct i2c_driver tda38640_driver = { .driver = { .name = "tda38640", .of_match_table = of_match_ptr(tda38640_of_match), }, .probe_new = tda38640_probe, .id_table = tda38640_id, }; Will fix that. > > Best regards, > Krzysztof > Thanks, Naresh ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator 2023-01-24 15:14 ` Naresh Solanki @ 2023-01-24 17:41 ` Guenter Roeck 0 siblings, 0 replies; 5+ messages in thread From: Guenter Roeck @ 2023-01-24 17:41 UTC (permalink / raw) To: Naresh Solanki Cc: Krzysztof Kozlowski, Jean Delvare, linux-hwmon, Patrick Rudolph, linux-kernel On Tue, Jan 24, 2023 at 08:44:18PM +0530, Naresh Solanki wrote: > > > On 24-01-2023 08:39 pm, Krzysztof Kozlowski wrote: > > On 24/01/2023 15:48, Naresh Solanki wrote: > > > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > > > > > Add the pmbus driver for the Infineon TDA38640 voltage regulator. > > > > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > > --- > > > > (...) > > > > > + > > > +#include <linux/err.h> > > > +#include <linux/i2c.h> > > > +#include <linux/init.h> > > > +#include <linux/kernel.h> > > > +#include <linux/module.h> > > > +#include <linux/regulator/driver.h> > > > +#include "pmbus.h" > > > + > > > +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { > > > + PMBUS_REGULATOR("vout", 0), > > > +}; > > > + > > > +static struct pmbus_driver_info tda38640_info = { > > > + .pages = 1, > > > + .format[PSC_VOLTAGE_IN] = linear, > > > + .format[PSC_VOLTAGE_OUT] = linear, > > > + .format[PSC_CURRENT_OUT] = linear, > > > + .format[PSC_CURRENT_IN] = linear, > > > + .format[PSC_POWER] = linear, > > > + .format[PSC_TEMPERATURE] = linear, > > > + > > > + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT > > > + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP > > > + | PMBUS_HAVE_IIN > > > + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT > > > + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT > > > + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, > > > +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) > > > + .num_regulators = 1, > > > + .reg_desc = tda38640_reg_desc, > > > +#endif > > > +}; > > > + > > > +static int tda38640_probe(struct i2c_client *client) > > > +{ > > > + return pmbus_do_probe(client, &tda38640_info); > > > +} > > > + > > > +static const struct i2c_device_id tda38640_id[] = { > > > + {"tda38640", 0}, > > > + {} > > > +}; > > > +MODULE_DEVICE_TABLE(i2c, tda38640_id); > > > + > > > +static const struct of_device_id __maybe_unused tda38640_of_match[] = { > > > + { .compatible = "infineon,tda38640"}, > > > + { }, > > > +}; > > > +MODULE_DEVICE_TABLE(of, tda38640_of_match); > > > > No improvements here. Do not send new version without solving the > > feedback (or finishing the discussion). Its usage is still missing in > > your i2c_driver. > I realized I missed reference to tda38640_of_match below. > > static struct i2c_driver tda38640_driver = { > .driver = { > .name = "tda38640", > .of_match_table = of_match_ptr(tda38640_of_match), > }, Column alignment also looks off. I would expect tabs only, like .driver = { .name = "tda38640", .of_match_table = of_match_ptr(tda38640_of_match), }, Guenter > .probe_new = tda38640_probe, > .id_table = tda38640_id, > }; > > Will fix that. > > > > Best regards, > > Krzysztof > > > Thanks, > Naresh ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-24 17:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-01-24 14:48 [PATCH v3 1/2] dt-bindings: trivial-devices: Add Infineon TDA38640 Voltage Regulator Naresh Solanki 2023-01-24 14:48 ` [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for " Naresh Solanki 2023-01-24 15:09 ` Krzysztof Kozlowski 2023-01-24 15:14 ` Naresh Solanki 2023-01-24 17:41 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).