From: Guenter Roeck <linux@roeck-us.net>
To: Qing Wang <wangqing@vivo.com>, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: replace snprintf in show functions with sysfs_emit
Date: Fri, 15 Oct 2021 15:00:59 -0700 [thread overview]
Message-ID: <96c3c93c-f959-a401-3c91-df58e2643a39@roeck-us.net> (raw)
In-Reply-To: <1634280525-4532-1-git-send-email-wangqing@vivo.com>
On 10/14/21 11:48 PM, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
Please refrain from such cleanup patches unless you also
make functional changes to a driver.
Guenter
> ---
> drivers/hwmon/smm665.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c
> index 62906d9..122031e 100644
> --- a/drivers/hwmon/smm665.c
> +++ b/drivers/hwmon/smm665.c
> @@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \
> { \
> struct sensor_device_attribute *attr = to_sensor_dev_attr(da); \
> const int val = smm665_get_##what(dev, attr->index); \
> - return snprintf(buf, PAGE_SIZE, "%d\n", val); \
> + return sysfs_emit(buf, "%d\n", val); \
> }
>
> SMM665_SHOW(min);
>
next prev parent reply other threads:[~2021-10-15 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:48 [PATCH] hwmon: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15 22:00 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-22 4:23 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96c3c93c-f959-a401-3c91-df58e2643a39@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).