From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] hwmon: (f71882fg) Mark expected switch fall-through
Date: Tue, 12 Feb 2019 16:08:11 -0600 [thread overview]
Message-ID: <9b149f13-7f2f-71e7-06d7-e64ebbd3c4b8@embeddedor.com> (raw)
In-Reply-To: <20190212215105.GA17643@roeck-us.net>
On 2/12/19 3:51 PM, Guenter Roeck wrote:
> On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’:
>> drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> data->auto_point_temp_signed = 1;
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
>> drivers/hwmon/f71882fg.c:2459:3: note: here
>> case f71889fg:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied to hwmon-next.
>
Thanks, Guenter.
--
Gustavo
prev parent reply other threads:[~2019-02-12 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 22:07 [PATCH] hwmon: (f71882fg) Mark expected switch fall-through Gustavo A. R. Silva
2019-02-12 21:51 ` Guenter Roeck
2019-02-12 22:08 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b149f13-7f2f-71e7-06d7-e64ebbd3c4b8@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=jdelvare@suse.com \
--cc=keescook@chromium.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).