linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Guenter Roeck <linux@roeck-us.net>,
	Hardware Monitoring <linux-hwmon@vger.kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 3/3] hwmon: (adm9240) Convert to devm_hwmon_device_register_with_info API
Date: Wed, 12 May 2021 22:58:07 +0000	[thread overview]
Message-ID: <9bed7b7a-9fe9-c6c5-1de9-390ddce9b052@alliedtelesis.co.nz> (raw)
In-Reply-To: <8401b580-66f4-c4f1-a5d5-41c66530eaca@roeck-us.net>


On 13/05/21 10:51 am, Guenter Roeck wrote:
> On 5/12/21 3:41 PM, Chris Packham wrote:
>>
>> On 13/05/21 10:35 am, Guenter Roeck wrote:
>>> On 5/12/21 3:09 PM, Guenter Roeck wrote:
>>>> On 5/12/21 2:54 PM, Chris Packham wrote:
>>>>> Hi Guenter,
>>>>>
>>>>> On 11/03/21 8:33 pm, Guenter Roeck wrote:
>>>>>> Also use regmap for register caching. This change reduces code and
>>>>>> data size by more than 40%.
>>>>>>
>>>>>> While at it, fixed some warnings reported by checkpatch.
>>>>>>
>>>>>> Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
>>>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>>>
>>>>> I've just been informed by our QA team that it looks like the
>>>>> configuration of limits (e.g. by writing to sysfs) has been broken.
>>>>> Probably by this change. I'm just starting to dig into it now but I
>>>>> though I'd give you a heads up.
>>>>>
>>>>
>>>> Thanks for the heads up.
>>>>
>>>> It looks like voltage maximum writes use the wrong register,
>>>> ADM9240_REG_IN instead of ADM9240_REG_IN_MAX.
>>>> Odd, I'd have assumed that my module test code catches that.
>>>> I'll have to check why it doesn't.
>>>>
>>>
>>> Yes, turns out my module test script does not catch that situation.
>>> It tries to find the value range and determines that there is no range
>>> (because all writes are into the wrong register). I'll have to fix 
>>> that.
>>>
>>>> Anyway, anything more specific ?
>>>>
>>> I'll wait for your response before submitting a patch.
>>>
>> I agree that the writes to max aren't working. Haven't checked min.
>>
>> [root@awplus flash]# cat /sys/class/hwmon/hwmon0/in5_max
>> 3586
>> [root@awplus flash]# echo 1097 >/sys/class/hwmon/hwmon0/in5_max
>> [root@awplus flash]# cat /sys/class/hwmon/hwmon0/in5_max
>> 3586
>>
>
> Anything else ? I got a patch ready to fix that, but I would prefer to
> fix everything in one go if possible. My (fixed) module test script
> doesn't pick up other problems, but obviously we can't really trust it.
>
Everything else seems OK, I think it was just the max. That was 
certainly the only thing the QA team was complaining about.

Thanks for the quick work.

> Thanks,
> Guenter

  reply	other threads:[~2021-05-12 23:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  7:33 [PATCH 1/3] hwmon: (adm9240) Drop log messages from detect function Guenter Roeck
2021-03-11  7:33 ` [PATCH 2/3] hwmon: (adm9240) Store i2c device instead of client in local data Guenter Roeck
2021-03-11 21:10   ` Chris Packham
2021-03-11  7:33 ` [PATCH 3/3] hwmon: (adm9240) Convert to devm_hwmon_device_register_with_info API Guenter Roeck
2021-03-11 21:10   ` Chris Packham
2021-05-12 21:54   ` Chris Packham
2021-05-12 22:09     ` Guenter Roeck
2021-05-12 22:35       ` Guenter Roeck
2021-05-12 22:41         ` Chris Packham
2021-05-12 22:51           ` Guenter Roeck
2021-05-12 22:58             ` Chris Packham [this message]
2021-03-11 21:09 ` [PATCH 1/3] hwmon: (adm9240) Drop log messages from detect function Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bed7b7a-9fe9-c6c5-1de9-390ddce9b052@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).