linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Marius Zachmann <mail@mariuszachmann.de>
Cc: Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: corsair-cpro: Change to HID driver
Date: Wed, 15 Jul 2020 12:49:59 -0700	[thread overview]
Message-ID: <9fc09eec-7921-68ab-b3c7-1d83d3e09817@roeck-us.net> (raw)
In-Reply-To: <51449356.7lugSRDzgr@marius>

On 7/15/20 12:12 PM, Marius Zachmann wrote:
> On 15.07.20 at 17:35:08 CEST, Guenter Roeck wrote
>> On 7/15/20 8:14 AM, Marius Zachmann wrote:
>>> This changes corsair-cpro to a hid driver using hid reports.
>>>
>>> Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>
>>>
>>> ---
>>
> ...
>>> -module_usb_driver(ccp_driver);
>>> +static int __init ccp_init(void)
>>> +{
>>> +	return hid_register_driver(&ccp_driver);
>>> +}
>>> +
>>> +static void __exit ccp_exit(void)
>>> +{
>>> +	hid_unregister_driver(&ccp_driver);
>>> +}
>>> +
>>> +/* make sure it is loaded after hid */
>>> +late_initcall(ccp_init);
>>> +module_exit(ccp_exit);
>>
>> Sorry for not noticing before, but can you use module_hid_driver() ?
>> That seems to work for other hid drivers.
>>
>> Thanks,
>> Guenter
>>
> 
> When using module_hid_driver() and compiling the driver as built-in
> the driver init function will get called before hid and fail registering
> the driver. late_initcall forces it to be loaded after hid.
> 

That seems odd. Why does no other hid driver have that problem ?
Your argument is pretty much that module_hid_driver() would not work,
which seems unlikely.

Thanks,
Guenter

  reply	other threads:[~2020-07-15 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 15:14 [PATCH v2] hwmon: corsair-cpro: Change to HID driver Marius Zachmann
2020-07-15 15:35 ` Guenter Roeck
2020-07-15 19:12   ` Marius Zachmann
2020-07-15 19:49     ` Guenter Roeck [this message]
2020-07-15 19:55       ` Marius Zachmann
2020-07-15 20:11         ` Guenter Roeck
2020-07-15 20:22           ` Marius Zachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fc09eec-7921-68ab-b3c7-1d83d3e09817@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@mariuszachmann.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).