From: Vadim Pasternak <vadimp@mellanox.com>
To: Guenter Roeck <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"vijaykhemka@fb.com" <vijaykhemka@fb.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [RFC PATCH hwmon-next v1 2/5] hwmon: (pmbus/core) Add support for Intel IMVP9 specification
Date: Mon, 6 Jan 2020 12:14:19 +0000 [thread overview]
Message-ID: <AM6PR05MB522432BAECB79FB87D6DDA2DA23C0@AM6PR05MB5224.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0be6b849-939d-49a7-476e-62bf201fdd93@roeck-us.net>
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Sunday, January 05, 2020 6:26 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; robh+dt@kernel.org;
> vijaykhemka@fb.com
> Cc: linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [RFC PATCH hwmon-next v1 2/5] hwmon: (pmbus/core) Add support
> for Intel IMVP9 specification
>
> On 1/5/20 2:58 AM, Vadim Pasternak wrote:
> > Extend "vrm_version" with support for Intel IMVP9 specification.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/hwmon/pmbus/pmbus.h | 2 +-
> > drivers/hwmon/pmbus/pmbus_core.c | 4 ++++
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
> > index 2bdebd0ea9c1..c6b2401f1c6c 100644
> > --- a/drivers/hwmon/pmbus/pmbus.h
> > +++ b/drivers/hwmon/pmbus/pmbus.h
> > @@ -377,7 +377,7 @@ enum pmbus_sensor_classes {
> > #define PMBUS_PAGE_VIRTUAL BIT(31)
> >
> > enum pmbus_data_format { linear = 0, direct, vid }; -enum
> > vrm_version { vr11 = 0, vr12, vr13 };
> > +enum vrm_version { vr11 = 0, vr12, vr13, imvp9 };
> >
> > struct pmbus_driver_info {
> > int pages; /* Total number of pages */
> > diff --git a/drivers/hwmon/pmbus/pmbus_core.c
> > b/drivers/hwmon/pmbus/pmbus_core.c
> > index 98226e84b351..a9b7b555cf6e 100644
> > --- a/drivers/hwmon/pmbus/pmbus_core.c
> > +++ b/drivers/hwmon/pmbus/pmbus_core.c
> > @@ -709,6 +709,10 @@ static long pmbus_reg2data_vid(struct pmbus_data
> *data,
> > if (val >= 0x01)
> > rv = 500 + (val - 1) * 10;
> > break;
> > + case imvp9:
> > + if (val >= 0x01)
> > + rv = 200 + (val - 1) * 10;
> > + break;
>
> There is also Intel VR14, and there is some indication that it is identical to imvp9.
> If that is the case, I would prefer to use existing terminology.
> Unfortunately, Intel is a bit close-lipped about both. If you have access to
> documentation, can you check ?
Hi Guenter,
It's really tricky to find some clear Intel doc on for that.
I checked it with ours and Infineon HW guys.
IMVP9 has a different VID table than VR13HC/VR14.
For v14 we can use the same formula as we are using for vr13.
IMVP9 is different because it has a different voltage range.
The 5mV VID table of VR14 supports a voltage range from
0.25V to 1.52V.
The 10mV VID table of VR14 supports a voltage range from
0.5V t0 3.04V.
The IMVP9 VID table also has a 10mV step, but the voltage range
is from 0.2 to 2.74V.
Thanks,
Vadim.
>
> Thanks,
> Guenter
>
> > }
> > return rv;
> > }
> >
next prev parent reply other threads:[~2020-01-06 12:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 10:58 [RFC PATCH hwmon-next v1 0/5] hwmon: (pmbus) Add support for vid mode calculation per page bases Vadim Pasternak
2020-01-05 10:58 ` [RFC PATCH hwmon-next v1 1/5] hwmon: (pmbus/core) Add support for vid mode detection " Vadim Pasternak
2020-01-05 10:58 ` [RFC PATCH hwmon-next v1 2/5] hwmon: (pmbus/core) Add support for Intel IMVP9 specification Vadim Pasternak
2020-01-05 16:26 ` Guenter Roeck
2020-01-05 17:15 ` Vadim Pasternak
2020-01-06 12:14 ` Vadim Pasternak [this message]
2020-01-05 10:58 ` [RFC PATCH hwmon-next v1 3/5] hwmon: (pmbus/tps53679) Allow " Vadim Pasternak
2020-01-05 10:58 ` [RFC PATCH hwmon-next v1 4/5] dt-bindings: Add TI and Infineon VR Controllers as trivial devices Vadim Pasternak
2020-01-05 10:58 ` [RFC PATCH hwmon-next v1 5/5] hwmon: (pmbus/tps53679) Extend device list supported by driver Vadim Pasternak
2020-01-05 16:03 ` Guenter Roeck
2020-01-05 16:44 ` Vadim Pasternak
2020-01-05 18:34 ` Guenter Roeck
2020-01-06 12:16 ` Vadim Pasternak
2020-01-06 14:52 ` Guenter Roeck
2020-01-06 16:57 ` Vadim Pasternak
2020-01-06 21:01 ` Guenter Roeck
2020-01-06 22:29 ` Vadim Pasternak
2020-01-07 1:28 ` Guenter Roeck
2020-01-07 6:06 ` Vadim Pasternak
2020-01-07 12:14 ` Guenter Roeck
2020-01-08 14:10 ` Vadim Pasternak
2020-01-08 16:47 ` Guenter Roeck
2020-01-13 12:25 ` Vadim Pasternak
2020-01-13 20:56 ` Guenter Roeck
2020-01-14 6:54 ` Vadim Pasternak
2020-01-14 14:19 ` Guenter Roeck
2020-01-16 19:54 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR05MB522432BAECB79FB87D6DDA2DA23C0@AM6PR05MB5224.eurprd05.prod.outlook.com \
--to=vadimp@mellanox.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=vijaykhemka@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).