From: "Tremblay, Eric" <etremblay@distech-controls.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips
Date: Tue, 1 Oct 2019 21:36:30 +0000 [thread overview]
Message-ID: <BL0PR01MB483577C3306C3B16A6CB24B4959D0@BL0PR01MB4835.prod.exchangelabs.com> (raw)
In-Reply-To: <20191001183724.GB23564@roeck-us.net>
> On Tue, Oct 01, 2019 at 05:50:32PM +0000, Tremblay, Eric wrote:
> > hwmon: Add DT bindings for TMP513 driver
> >
> > Signed-off-by: Eric Tremblay <etremblay@distech-controls.com>
> > ---
> > .../devicetree/bindings/hwmon/tmp513.txt | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/tmp513.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/tmp513.txt
> > b/Documentation/devicetree/bindings/hwmon/tmp513.txt
> > new file mode 100644
> > index 000000000000..0f61793cbf2f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/tmp513.txt
> > @@ -0,0 +1,33 @@
> > +TMP513 system monitor sensor
> > +-------------------------
> > +
> > +Require node properties:
> > +- compatible: one of
> > + "ti,tmp512"
> > + "ti,tmp513"
> > +- reg : the I2C address of the device. This is 0x5c, 0x5d, 0x5e, or 0x5f.
> > +- shunt-resistor-uohm : The shunt resistor value in uOhm.
> > +
> > +Optional properties:
> > +- bus-voltage-range: 32V or 16V, default to 32V.
> > +- max-expected-current-ma: Maximum expected current value. Default to max possible value.
> > +- pga-gain: The gain value for the PGA function. This is 8, 4, 2 or 1. Default to 8.
> > +- temp_2_nfactor: nFactor for remote channel 1. Value according to Table 11 in datasheet.
> > +- temp_3_nfactor: nFactor for remote channel 2. Value according to Table 11 in datasheet.
> > +- temp_4_nfactor: nFactor for remote channel 3. Value according to Table 11 in datasheet,
> > + TMP513 only.
> > +- temp_hysteresis: Hystereris for temperature limits.
>
> There is a standard sysfs attribute for hysteresis values, and I assume this is one parameter that users might want to change at
> runtime. Why not use it ?
In those sensors, the hysteresis setting is global to all channels. Is it still a standard sysfs attribute in that case ? If yes, should I name it
temp_crit_hyst to show that is a global parameter ?
>
> > +
> > +Example:
> > + tmp513@5c {
> > + compatible = "ti,tmp513";
> > + reg = <0x5C>;
> > + shunt-resistor-uohm = <330>;
> > + bus-voltage-range = <32>;
> > + pga-gain = <8>;
> > + max-expected-current-ma = <100>;
> > + temp_2_nfactor = <0x01>;
> > + temp_3_nfactor = <0x02>;
> > + temp_4_nfactor = <0x03>;
> > + temp_hysteresis = <5>;
> > + };
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2019-10-01 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:50 [PATCH v2 2/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips Tremblay, Eric
2019-10-01 18:37 ` Guenter Roeck
2019-10-01 21:36 ` Tremblay, Eric [this message]
2019-10-01 22:35 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR01MB483577C3306C3B16A6CB24B4959D0@BL0PR01MB4835.prod.exchangelabs.com \
--to=etremblay@distech-controls.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).