From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDF4C43460 for ; Wed, 14 Apr 2021 08:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF9DD61179 for ; Wed, 14 Apr 2021 08:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232181AbhDNIEM (ORCPT ); Wed, 14 Apr 2021 04:04:12 -0400 Received: from office2.cesnet.cz ([195.113.144.244]:35470 "EHLO office2.cesnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349880AbhDNIDb (ORCPT ); Wed, 14 Apr 2021 04:03:31 -0400 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id E113440006D; Wed, 14 Apr 2021 10:02:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1618387370; bh=VL+3Khe0pTD/l2rOSGRuJdOoL2SvZynD8rVDjpFMxG4=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=k+LZ1KkbwicpSivb9kbGRF54c5MYAbcKOPXglu7THalVBLwgXPGnqkQnPjwLU5ETY f3DJptZHGoyL19FK/fHyhjbwgaN0ToLVVIHIP7w43lUIb8yjxq66ayZ8r8tcpEn1OS tcMJj7gJJAutzdvR4iz7xh3X69frbiVyxH2eX9N4Y/PK0Q3klZejR60PHO/pz5i7VC 7CLuo/dcXj+7Z3tXPAQn3AdFW23Qs8XbGE/AyBksJmPrgu/Q/ZBng9mByMUkSFSwCq aLMsNEe42XvX91HXPkzgJ2nY9vPshhzw0LUOn11D7PcJus7XrDBokfNx2txSHDkYX+ 5bBoIogzn6NGw== Received: by mail-pg1-f177.google.com with SMTP id q10so13837449pgj.2; Wed, 14 Apr 2021 01:02:50 -0700 (PDT) X-Gm-Message-State: AOAM530Ra2GSXAYKwP0WXVEM0nzFAgisCBrLErtAKL5hyZKXjBXeQt/z DqHNwFh7MBo0XvdWtN/aNDx2ipb9k0iJs9CEvlM= X-Google-Smtp-Source: ABdhPJy+0298vwEUg05EWx7t5fB0g2In9DE2gbsBf5kChy0/MbPy1qlZcfKQpji0MJ3w6Y2k+XZ62DsKCbGfmQs38lw= X-Received: by 2002:a63:2404:: with SMTP id k4mr1212088pgk.381.1618387369456; Wed, 14 Apr 2021 01:02:49 -0700 (PDT) MIME-Version: 1.0 References: <20210329143833.1047539-1-kubernat@cesnet.cz> <20210414001308.3434548-1-kubernat@cesnet.cz> <20210414032902.GA242591@roeck-us.net> In-Reply-To: <20210414032902.GA242591@roeck-us.net> From: =?UTF-8?B?VsOhY2xhdiBLdWJlcm7DoXQ=?= Date: Wed, 14 Apr 2021 10:02:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5] hwmon: Add driver for fsp-3y PSUs and PDUs To: Guenter Roeck Cc: Jean Delvare , Jonathan Corbet , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org st 14. 4. 2021 v 5:29 odes=C3=ADlatel Guenter Roeck na= psal: > > On Wed, Apr 14, 2021 at 02:13:06AM +0200, V=C3=A1clav Kubern=C3=A1t wrote= : > > This patch adds support for these devices: > > - YH-5151E - the PDU > > - YM-2151E - the PSU > > > > The device datasheet says that the devices support PMBus 1.2, but in my > > testing, a lot of the commands aren't supported and if they are, they > > sometimes behave strangely or inconsistently. For example, writes to th= e > > PAGE command requires using PEC, otherwise the write won't work and the > > page won't switch, even though, the standard says that PEC is optional. > > On the other hand, writes to SMBALERT don't require PEC. Because of > > this, the driver is mostly reverse engineered with the help of a tool > > called pmbus_peek written by David Brownell (and later adopted by my > > colleague Jan Kundr=C3=A1t). > > > > The device also has some sort of a timing issue when switching pages, > > which is explained further in the code. > > > > Because of this, the driver support is limited. It exposes only the > > values, that have been tested to work correctly. > > > > Signed-off-by: V=C3=A1clav Kubern=C3=A1t > > checkpatch says: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > #108: FILE: Documentation/hwmon/fsp-3y.rst:1: > +Kernel driver fsp3y > > WARNING: line length of 137 exceeds 100 columns > #409: FILE: drivers/hwmon/pmbus/fsp-3y.c:225: > + dev_warn(&client->dev, "Device mismatch: Configured %s (%= d), detected %d\n", id->name, (int)id->driver_data, data->chip); > > Please fix and resubmit. > Done. V=C3=A1clav > Thanks, > Guenter