From: "Václav Kubernát" <kubernat@cesnet.cz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] hwmon: Add driver for fsp-3y PSUs and PDUs
Date: Tue, 13 Apr 2021 12:54:05 +0200 [thread overview]
Message-ID: <CABKa3nqhbnDTsSQc4xgo0gvGR3xeiznJPt_nK-wA_U9aoYXg+w@mail.gmail.com> (raw)
In-Reply-To: <78016097-21df-8321-8b8b-33d15a6e6ff2@roeck-us.net>
út 13. 4. 2021 v 7:36 odesílatel Guenter Roeck <linux@roeck-us.net> napsal:
>
> On 4/12/21 9:31 PM, Václav Kubernát wrote:
> [ ... ]
> > Okay, I have made some additional testing. Some of the registers
> > return 0xFFFF, some don't. These are the ones that pmbus_core queries
> > when the driver is loading (with values I got from
> > i2c_smbus_read_word_data):
> > PMBUS_POUT_MAX 0xFFFF
> > PMBUS_FAN_COMMAND_1 0x0
> > PMBUS_VOUT_OV_FAULT_LIMIT 0xFFFF
> > PMBUS_VOUT_OV_WARN_LIMIT 0xFFFF
> > PMBUS_VOUT_UV_WARN_LIMIT 0xFFFF
> > PMBUS_VOUT_UV_FAULT_LIMIT 0xFFFF
> > PMBUS_IOUT_OC_FAULT_LIMIT 0xFFFF
> > PMBUS_IOUT_OC_WARN_LIMIT 0x10
> > PMBUS_IOUT_UC_FAULT_LIMIT 0xFFFF
> > PMBUS_OT_FAULT_LIMIT 0xFFFF
> > PMBUS_OT_WARN_LIMIT 0xFFFFFFB6
> > PMBUS_UT_WARN_LIMIT 0xFFFF
> > PMBUS_UT_FAULT_LIMIT 0xFFFF
> > PMBUS_VIN_OV_FAULT_LIMIT 0xFFFF
> > PMBUS_VIN_OV_WARN_LIMIT 0xFFFF
> > PMBUS_VIN_UV_WARN_LIMIT 0xFFFF
> > PMBUS_VIN_UV_FAULT_LIMIT 0xFFFF
> > PMBUS_IIN_OC_FAULT_LIMIT 0xFFFF
> > PMBUS_IIN_OC_WARN_LIMIT 0x0
> > PMBUS_POUT_OP_FAULT_LIMIT 0xFFFF
> > PMBUS_POUT_OP_WARN_LIMIT 0xFFFFFFB6
> > PMBUS_PIN_OP_WARN_LIMIT 0x0
> > PMBUS_READ_FAN_SPEED_2 0x0
> > PMBUS_MFR_VIN_MIN 0x5A
> > PMBUS_MFR_VIN_MAX 0x108
> > PMBUS_MFR_IIN_MAX 0x3
> > PMBUS_MFR_PIN_MAX 0xC8
> > PMBUS_MFR_VOUT_MIN 0x1748
> > PMBUS_MFR_VOUT_MAX 0x18B0
> > PMBUS_MFR_IOUT_MAX 0xF
> > PMBUS_MFR_POUT_MAX 0x96
> > PMBUS_MFR_MAX_TEMP_1 0xFFFF
> > PMBUS_MFR_MAX_TEMP_2 0xFFFF
> >
>
> The question is really what the status register reports for those.
> I bet that PMBUS_STATUS_CML will set the "invalid command" bit
> for many if not all registers returning 0xffff. Those will
> be filtered out by the PMBus core automatically. That leaves the
> ones returning some data. Of course it would be desirable
> to have those supported, but I can understand if you don't know
> the encoding. The reason for masking those needs to be explained.
>
I thought I sent the v4 patch before, but it seems that I only sent it
to myself. Also, I realized I've sent some of the emails only to you.
That wasn't my intention. Sorry. I'm bad at emailing.
Anyway, I have posted the v4 patch right now and it includes a comment
about the masking.
Václav
> Thanks,
> Guenter
next prev parent reply other threads:[~2021-04-13 10:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 14:38 [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs Václav Kubernát
2021-03-29 17:47 ` Guenter Roeck
2021-03-30 3:31 ` Václav Kubernát
2021-03-30 5:39 ` Guenter Roeck
2021-03-29 19:07 ` kernel test robot
2021-03-29 20:42 ` kernel test robot
2021-04-08 2:34 ` [PATCH v2] " Václav Kubernát
2021-04-08 3:44 ` Guenter Roeck
2021-04-09 1:27 ` [PATCH v3] " Václav Kubernát
2021-04-09 2:08 ` Guenter Roeck
[not found] ` <CABKa3npa9vra9jRrrG--3gtun7HtsAVxQvfzsV5rYTQDoDNN9g@mail.gmail.com>
[not found] ` <78016097-21df-8321-8b8b-33d15a6e6ff2@roeck-us.net>
2021-04-13 10:54 ` Václav Kubernát [this message]
2021-04-13 10:42 ` [PATCH v4] " Václav Kubernát
2021-04-13 14:59 ` Guenter Roeck
2021-04-14 0:27 ` Václav Kubernát
2021-04-14 0:13 ` [PATCH v5] " Václav Kubernát
[not found] ` <20210414032902.GA242591@roeck-us.net>
2021-04-14 8:02 ` Václav Kubernát
2021-04-14 8:00 ` [PATCH v6] " Václav Kubernát
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABKa3nqhbnDTsSQc4xgo0gvGR3xeiznJPt_nK-wA_U9aoYXg+w@mail.gmail.com \
--to=kubernat@cesnet.cz \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).