From: Joaquin Aramendia <samsagax@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: hdegoede@redhat.com, markgross@kernel.org, jdelvare@suse.com,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] Add OneXPlayer mini AMD board driver
Date: Mon, 31 Oct 2022 08:45:35 -0300 [thread overview]
Message-ID: <CABgtM3g9_-hpDfdb=kDqOerQAj+kn3pEbOcvmG_Lve3ETAXFfA@mail.gmail.com> (raw)
In-Reply-To: <c6c16bc6-d86b-84ca-e49a-0788f9c80006@roeck-us.net>
Hello again and thanks for the review. I submitted the patch again and
needs some polish before it can be accepted. I had one question left:
El dom, 30 oct 2022 a la(s) 00:24, Guenter Roeck (linux@roeck-us.net) escribió:
>
> >>> +/* Callbacks for hwmon interface */
> >>> +static umode_t oxp_ec_hwmon_is_visible(const void *drvdata,
> >>> + enum hwmon_sensor_types type, u32 attr, int channel)
> >>> +{
> >>> + switch (type) {
> >>> + case hwmon_fan:
> >>> + return S_IRUGO;
> >>> + case hwmon_pwm:
> >>> + return S_IRUGO | S_IWUSR;
> >>
> >> Please use 0444 and 0644 directly. Checkpatch will tell.
> >
> > Oh. I did as the documentation suggested. I must confess I didn't run
> > checkpatch, will don in the next submission.
> >
>
> That is long ago. Octal values are and have been preferred for
> several years.
I've read this form here[1]. Should I send a patch to the
Documentation to reflect the preference?
[1]https://www.kernel.org/doc/html/latest/hwmon/hwmon-kernel-api.html#driver-callback-functions
next prev parent reply other threads:[~2022-10-31 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 22:50 [PATCH] Add OneXPlayer mini AMD board driver Joaquín Ignacio Aramendía
2022-10-29 23:30 ` Guenter Roeck
2022-10-30 0:29 ` Joaquin Aramendia
2022-10-30 3:24 ` Guenter Roeck
2022-10-30 20:32 ` [PATCH v2] Add OneXPlayer mini AMD sensors driver Joaquín Ignacio Aramendía
2022-10-31 0:03 ` Barnabás Pőcze
2022-10-31 14:49 ` Joaquin Aramendia
2022-10-31 14:53 ` [PATCH v3] " Joaquín Ignacio Aramendía
2022-10-31 15:34 ` Guenter Roeck
2022-10-31 15:57 ` Joaquin Aramendia
2022-10-31 16:43 ` Limonciello, Mario
2022-10-31 18:57 ` Joaquin Aramendia
2022-10-31 19:21 ` Limonciello, Mario
2022-10-31 19:33 ` Joaquin Aramendia
2022-10-31 19:56 ` Guenter Roeck
2022-10-31 20:53 ` Joaquin Aramendia
2022-10-31 21:30 ` Guenter Roeck
2022-10-31 11:45 ` Joaquin Aramendia [this message]
2022-10-31 13:07 ` [PATCH] Add OneXPlayer mini AMD board driver Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgtM3g9_-hpDfdb=kDqOerQAj+kn3pEbOcvmG_Lve3ETAXFfA@mail.gmail.com' \
--to=samsagax@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).