From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB36EB64DD for ; Thu, 20 Jul 2023 07:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbjGTHvq (ORCPT ); Thu, 20 Jul 2023 03:51:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbjGTHvo (ORCPT ); Thu, 20 Jul 2023 03:51:44 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A917026BB for ; Thu, 20 Jul 2023 00:51:20 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-262d33fa37cso226035a91.3 for ; Thu, 20 Jul 2023 00:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1689839480; x=1692431480; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2k4jDd0ZIOszcSg+J/IXQt6qEPXRORw1/6EUeNiGUWU=; b=adv0UXSqiTsvAO3sMOno0Si9w9X3YSPmSgrglWHPTYqrvzIwodST3g5VcZ9KKoNhkB 2w/3WP1ZMvfzR2nzxvxgaFCWiWArPiLjT8ARrjCQZ6BgRb655IbH7VVyaY5oLM/dCCF9 Q88JAaK7+r7cImjLxtmoDOP1H1xvx9n8i3YJYw6mL848fNQ//n+ENWg9iB/xscZDDxq5 qOKcTOUB9hqpHJRqvNYYi7IWfpjuDmGh4YLkdKXthL67Ll4HsrPAIpADm6EXOfLEYKEF baVUe64rkOVkCvadahpYmDv8I86xIy2fA7ebNBb8++DVz5G6wrBvt7uwdZMvkFXRllY4 qF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689839480; x=1692431480; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2k4jDd0ZIOszcSg+J/IXQt6qEPXRORw1/6EUeNiGUWU=; b=YnxbPPh5PQ2QCCpnSw/fKqpm6zQULpEsBJPc3scpfBrdruN9UBaDtZqE+6W+Y7qUvP ohoJ5Cf8OjgjPN5vMvE1kEelsG8DC5PW6KEatxz7Bwhej02EwFh39maNcCWcDm5yMfd0 Xi3MnzMosBqrGvdMctLdLturc0MhWe+vVlAh2ELXT2v7gg4Gjc7OOpkWQqQ9b+CZUiQ0 sTDwsWsouwccoxl/rQHBfAeeS1KKHRqpZ4hXKUCIjZyw6+7Xsa9Kl08mJBkP7rCk6c1I TsU0tRkKrbnrxgWxbHdoMPhzRqJGBH0OZtBUGK4s5GrZhTt2YB6DQiKy5XpCgFkK5d8a sfQw== X-Gm-Message-State: ABy/qLbD9cg+w0EpO1sGQ6zBWlAL5pfUtccs7wxqLSJ6UKlg5erqwkKm X9hAljN7puFyBbZQhwUxdvy4TJG/+hTDdgds+8e6Og== X-Google-Smtp-Source: APBJJlHy3Qp+lYj9Pw4twQ1use0NxR3mKM4+QvJjBaFFSzzalPR4jcXJVKn45xO97mV59mJlaUq4TiltAI5vPLOKHbg= X-Received: by 2002:a17:90a:ad94:b0:263:528:144a with SMTP id s20-20020a17090aad9400b002630528144amr1269938pjq.28.1689839480180; Thu, 20 Jul 2023 00:51:20 -0700 (PDT) MIME-Version: 1.0 References: <20230420111759.2687001-1-Naresh.Solanki@9elements.com> <76e57634-75dd-01e8-9c56-36ed7de17812@linaro.org> <88f9a008-2861-284c-76c4-7d416c107fbb@9elements.com> <20eb1d0e-0aa2-9d41-7ba5-2feb148748d0@linaro.org> <9d989c4c-7c9e-9e95-133f-03741d07198b@9elements.com> <80b60de0-dcb5-303f-8d13-f4b1cf7d8521@linaro.org> <45236017-22d2-f9f8-0069-77195e49221d@9elements.com> <3a912cab-001f-a70b-394d-71370fc482e5@roeck-us.net> In-Reply-To: <3a912cab-001f-a70b-394d-71370fc482e5@roeck-us.net> From: Naresh Solanki Date: Thu, 20 Jul 2023 13:21:09 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add max6639 To: Guenter Roeck Cc: Krzysztof Kozlowski , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Marcello Sylvester Bauer , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi Guenter, On Wed, 19 Jul 2023 at 23:10, Guenter Roeck wrote: > > On 5/4/23 04:36, Naresh Solanki wrote: > > Hi Krzysztof, > > > [ ... ] > >> > >> No, we cannot, because we asked you to fix things there. Your entire > >> explanation about compatible and driver is not related to the comment > >> you received: bindings should be complete. You argue that bindings do > >> not have to be complete, because of something with driver. This is not > >> related. Bindings are not for driver. > > > > I understand that complete bindings are important, but as the driver is already merged and functional, my immediate goal is to enable its use on my machine. I will work on a separate patch to include the interrupts in both binding & driver. > > > > As a follow-up, since it came up in a separate context: > > Bindings and driver are independent of each other. _Bindings_ > are supposed to be complete. However, the existence of a property > in the bindings description does not have to be reflected in > the driver. > > FWIW, you _could_ have added the device to the list of trivial > devices. The only really mandatory property is vdd, and every > chip has that. All other properties are really about configuration > and/or fan properties, and I don't even know how to describe fan > properties (such as pulses per revolution, pwm parameters, > fan speed limits, the relationship between pwm outputs > and fan inputs, the relationship between fan speed input > and pwm output, or fan spin-up requirements) in devicetree. Thanks for the inputs, Will work on it & keep you posted. Regards, Naresh > > Guenter >