From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 859E1C432C0 for ; Tue, 26 Nov 2019 14:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5952C2075C for ; Tue, 26 Nov 2019 14:34:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LOhTfDCb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbfKZOev (ORCPT ); Tue, 26 Nov 2019 09:34:51 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38753 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfKZOev (ORCPT ); Tue, 26 Nov 2019 09:34:51 -0500 Received: by mail-lj1-f194.google.com with SMTP id k8so9949183ljh.5; Tue, 26 Nov 2019 06:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=o6Aof0yAWGeShjgJcUg1Y0lQGsYW6In2/ZZmFux/330=; b=LOhTfDCbXM8wo5cGG2LnHtN506MEG78VOZmbVbs05lxPZSuAEdB7bxPlo15f6tqb4J IYVlqXY0WPPU7xgoWiSMgFW+r6o0s0fpbuPMeI2eRUAhpwplaU3GJUz2meBOFt6AbqOP pUEsHlqK6njDTIyJ5bjf6xX3TUT9ZndPzz6JZZ94Nf+MsSO6gLGwDwfhWN7Ol6SspLIy TuCdLhNq5q7zXHVbBRz7Qs4gaN/3dwUt9vkZhjHEFUWHGRtGyaKDxDoL2CGF4u882hLI bhD+YCUgZFqAr21busgL++mfQmz2mVg6dhyYgCzsz2ryvknKULP0XxUaNj8Lbt7QajAq JwZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o6Aof0yAWGeShjgJcUg1Y0lQGsYW6In2/ZZmFux/330=; b=phmCViNZtg55XGt79D601g4TcrN+SgpL++5wM6bXYMVtkXF3UL3+RVZjKzZXGzaoxy /mfRyKfBUpft2KPGAjfnfdSTJXImOGO9cN8XWu+U6BgJrtr9F55u4Ma22MciRhQr0Ihd kLfU4Do4HcGO8wrA/vjpsUIDNBmDKEP02yFitjq1a3SmTRw5+JVE8gFZBfXyPGaJrqFh le2y5thuCgw+eOt+Wjc7RnLcVzHJy8ZpFj3LlH1y+0oOLS+x5MI72p8hVBc8d9GVkjgh TnTsa25RP+JgOIFB38+AY9xeGD/ngHkpmWLnDoaWtfMkoruMN+XnpE5iQ9+Yhlo/7Lv1 Tykw== X-Gm-Message-State: APjAAAVdrcEMUCnZcZgXEORM9JefcdVcJl96ce8AIUNBFm+N2qHvREyU icDYMObVXEsmekBlemsBrWqf5yKuYPGOcQ2x+OII7qLKWF0= X-Google-Smtp-Source: APXvYqxom9w1r9meKO7BwtGxZ8J84olw1mlQR/g2adENixyRp0DFx+OrWkHvlSUo6GpFwxHjIqzoDQ7OSEXi60qRUaA= X-Received: by 2002:a05:651c:20f:: with SMTP id y15mr26375869ljn.31.1574778889212; Tue, 26 Nov 2019 06:34:49 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-5-git-send-email-akinobu.mita@gmail.com> In-Reply-To: From: Akinobu Mita Date: Tue, 26 Nov 2019 23:34:36 +0900 Message-ID: Subject: Re: [PATCH 4/8] platform/x86: intel_menlow: switch to use helpers To: Andy Shevchenko Cc: Linux NVMe Mailinglist , linux-hwmon@vger.kernel.org, Linux PM , Linux Kernel Mailing List , Sujith Thomas , Darren Hart , Andy Shevchenko , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Jean Delvare , Guenter Roeck , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org 2019=E5=B9=B411=E6=9C=8826=E6=97=A5(=E7=81=AB) 4:07 Andy Shevchenko : > > On Mon, Nov 25, 2019 at 4:35 PM Akinobu Mita wro= te: > > 2019=E5=B9=B411=E6=9C=8825=E6=97=A5(=E6=9C=88) 4:58 Andy Shevchenko : > > > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita = wrote: > > > > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO= _CELSIUS(value)); > > > > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value)); > > > > > > Can you explain the change %lu to %ld? > > > > Isn't it possible for aux values to be lower than 0 degrees Celsius? > > If it's a change due to requirement of new helpers, put it in the > commit message, otherwise leave as is. OK, I'll leave it as is. The format string will be fixed by a separate patch.