From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CD6C432C0 for ; Mon, 25 Nov 2019 14:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C05D207FD for ; Mon, 25 Nov 2019 14:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BwfnTrBZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbfKYOkF (ORCPT ); Mon, 25 Nov 2019 09:40:05 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40348 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728071AbfKYOkF (ORCPT ); Mon, 25 Nov 2019 09:40:05 -0500 Received: by mail-lj1-f195.google.com with SMTP id q2so16173491ljg.7; Mon, 25 Nov 2019 06:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/SvzLSQc9NaZmiRAfhKzbEgi5swALfQM0gwLxj/g1X4=; b=BwfnTrBZIsf+YbKNO1Y09SKRcT/7JpfVe5u9XdIKMFF3vFkXXD09OebLH+/j2ARwh9 1UBsASBFYnpZ7Ar6c/L8nHzM0Xfqfs422qdX0ctAKCgI6tI/rKPsjOKVatdVdp8kqJP0 K3cRMjzd/SmBmsAq/X8a8B/4z7CUO2aS6k+gls6PZjaQOfdq4KqNXHSE3FkX38mEg01z xprQHlhqwXFTWSyAKCm1HSJpb3EthA5hG11JB+PnE5YIRJvNkr163ZR++uBnx499Zz+X lIMoKPo3k+/c+gF2+Elw+iJ7EBFbVxZkYH1Ca8nAVKdb35aAptffJ4OLimFdUFjeWn41 A8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/SvzLSQc9NaZmiRAfhKzbEgi5swALfQM0gwLxj/g1X4=; b=pIDmWiJrkdO3p/xLyAS7qYy/rZOWJCX/JiugpyqDUWZae+ZKXX/KRd5d3+OI4rMDpb Y7FVM5zdU+KOeoLlfxzb78qhKag1BLx1bKnYhQIm8WExVNVXxwU2/JJO7zHtYsYG5agg ca59TkT8ZKCWfj3t++rgygh13ohi2hMLyizEy4ucdpReZI/h61yox7byaaVRYGRLbEO/ JvTY9ddyiTXioHZFsPPgNa6zQsk74S9goEcD0n+53I35rZc5PPcAZXFBNqZVRGSvwTjY gGNPyNd+FHRNbPNN3pPH6zXM8s7PPm7VhLC0XAE8qfDgicyDq2iKcFWSRf3hKC9iw+3Z CKYA== X-Gm-Message-State: APjAAAXNJkAFk+PPG0zBV6cJDv4egSvgHYLQ0zkr3UxqekbBOUoIMyEt zLB9+LEIourS40gxcdNnu1Uo5guscGjkMoNkyQ8= X-Google-Smtp-Source: APXvYqxnV6QXzPFLNYYbJkreFA5LHHLQRoa+mUvd3RVfemUmE7NzO9TeNGK9jW4ohjEjbkzC5MK9lxV+ELGJbAuF4NI= X-Received: by 2002:a2e:9842:: with SMTP id e2mr22522578ljj.93.1574692801789; Mon, 25 Nov 2019 06:40:01 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-9-git-send-email-akinobu.mita@gmail.com> In-Reply-To: From: Akinobu Mita Date: Mon, 25 Nov 2019 23:39:50 +0900 Message-ID: Subject: Re: [PATCH 8/8] thermal: remove kelvin to/from Celsius conversion helpers from To: Andy Shevchenko Cc: Linux NVMe Mailinglist , linux-hwmon@vger.kernel.org, Linux PM , Linux Kernel Mailing List , Sujith Thomas , Darren Hart , Andy Shevchenko , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Jean Delvare , Guenter Roeck , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org 2019=E5=B9=B411=E6=9C=8825=E6=97=A5(=E6=9C=88) 5:00 Andy Shevchenko : > > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita wro= te: > > > > This removes the kelvin to/from Celsius conversion helpers in > > which were switched to helpers. > > > > > DECI_KELVIN_TO_MILLICELSIUS_WITH_OFFSET() is only used by ACPI thermal > > zone driver and the usage is specific to the driver. So this macro > > is moved to the ACPI thermal driver rather than generic header. > > I didn't get this point. If we split all helpers, let's do it for all, > and not spreading macro per driver. OK, I'll add deci_kelvin_to_millicelsius_with_offset() in the header. But the unit of 'offset' argument will be in millidegree instead of decidegree, because it's a bit more generic.