From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E049C2BB85 for ; Thu, 16 Apr 2020 08:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BB6121707 for ; Thu, 16 Apr 2020 08:36:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fYkiVyjy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441324AbgDPIfi (ORCPT ); Thu, 16 Apr 2020 04:35:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502324AbgDPIeu (ORCPT ); Thu, 16 Apr 2020 04:34:50 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1AE0C03C1AC for ; Thu, 16 Apr 2020 01:34:35 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id v9so6821009ljk.12 for ; Thu, 16 Apr 2020 01:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MyKtvenZZySMWZjgRLJbDJOPHGIrfVrSPfr0WfI/VtA=; b=fYkiVyjy7eOsJYWlAiTayzWjGkE+e1mUldI0Bx/CxoO/uRzO5h5zkKeWvLWyT4wIVq y4Um/zqK1i/EUxtP/cB7m2yiCfOAVbucsbSvm9uAIBdUy5w/NyEgZas2SerPH26kjihk NJ5qrlR6KCeUheLOqsfKpP2vrUVQYBdC/lh6Iy4lvDXzlo9F10OICHSA8GRZxV9vIwgG g+fgaQUuLBOTvaOt4crwBP5OOZe7ophOecfwpbiaskT4jEC1w1TFXKcnvnYX+N2JBeWE dUyc5WtmVr5a+KeD8IdGTWSudzyYEY/vdzcMmFi1Gbr8mYPVC1ncjFXy4g01wQx0gT9E vWBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MyKtvenZZySMWZjgRLJbDJOPHGIrfVrSPfr0WfI/VtA=; b=gL/zst5eIaevVDAlspcm/UDbfxWA4AVyWrgj18eXOV2yvFtKnf5ayNT7fZ5vhna1lH QHisqUjCYz6HzCCIqNKuU9Wt/eiajrI/oWuUGBGWBIsz0rXpD5Bguizs4TBOlW3/IfhI pSGsxkabVdQ/sTJwbpaNsyx/ceOc5NWa2hUd8qUF5Uba8rbVuIqu+sfnfAzBKYWfOt9K UyNmbdmOI3u+hGkKArM4fwcVBVkTpC/WYJlKX0BKMWoQPC0h24Z1aC0yzWvaI+ak0GRX Eqc2V7PY2fle3X4T3ZOzRHvjwjPcibjtrNUwcMoUIqpS3djpipfePlPSeuSZHdwHPlEe T1cQ== X-Gm-Message-State: AGi0Pubp8y/tqx1PDR2+84bgn0pdNh/fy26c7gu64Bvm/VwwYUqtLviV YLBU0w/XuRax11bnCDtVPRm4uh8VYqQGrH5hZbivYw== X-Google-Smtp-Source: APiQypKpg4Qo0k4IoZG1lD0aQ14OtbNSt7M01nnNL2FnfHvo9Iw7EPQxYDZAVptV9fOJpu5zJ470WV5Vz4uxzy+rmRs= X-Received: by 2002:a2e:8805:: with SMTP id x5mr2229929ljh.223.1587026074289; Thu, 16 Apr 2020 01:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20200402203656.27047-1-michael@walle.cc> <20200402203656.27047-12-michael@walle.cc> In-Reply-To: <20200402203656.27047-12-michael@walle.cc> From: Linus Walleij Date: Thu, 16 Apr 2020 10:34:23 +0200 Message-ID: Subject: Re: [PATCH v2 11/16] gpio: add support for the sl28cpld GPIO controller To: Michael Walle Cc: "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , Linux ARM , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi Michael, this is looking good provided we can get the generic GPIO regmap helper reviewed and merged. Thanks! On Thu, Apr 2, 2020 at 10:37 PM Michael Walle wrote: > This adds support for the GPIO controller of the sl28 board management > controller. This driver is part of a multi-function device. > > Signed-off-by: Michael Walle > + depends on MFD_SL28CPLD Apart from this depends it seems the patch is compile-time independent of the other patches so I'd suggest we just merge the generic regmap driver and this driver to the GPIO tree once we feel finished with them, optimistically assuming that the MFD driver will land and that we will not need any fundamental changes in the GPIO driver. Worst case we have to revert the driver and that is no disaster. Yours, Linus Walleij