From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B451AC4332F for ; Thu, 15 Dec 2022 14:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbiLOOhn (ORCPT ); Thu, 15 Dec 2022 09:37:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiLOOhl (ORCPT ); Thu, 15 Dec 2022 09:37:41 -0500 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A12332E68B for ; Thu, 15 Dec 2022 06:37:39 -0800 (PST) Received: by mail-vs1-xe33.google.com with SMTP id b189so3068078vsc.10 for ; Thu, 15 Dec 2022 06:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sZ15fTarDAUKgAtZxdlUAO/HtntI26TxSHF6pnz8lQo=; b=b9m1V265SGOkN31jd68sNj+j5fmo5HDI+hw3nbQZr1R02Ahnwd9JQdo99xOhAZtO9I 0hodzAQ+KIq24tKSKp8dOEpnJl/ZfJHlQVn5RM1tK/+HD1hrVRL4IaCiRNqr3VL+js7a DG2v+3rv0oUiGi9LG/qrtBOfcxTeI+Pxd1K3chrFP8UYwofZ6oKKhiKVXCKiS7O8IIqC GYcRmSIzM3JwDuQ+Mr55E7Tyrw28ygVpZrLxwdgsp0FCMvT68PEsABwo8xu148SfEPYI w+vpNSPqRcpzg2URKvCVsxQBr8tQxfzdaNEIgY8NBrWBirkfwcgU99kWSPcuzcqCA5ql uGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZ15fTarDAUKgAtZxdlUAO/HtntI26TxSHF6pnz8lQo=; b=QOwAdEysVyKfb+suXLo4HvzEbgitL2wzP7YZ0W8fYGbiuEYJCjriUGtrMKxe09HUDI kxiBry1SNzIthO5mq1g1RRolXnK67i42yK+zPQN70QQGo3Mrv872Cirl3pZgSAXarPqb woWwP8D3J4ZveinGAuQbELnArM5che+8TkBp9oVBMLuc8iTyR7tSTmmw1ZK7W7ex672l KXIl9kdl6Pd3G7CbdPLZrTuE9sDtE0kCCQM3X57Y/L0CptiDLOa7ZWCMtLRMQJhACyu8 Yz/j+PYrkR+g6ySwLt7Ua8dU+Aq9FTyUC0S91vD8CeaZMRWwMqAhxKJNO0tM+wp0eqkR XGSQ== X-Gm-Message-State: ANoB5pmvbG0bx08Gk5OWG7NDsAxFYcvfC56oOq5TrTaKYYzImdONWCZg 2Be2BgI7SsJzK+Mq6dnAf+BxXpC3ujdKv5W7BMKwsg== X-Google-Smtp-Source: AA0mqf4nXgavNXLmZisRGiafHkFikYttYt9CxLXkNHxbTBrRiHz8Qy0Px6pMKI3J0W1a1HDTxVJfB67KwVQbcKjnqTc= X-Received: by 2002:a05:6102:30b4:b0:3b3:10b1:8e64 with SMTP id y20-20020a05610230b400b003b310b18e64mr4089245vsd.42.1671115058703; Thu, 15 Dec 2022 06:37:38 -0800 (PST) MIME-Version: 1.0 References: <20221214220727.1350784-1-jcormier@criticallink.com> <20221214220727.1350784-2-jcormier@criticallink.com> <29f4e14f-a81a-d440-b564-5360f44c65c1@linaro.org> In-Reply-To: From: Jon Cormier Date: Thu, 15 Dec 2022 09:37:27 -0500 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: hwmon: adi,ltc2945: Add binding To: Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, Jean Delvare , Guenter Roeck , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Bob Duke , John Pruitt Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Resending reply in plain text On Thu, Dec 15, 2022 at 9:35 AM Jon Cormier wrote: > > On Thu, Dec 15, 2022 at 4:42 AM Krzysztof Kozlowski wrote: >> >> On 14/12/2022 23:07, Cormier, Jonathan wrote: >> >> Missing commit msg. Describe hardware. > > Thanks >> >> >> >> >> > Signed-off-by: "Cormier, Jonathan" >> > --- >> > .../bindings/hwmon/adi,ltc2945.yaml | 50 +++++++++++++++++++ >> > 1 file changed, 50 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml >> > >> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml >> > new file mode 100644 >> > index 000000000000..9ca7a886dec8 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml >> > @@ -0,0 +1,50 @@ >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: Analog Devices LTC2945 wide range i2c power monitor >> > + >> > +maintainers: >> > + - Guenter Roeck >> > + >> > +description: | >> > + Analog Devices LTC2945 wide range i2c power monitor over I2C. >> > + >> > + https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf >> > + >> > +properties: >> > + compatible: >> > + enum: >> > + - ltc2945 >> >> That's not a correct compatible. Missing vendor prefix. >> > Okay, I assume I'll need to update the driver as well to handle that. >> >> > + >> > + reg: >> > + maxItems: 1 >> > + >> > + shunt-resistor-micro-ohms: >> > + description: >> > + Shunt resistor value in micro-Ohms >> > + default: 1000 >> > + >> > +required: >> > + - compatible >> > + - reg >> > + >> > + >> >> Just one blank line. >> >> > +additionalProperties: false >> > + >> > +examples: >> > + - | >> > + i2c { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> >> Use 4 spaces for example indentation. >> >> > + >> > + ltc2945_i2c: ltc2945@6e { >> >> Node names should be generic. >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> >> > + compatible = "ltc2945"; >> > + reg = <0x6e>; >> > + /* 10 milli-Ohm shunt resistor */ >> > + shunt-resistor-micro-ohms = <10000>; >> > + }; >> > + }; >> > +... >> >> Best regards, >> Krzysztof >> > > > -- > Jonathan Cormier > Software Engineer > > Voice: 315.425.4045 x222 > > > > http://www.CriticalLink.com > 6712 Brooklawn Parkway, Syracuse, NY 13211 > > -- Jonathan Cormier Software Engineer Voice: 315.425.4045 x222 http://www.CriticalLink.com 6712 Brooklawn Parkway, Syracuse, NY 13211