From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Naveen Krishna Chatradhi <nchatrad@amd.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: amd_energy: match for supported models
Date: Tue, 7 Jul 2020 11:54:33 +0530 [thread overview]
Message-ID: <CAHfPSqAjTr1Tj9a8VxppUfgO7k5aL-EbiPEQsVpSp=yMYKQd+A@mail.gmail.com> (raw)
In-Reply-To: <5eae0fda-53cf-47d5-c857-c30bbb924ccb@roeck-us.net>
Hi Guenter
On Tue, 7 Jul 2020 at 09:25, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 7/6/20 10:20 AM, Naveen Krishna Ch wrote:
> > Hi Guenter,
> >
> > On Mon, 6 Jul 2020 at 22:47, Naveen Krishna Chatradhi <nchatrad@amd.com> wrote:
> >>
> >> The energy counters of certain models seems to be reporting
> >> inconsisten values. Hence, match for the supported models.
> > Actually, the supported models could be of family 0x17 in a range
> > between 0x30 ~ 0x3f. I did not find any macro or usage for a range
> > of models. Could you suggest to me if i've missed an existing way to
> > provide a range for models.
> >
> So, do you want me to apply the patch as-is, or are you going to send an
> updated version ?
Please take this patch as-is, i will update the supported models when ever
i get a chance to test on them.
>
> Thanks,
> Guenter
>
> >>
> >> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> >> ---
> >> drivers/hwmon/amd_energy.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/hwmon/amd_energy.c b/drivers/hwmon/amd_energy.c
> >> index e95b7426106e..29603742c858 100644
> >> --- a/drivers/hwmon/amd_energy.c
> >> +++ b/drivers/hwmon/amd_energy.c
> >> @@ -362,7 +362,7 @@ static struct platform_driver amd_energy_driver = {
> >> static struct platform_device *amd_energy_platdev;
> >>
> >> static const struct x86_cpu_id cpu_ids[] __initconst = {
> >> - X86_MATCH_VENDOR_FAM(AMD, 0x17, NULL),
> >> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x17, 0x31, NULL),
> >> {}
> >> };
> >> MODULE_DEVICE_TABLE(x86cpu, cpu_ids);
> >> --
> >> 2.17.1
> >>
> >
> >
>
--
Shine bright,
(: Nav :)
next prev parent reply other threads:[~2020-07-07 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 17:17 [PATCH] hwmon: amd_energy: match for supported models Naveen Krishna Chatradhi
2020-07-06 17:20 ` Naveen Krishna Ch
2020-07-06 21:54 ` Guenter Roeck
2020-07-07 3:55 ` Guenter Roeck
2020-07-07 6:24 ` Naveen Krishna Ch [this message]
2020-07-07 14:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHfPSqAjTr1Tj9a8VxppUfgO7k5aL-EbiPEQsVpSp=yMYKQd+A@mail.gmail.com' \
--to=naveenkrishna.ch@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nchatrad@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).