From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6170C432C0 for ; Sun, 24 Nov 2019 19:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B23EC207FD for ; Sun, 24 Nov 2019 19:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N9k+kyqV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726937AbfKXTyi (ORCPT ); Sun, 24 Nov 2019 14:54:38 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:36942 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbfKXTyi (ORCPT ); Sun, 24 Nov 2019 14:54:38 -0500 Received: by mail-pg1-f196.google.com with SMTP id b10so5969681pgd.4; Sun, 24 Nov 2019 11:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xgxN+slUElCQpDuU8fsY3BZMJxer4zKWxWFoQzMGtA4=; b=N9k+kyqVqvVAuU5pmVcD05y0P7ep7fkeAyzpfnA8hS2146dGHNMBjSFR9uiJV8PHu0 9aJTs33ZWmukHbhGxkM9JoSH+maOgpdQdyDSpGppnHZX79oYQ1DMEBvvya80yKdDrCRn UAhC+xeK8nbxYIHlDlIctzaYwHAhcTTcuw140chiI8mR8MQJetOiFzuSlX+qXYuNjuPC ALXFb25TaINXA4BSo6hqgC/27e33SJxaQdfegL7mzSgjFC+vMNyCowgMcV3yJvVEhnK/ XomI1mA4ZMdgY4R282CGbCovH0hL0rqqQ49vvktIoDg5pRbcoXH8+heiUYIo3ezzqGn8 h4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xgxN+slUElCQpDuU8fsY3BZMJxer4zKWxWFoQzMGtA4=; b=IhwXRKubOganLFxgcRgjm6iIMRqHslwtRSlBMIdKPCphg8ZBt83RYS7tySIfi99QkL KXW6z+79ICJyEV0hllHhe/4PFPISJh1K9Ccboy/NYO7MaCLV+HubkDdK1J+cTExCcJfo YsyhEtPJIEP9MxgSHtYyeQP9wbIc4t93O+heiTWUycUrFoIlmX0G2h2hvCoRz6BGYfRL knpW/IhjUrRGBNKCNyRoRknnGPhg/YJ4J2DpcoFJUqkD/krJGrEmevK8ggW8aP+qxuC2 DauNkxCeeikw801tve/WEEc6fFPFUH8b9U+322Bn3uXM8fCcUwuK0NzV/eqr/ZEHs58M I3xg== X-Gm-Message-State: APjAAAWusOhB2ONbj02EtfKuklYtSDk2kCpm+LEhKmusvflmXtFATqm4 A04VjrhfHe1KZ1rY2Vp0BzWCuwLPFyA9kAM4Szs= X-Google-Smtp-Source: APXvYqynJhSAT+cBLFOG35mXdSu5donpoINx1X4oii7KCRStNIR2N5Cf8Hh5JzERBkyy6grUixES2mbAfr5mZU7d3zM= X-Received: by 2002:a62:168f:: with SMTP id 137mr31383941pfw.151.1574625277865; Sun, 24 Nov 2019 11:54:37 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Sun, 24 Nov 2019 21:54:26 +0200 Message-ID: Subject: Re: [PATCH 3/8] platform/x86: asus-wmi: switch to use helpers To: Akinobu Mita Cc: Linux NVMe Mailinglist , linux-hwmon@vger.kernel.org, Linux PM , Linux Kernel Mailing List , Sujith Thomas , Darren Hart , Andy Shevchenko , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Jean Delvare , Guenter Roeck , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita wrote: > > The asus-wmi driver doesn't implement the thermal device functionality > directly, so including just for DECI_KELVIN_TO_CELSIUS() > is a bit odd. > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > . > > Cc: Sujith Thomas > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Signed-off-by: Akinobu Mita > --- > drivers/platform/x86/asus-wmi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 821b08e..6a1a2f9 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -33,7 +33,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > @@ -1512,9 +1512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev, > if (err < 0) > return err; > > - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000; > - > - return sprintf(buf, "%d\n", value); > + return sprintf(buf, "%ld\n", > + deci_kelvin_to_millicelsius(value & 0xFFFF)); Leave it in one line. With above, Acked-by: Andy Shevchenko > } > > /* Fan1 */ > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko