From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: proximity: vcnl3020: add threshold options
Date: Sat, 1 May 2021 21:51:15 +0300 [thread overview]
Message-ID: <CAHp75VeRpEgpFe2J0epjJQsBS346B+vDJ+74fFumFCN2Sy6FCA@mail.gmail.com> (raw)
In-Reply-To: <20210430152419.261757-3-i.mikhaylov@yadro.com>
On Fri, Apr 30, 2021 at 6:16 PM Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
>
> Add the low/high threshold options.
...
> + rc = regmap_bulk_read(data->regmap, VCNL_PS_HI_THR_HI,
> + &res, 2);
sizeof(res)
> + *val = be16_to_cpu(res);
So, the rule of thumb is not putting anything to the output, until you
know that there is no error.
> + if (rc < 0)
> + return rc;
...
> + rc = regmap_bulk_read(data->regmap, VCNL_PS_LO_THR_HI,
> + &res, 2);
> + *val = be16_to_cpu(res);
> + if (rc < 0)
> + return rc;
As per above.
...
> + rc = regmap_bulk_write(data->regmap, VCNL_PS_HI_THR_HI,
> + &buf, 2);
sizeof(buf) ?
...
> + rc = regmap_bulk_write(data->regmap, VCNL_PS_LO_THR_HI,
> + &buf, 2);
Ditto.
...
> +end:
out_release_direct_mode:
> + iio_device_release_direct_mode(indio_dev);
> + return rc;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-01 18:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 15:24 [PATCH 0/4] add periodic mode, threshold options and hwmon Ivan Mikhaylov
2021-04-30 15:24 ` [PATCH 1/4] iio: proximity: vcnl3020: add periodic mode Ivan Mikhaylov
2021-05-01 18:48 ` Andy Shevchenko
2021-05-02 18:00 ` Jonathan Cameron
2021-05-04 19:07 ` Ivan Mikhaylov
2021-05-05 8:22 ` Jonathan Cameron
2021-04-30 15:24 ` [PATCH 2/4] iio: proximity: vcnl3020: add threshold options Ivan Mikhaylov
2021-05-01 18:51 ` Andy Shevchenko [this message]
2021-04-30 15:24 ` [PATCH 3/4] iio: proximity: vncl3020: remove mutex from vcnl3020_data Ivan Mikhaylov
2021-05-01 18:53 ` Andy Shevchenko
2021-05-02 17:53 ` Jonathan Cameron
2021-04-30 15:24 ` [PATCH 4/4] hwmon: vcnl3020: add hwmon driver for intrusion sensor Ivan Mikhaylov
2021-04-30 16:38 ` Guenter Roeck
2021-05-04 19:46 ` Ivan Mikhaylov
2021-05-05 8:26 ` Jonathan Cameron
2021-05-05 14:02 ` Guenter Roeck
2021-05-17 17:08 ` Ivan Mikhaylov
2021-05-01 7:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeRpEgpFe2J0epjJQsBS346B+vDJ+74fFumFCN2Sy6FCA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=i.mikhaylov@yadro.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).