From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DDCC4338F for ; Mon, 23 Aug 2021 21:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F4EE613A8 for ; Mon, 23 Aug 2021 21:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232745AbhHWVNS (ORCPT ); Mon, 23 Aug 2021 17:13:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:42014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232712AbhHWVNS (ORCPT ); Mon, 23 Aug 2021 17:13:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE918613A8; Mon, 23 Aug 2021 21:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629753154; bh=FO5V+VvVNyFCl7iIUHP7YYXHV+zjbkZDH/GJy0SP/MY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QxKdriVB0R+F8JZKpRqrmIRvpaNmLjZ6pns3DFxGf+1MivtWY3/95+gGIGAik068D ekiRbdeWC5O6yV4R7cSwK9KJeeef+g9179ktK63zOfRGo8663N4HRCwt5nPKtF+h01 QiPVjPebnfMiWXxdZnL8cmDdkMVxr08GJrV85u0JRLZZ4+CsIUnKqHj3aTtOJIThGs pPV2UTbiTH3avy+F5lJC5X9dl9v7rfxP74HO+FS5sYAMGkNq832lmz9M1/0WsPKBnY 8igt/ggGhSS0XSJguLQx0jFiO+y2sGfYVkrZJIWA6NmrAUwy4QbccOmh/qauZIzvUk M5a1AwL4YhAHg== Received: by mail-ej1-f49.google.com with SMTP id x11so39882227ejv.0; Mon, 23 Aug 2021 14:12:34 -0700 (PDT) X-Gm-Message-State: AOAM530gqtdaLsD9j4kFm5yJTKBqrhgEpdcIYhgliP6gHLRdCijtkdf4 gTSMrDi1sG5G4HGm+Rx+WZYGc01ZHn2vBFfjFA== X-Google-Smtp-Source: ABdhPJyFFpTaNQ8lP7elawiHjryXjUyNIjLJbOKH1rXHXIM1ruMxr0K30c8RNAyuz0Af6ey+tZYmAW6/6Ul8sjBE9wU= X-Received: by 2002:a17:906:8cd:: with SMTP id o13mr37973428eje.341.1629753153543; Mon, 23 Aug 2021 14:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20210819182544.224121-1-krzysztof.kozlowski@canonical.com> <20210819182544.224121-2-krzysztof.kozlowski@canonical.com> In-Reply-To: From: Rob Herring Date: Mon, 23 Aug 2021 16:12:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices To: Guenter Roeck , Krzysztof Kozlowski Cc: Jean Delvare , Jiri Kosina , Linux HWMON List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck wrote: > > On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote: > > Ther Maxim max31785 bindings are trivial, so simply merge it into > > trivial-devices.yaml. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/hwmon/max31785.txt | 22 ------------------- > > Not sure if that is a good idea. It would make more sense to standardize the > properties needed by the driver/chip instead (see existing dts files in the kernel). This device is certainly not trivial, the binding is just incomplete. Device specific fan controller bindings are something I'm just going to reject until someone comes up with something common. Rob