From: Rob Herring <robh+dt@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Jean Delvare <jdelvare@suse.com>,
Jiri Kosina <trivial@kernel.org>,
Linux HWMON List <linux-hwmon@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices
Date: Mon, 23 Aug 2021 16:19:47 -0500 [thread overview]
Message-ID: <CAL_JsqKJgvK8g+zbzLCBxnKbgAioBcdHWNAvqe4Z9BzkNMwPpA@mail.gmail.com> (raw)
In-Reply-To: <441b28c9-a997-7143-825f-f272e399d60f@roeck-us.net>
On Fri, Aug 20, 2021 at 9:26 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max1619 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Do we have a general guideline on how to handle such trivial bindings ?
Not really. I debate (with myself) just getting rid of it as I suspect
lots of bindings are just incomplete. Like should supplies be
required? But it's convenient to have and not duplicate a bunch of
boilerplate.
> I normally leave it up to the driver author to decide one way or another.
Me too.
This one looks simple enough to be in trivial-devices, so I'll take
having a schema over not.
Rob
next prev parent reply other threads:[~2021-08-23 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 18:25 [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices Krzysztof Kozlowski
2021-08-19 18:25 ` [PATCH 2/2] dt-bindings: hwmon: merge max31785 " Krzysztof Kozlowski
2021-08-20 14:23 ` Guenter Roeck
2021-08-23 21:12 ` Rob Herring
2021-08-20 14:26 ` [PATCH 1/2] dt-bindings: hwmon: merge max1619 " Guenter Roeck
2021-08-23 21:19 ` Rob Herring [this message]
2021-08-31 15:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKJgvK8g+zbzLCBxnKbgAioBcdHWNAvqe4Z9BzkNMwPpA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).