From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Max Staudt <max@enpas.org>, Linux I2C <linux-i2c@vger.kernel.org>,
linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
"Linux/m68k" <linux-m68k@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH v3 2/3] hwmon/ltc2990: Generalise DT to fwnode support
Date: Fri, 16 Aug 2019 09:32:46 +0200 [thread overview]
Message-ID: <CAMuHMdUYpkkmhxwTu7MGm6NiMfYs9SqjLKRPazuSEjRgpRavyg@mail.gmail.com> (raw)
In-Reply-To: <20190815224341.GA12420@roeck-us.net>
On Fri, Aug 16, 2019 at 1:50 AM Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Aug 16, 2019 at 12:19:42AM +0200, Max Staudt wrote:
> > On 08/15/2019 02:58 PM, Max Staudt wrote:
> > > - if (of_node) {
> > > - ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
> > > - data->mode, 2);
> > > + if (i2c->dev.of_node || i2c->dev.fwnode) {
I was just going to comment on this check...
> > One more idea, would it be better here to do the following?
> >
> > if (device_property_present(i2c->dev, "lltc,meas-mode")) {
> > ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
> > data->mode, 2);
> > }
> >
> > I'm happy to prepare a patch if you wish to have this in - just let me know whether it should be on top of the last one, or instead of it.
>
> That would be semantically different. The property is currently mandatory.
> The above code would make it optional. This might work:
>
> if (dev_fwnode(&i2c->dev)) {
> ret = device_property_read_u32_array(...);
> ...
> }
Much better, thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-08-16 7:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:58 [PATCH v3 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-15 12:58 ` [PATCH v3 2/3] hwmon/ltc2990: Generalise DT to fwnode support Max Staudt
2019-08-15 18:33 ` Guenter Roeck
2019-08-15 21:34 ` Max Staudt
2019-08-15 22:19 ` Max Staudt
2019-08-15 22:43 ` Guenter Roeck
2019-08-16 7:32 ` Geert Uytterhoeven [this message]
2019-08-16 8:37 ` Max Staudt
2019-08-16 9:07 ` [PATCH] " Max Staudt
2019-08-16 11:07 ` Geert Uytterhoeven
2019-08-16 12:26 ` Max Staudt
2019-08-16 12:36 ` Geert Uytterhoeven
2019-08-16 12:43 ` Max Staudt
2019-08-16 13:24 ` Guenter Roeck
2019-08-15 12:58 ` [PATCH v3 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-16 11:51 ` Wolfram Sang
2019-08-16 12:34 ` Max Staudt
2019-08-16 16:09 ` Wolfram Sang
2019-08-19 11:22 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUYpkkmhxwTu7MGm6NiMfYs9SqjLKRPazuSEjRgpRavyg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=max@enpas.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).