From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13279C433FF for ; Tue, 13 Aug 2019 07:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3C8D20665 for ; Tue, 13 Aug 2019 07:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbfHMHEc (ORCPT ); Tue, 13 Aug 2019 03:04:32 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:45155 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfHMHEc (ORCPT ); Tue, 13 Aug 2019 03:04:32 -0400 Received: by mail-ot1-f66.google.com with SMTP id m24so15715816otp.12; Tue, 13 Aug 2019 00:04:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mXwGBjp9LMHuTvIC7Bhlt7IoJI+c7o2N7HzWrhbwkTg=; b=o8yMjMa4T0l0rC3q/fBv0oWHdIleApSVU/C2QREAHdmisaBIOZose3x+V5VhoKCX+g lTV+4nW7GL7NkJNrRGJ/LJxNVVFxxHBHGNuX2hSk16ysIijU2M0CmeTnmMGherpKUUil n347YZXF4p3xgHztt+3hDOJ2siBpe5X9Zpx+EyJx0WlJcUAM6uUxdMEvk2UNIyV9Ybj8 NJX/Q7m3VodI+mQxAt9JFMGbtiNdkWwYOb5DCAK4lsLJbKZTYmqi8B5UvBWFBJQLogq3 W7cac7YJTO8loEFlm0vC7m2Afwd6qn9/PLJMtREQU478ljlKpyNoLYi+WB4AHAPHAOVN C41w== X-Gm-Message-State: APjAAAXT0e+dJyE4Md5cv3/cbBn9RdWM6E+6sW3Xrf2Lj2C1KqKW/E3z 2GeOXucbqxnA/AdH4I/Z8zuzPTlpyeEXEJiiaHU= X-Google-Smtp-Source: APXvYqw0yC4CvPrV5JWobKvJRDIsvm1+Y4M3hpoRUEejLxDUS3HCwIjvAuVYG9ij1hRlzveIzL/9HaKCXD2guwuh9gs= X-Received: by 2002:aca:3bc6:: with SMTP id i189mr502087oia.153.1565679871091; Tue, 13 Aug 2019 00:04:31 -0700 (PDT) MIME-Version: 1.0 References: <20190812235237.21797-1-max@enpas.org> <20190812235237.21797-4-max@enpas.org> In-Reply-To: <20190812235237.21797-4-max@enpas.org> From: Geert Uytterhoeven Date: Tue, 13 Aug 2019 09:04:20 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990 To: Max Staudt Cc: Linux I2C , linux-hwmon@vger.kernel.org, Wolfram Sang , Jean Delvare , Guenter Roeck , "Linux/m68k" , Linux Kernel Mailing List , John Paul Adrian Glaubitz Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi Max, On Tue, Aug 13, 2019 at 1:54 AM Max Staudt wrote: > This enables the three additional inputs available on the 2019 a1k.org > reprint of the ICY board: > > in1 will be the voltage of the 5V rail, divided by 2. > in2 will be the voltage of the 12V rail, divided by 4. > temp3 will be measured using a PCB loop next the chip. > > Signed-off-by: Max Staudt Reviewed-by: Geert Uytterhoeven However, I would merge patches 2/4 and 4/4, and move the result after patch 3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds