From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D765C433EF for ; Tue, 21 Sep 2021 15:37:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5202160F44 for ; Tue, 21 Sep 2021 15:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233853AbhIUPil (ORCPT ); Tue, 21 Sep 2021 11:38:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:60794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233860AbhIUPik (ORCPT ); Tue, 21 Sep 2021 11:38:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6985660E08; Tue, 21 Sep 2021 15:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632238631; bh=1L59Qf8dZlUk3zyJnpg6Mrmzjp8u5lw/A8gCnR4hqtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aawSD7LvOO0CmvE94phTcMeCNI0F76yi1WFd7TKgEA+Fs58sGjRbMyS1f1lBmo2iV +bGV42SQqB+0dVvhHIsU6CkeWEoNKhtqcR4w0ePBB6Jnm4h/lnpfVzRJB2eF2HUo3G tY9QKgkZPRSogClE8X8GfB43KzfDHOGq5QTmHDEI= Date: Tue, 21 Sep 2021 17:37:09 +0200 From: Greg KH To: Eddie James Cc: linux-fsi@lists.ozlabs.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, joel@jms.id.au, linux@roeck-us.net, jdelvare@suse.com, alistair@popple.id.au, jk@ozlabs.org Subject: Re: [PATCH 3/3] hwmon: (occ) Provide the SBEFIFO FFDC in binary sysfs Message-ID: References: <20210914213543.73351-1-eajames@linux.ibm.com> <20210914213543.73351-4-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914213543.73351-4-eajames@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Tue, Sep 14, 2021 at 04:35:43PM -0500, Eddie James wrote: > Save any FFDC provided by the OCC driver, and provide it to userspace > through a binary sysfs entry. Do some basic state management to > ensure that userspace can always collect the data if there was an > error. Notify polling userspace when there is an error too. > > Signed-off-by: Eddie James > --- > drivers/hwmon/occ/p9_sbe.c | 98 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 97 insertions(+), 1 deletion(-) You forgot a Documentation/ABI/ entry :( Binary sysfs files are for "pass through to the hardware" only, you should not be dumping kernel data to userspace through them. I can't really determine if this is the case here or not, as there's no documentation saying what you are trying to represent here... thanks, greg k-h