From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3478DC2BA15 for ; Sun, 5 Apr 2020 15:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E51AE206B8 for ; Sun, 5 Apr 2020 15:48:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tP29YWUW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgDEPsH (ORCPT ); Sun, 5 Apr 2020 11:48:07 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:54378 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726717AbgDEPsH (ORCPT ); Sun, 5 Apr 2020 11:48:07 -0400 Received: by mail-pj1-f66.google.com with SMTP id np9so5389362pjb.4; Sun, 05 Apr 2020 08:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ro6+KbefkXz+hPhP0Iqcl220cLZghODcgKlebnYOeYc=; b=tP29YWUW3x9WmSD+ejFt0USy7DlViex3SScBAv1194VeWEW5P9g9VXP7BMtEHS8w4o QPEfWb32O9gGWb9l5p2m/MwBZGd01bhZtG6jspoK0xjJae9sqlBh+KZssRbed9Z+QCdE ibfhMZoW/BZzu86FQTx0vrjbRyyFeZSgrMea26rN5lDE2YICdsFuLjEOYYkWvZDu52eL NVcqOdFEhwCMikqBIMdHZw9a0M+RpCj5nxjy8jBiVYgDTitDq+16+nYYhd+Dbzt0UuJI zqaRYmvalcX94TgFGbrUvfw4CiST8M5n78E5hYYPFyRNP5bQxMkuBpFlKh+IDCQch0mz BZgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ro6+KbefkXz+hPhP0Iqcl220cLZghODcgKlebnYOeYc=; b=f6UneDuM21y62oIK9aKMZiYJCx8A3fOR9cUFhtoCAWxqpNqd53KMcTm8KUbyU1j/M7 MU/uy+sp0DTkKNBxQVckCP2E2TnegR3lAXQWettNMYgFASQvl1zTXdsWKfNrmp9m5tqA wdsntUFln0mUe560Gp57dI5ycSsjDQgj8F+NDRc+embJaPiXZE0RpvhorzWy7xP1YqII U580iUc8A1oLH+wU4v1ETT5Zd5NsFW+VuIppCGOMBM9XkX/N1dpEY4eqAI6UMpESgGD1 v+Fby5WFNWwkgQL7d/nDHy5lQoshC7NR5qdOOw8V17rnHyjnf1g+VkPT8H0NG+S6xskZ FyQg== X-Gm-Message-State: AGi0PuYAWxkxj8WGJ0pVezkouVbHDYAEEmZhVM/o1uJAWIAcoxoysIkl vCplI/cHJsEueJeTYt1NQ8CwO6e9 X-Google-Smtp-Source: APiQypKcN3uszX8BCrmxru7kRRaolnm7NM90uaXqMOzHJXXYiCi0JzXO4o7Hw2tblXgAA60VR1Qp7A== X-Received: by 2002:a17:90b:292:: with SMTP id az18mr21079654pjb.126.1586101684836; Sun, 05 Apr 2020 08:48:04 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l18sm9009275pgc.26.2020.04.05.08.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Apr 2020 08:48:04 -0700 (PDT) Subject: Re: [PATCH linux hwmon-next v3 3/3] dt-bindings: (hwmon/sbtsi_tmep) Add SB-TSI hwmon driver bindings To: Kun Yi , jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: openbmc@lists.ozlabs.org, joel@jms.id.au, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200405030118.191950-1-kunyi@google.com> <20200405030118.191950-4-kunyi@google.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Sun, 5 Apr 2020 08:48:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200405030118.191950-4-kunyi@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 4/4/20 8:01 PM, Kun Yi wrote: > Document device tree bindings for AMD SB-TSI emulated temperature > sensor. > > Signed-off-by: Kun Yi > --- > .../devicetree/bindings/hwmon/amd,sbtsi.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt > new file mode 100644 > index 000000000000..be7293c43c0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt > @@ -0,0 +1,26 @@ > +* Sideband interface Temperature Sensor Interface (SB-TSI) compliant > +AMD SoC temperature device. > + > +SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > +interface that reports AMD SoC's Ttcl (normalized temperature), > +and resembles a typical 8-pin remote temperature sensor's I2C interface > +to BMC. The emulated thermal sensor can report temperatures in increments of > +0.125 degrees, ranging from 0 to 255.875. > + > +Required properties: > +- compatible: manufacturer and chip name, should be > + "amd,sbtsi", > + > +- reg: I2C bus address of the device as specified in Section 6.3.1 of the > +SoC register reference: The SB-TSI address is normally 98h for socket 0 and > +90h for socket 1, but it could vary based on hardware address select pins. > + > +[open source SoC register reference]: > + https://www.amd.com/system/files/TechDocs/56255_OSRR.pdf > + > +Example: > + > +sbtsi@4c { > + compatible = "amd,sbtsi"; > + reg = <0x4c>; > +}; > Rob is going to ask you to provide this information in DT schema format (Documentation/devicetree/writing-schema.rst). checkpatch tells you the same nowadays. Guenter