From: Guenter Roeck <linux@roeck-us.net>
To: Neha Malcom Francis <n-francis@ti.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jdelvare@suse.com,
linux-hwmon@vger.kernel.org
Cc: nm@ti.com, vigneshr@ti.com, u-kumar1@ti.com, kristo@kernel.org
Subject: Re: [PATCH RESEND v3 0/3] Add support for ESM
Date: Mon, 24 Apr 2023 07:57:00 -0700 [thread overview]
Message-ID: <aabe7488-29b8-895b-38b8-67e5a7d1dd35@roeck-us.net> (raw)
In-Reply-To: <20230424105011.70674-1-n-francis@ti.com>
On 4/24/23 03:50, Neha Malcom Francis wrote:
> Resending as no major changes, commit subject change only.
>
Maybe you consider changing the subject of the bindings from "misc"
to "hwmon" as not being a major change, but it made me aware that you
are trying to sneak bindings which in my opinion don't belong there
into the hwmon bindings directory. This is not a hardware monitoring
device, it doesn't have anything to do with hardware monitoring, and the
bindings do not belong into bindings/hwmon/.
Maybe you can convince the devicetree maintainers to accept the bindings
into the suggested location, but that will be over my objection.
Guenter
> ESM (Error Signaling Module) is a fundamental IP responsible for
> handling safety events. The driver currently present in U-Boot is
> responsible for configuring ESM. This patch series adds dt-binding and
> nodes for J721E and J7200. This goes towards end goal of having DTB sync
> with that of U-Boot as well as ensuring completeness of hardware
> description in devicetree.
>
> Neha Malcom Francis (3):
> dt-bindings: hwmon: esm: Add ESM support for TI K3 devices
> arm64: dts: ti: k3-j721e: Add ESM support
> arm64: dts: ti: k3-j7200: Add ESM support
>
> .../bindings/hwmon/ti,j721e-esm.yaml | 53 +++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 6 +++
> arch/arm64/boot/dts/ti/k3-j7200.dtsi | 1 +
> arch/arm64/boot/dts/ti/k3-j721e.dtsi | 1 +
> 4 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ti,j721e-esm.yaml
>
next prev parent reply other threads:[~2023-04-24 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 10:50 [PATCH RESEND v3 0/3] Add support for ESM Neha Malcom Francis
2023-04-24 10:50 ` [PATCH RESEND v3 1/3] dt-bindings: hwmon: esm: Add ESM support for TI K3 devices Neha Malcom Francis
2023-04-24 14:38 ` Krzysztof Kozlowski
2023-04-24 14:44 ` Guenter Roeck
2023-04-25 9:07 ` Krzysztof Kozlowski
2023-04-24 10:50 ` [PATCH RESEND v3 2/3] arm64: dts: ti: k3-j721e: Add ESM support Neha Malcom Francis
2023-04-24 10:50 ` [PATCH RESEND v3 3/3] arm64: dts: ti: k3-j7200: " Neha Malcom Francis
2023-04-24 14:37 ` [PATCH RESEND v3 0/3] Add support for ESM Krzysztof Kozlowski
2023-04-24 14:57 ` Guenter Roeck [this message]
2023-04-25 8:49 ` Neha Malcom Francis
2023-04-25 14:34 ` Guenter Roeck
2023-05-01 10:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aabe7488-29b8-895b-38b8-67e5a7d1dd35@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-francis@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).