linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Jean Delvare" <jdelvare@suse.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Alexandru Tachici" <alexandru.tachici@analog.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ltc2992) Set `can_sleep` flag for GPIO chip
Date: Wed, 15 Mar 2023 19:15:15 -0700	[thread overview]
Message-ID: <ad54092b-3e91-4058-a7fa-94d19732e113@roeck-us.net> (raw)
In-Reply-To: <20230314093146.2443845-2-lars@metafoo.de>

On Tue, Mar 14, 2023 at 02:31:46AM -0700, Lars-Peter Clausen wrote:
> The ltc2992 drivers uses a mutex and I2C bus access in its GPIO chip `set`
> and `get` implementation. This means these functions can sleep and the GPIO
> chip should set the `can_sleep` property to true.
> 
> This will ensure that a warning is printed when trying to set or get the
> GPIO value from a context that potentially can't sleep.
> 
> Fixes: 9ca26df1ba25 ("hwmon: (ltc2992) Add support for GPIOs.")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc2992.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 88514152d930..69341de397cb 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -323,6 +323,7 @@ static int ltc2992_config_gpio(struct ltc2992_state *st)
>  	st->gc.label = name;
>  	st->gc.parent = &st->client->dev;
>  	st->gc.owner = THIS_MODULE;
> +	st->gc.can_sleep = true;
>  	st->gc.base = -1;
>  	st->gc.names = st->gpio_names;
>  	st->gc.ngpio = ARRAY_SIZE(st->gpio_names);

  reply	other threads:[~2023-03-16  2:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  9:31 [PATCH 1/2] hwmon: (adm1266) Set `can_sleep` flag for GPIO chip Lars-Peter Clausen
2023-03-14  9:31 ` [PATCH 2/2] hwmon: (ltc2992) " Lars-Peter Clausen
2023-03-16  2:15   ` Guenter Roeck [this message]
2023-03-16  2:14 ` [PATCH 1/2] hwmon: (adm1266) " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad54092b-3e91-4058-a7fa-94d19732e113@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexandru.tachici@analog.com \
    --cc=jdelvare@suse.com \
    --cc=lars@metafoo.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).