* [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings
@ 2019-09-03 4:47 Julia Lawall
2019-09-03 5:32 ` Jisheng Zhang
2019-09-03 14:05 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2019-09-03 4:47 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Guenter Roeck, Jean Delvare, linux-hwmon, linux-kernel,
linux-hwmon, kbuild-all
From: kbuild test robot <lkp@intel.com>
Use devm_platform_ioremap_resource helper which wraps
platform_get_resource() and devm_ioremap_resource() together.
Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
Fixes: 658e687b4218 ("hwmon: Add Synaptics AS370 PVT sensor driver")
CC: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head: 9c551fac9ea9629cdc6deb205292c2bbe7b38917
commit: 658e687b4218b42d03a5b0b79a292c9c48f1ddaf [32/34] hwmon: Add Synaptics AS370 PVT sensor driver
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
Please take the patch only if it's a positive warning. Thanks!
as370-hwmon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/hwmon/as370-hwmon.c
+++ b/drivers/hwmon/as370-hwmon.c
@@ -103,7 +103,6 @@ static const struct hwmon_chip_info as37
static int as370_hwmon_probe(struct platform_device *pdev)
{
- struct resource *res;
struct device *hwmon_dev;
struct as370_hwmon *hwmon;
struct device *dev = &pdev->dev;
@@ -112,8 +111,7 @@ static int as370_hwmon_probe(struct plat
if (!hwmon)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- hwmon->base = devm_ioremap_resource(&pdev->dev, res);
+ hwmon->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(hwmon->base))
return PTR_ERR(hwmon->base);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings
2019-09-03 4:47 [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings Julia Lawall
@ 2019-09-03 5:32 ` Jisheng Zhang
2019-09-03 14:05 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2019-09-03 5:32 UTC (permalink / raw)
To: Julia Lawall
Cc: Guenter Roeck, Jean Delvare, linux-hwmon, linux-kernel, kbuild-all
On Tue, 3 Sep 2019 06:47:52 +0200 (CEST) Julia Lawall wrote:
>
>
> From: kbuild test robot <lkp@intel.com>
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
>
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
>
> Fixes: 658e687b4218 ("hwmon: Add Synaptics AS370 PVT sensor driver")
> CC: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings
2019-09-03 4:47 [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings Julia Lawall
2019-09-03 5:32 ` Jisheng Zhang
@ 2019-09-03 14:05 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-09-03 14:05 UTC (permalink / raw)
To: Julia Lawall
Cc: Jisheng Zhang, Jean Delvare, linux-hwmon, linux-kernel, kbuild-all
On Tue, Sep 03, 2019 at 06:47:52AM +0200, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
>
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
>
> Fixes: 658e687b4218 ("hwmon: Add Synaptics AS370 PVT sensor driver")
> CC: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
>
> tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> head: 9c551fac9ea9629cdc6deb205292c2bbe7b38917
> commit: 658e687b4218b42d03a5b0b79a292c9c48f1ddaf [32/34] hwmon: Add Synaptics AS370 PVT sensor driver
> :::::: branch date: 7 hours ago
> :::::: commit date: 7 hours ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> as370-hwmon.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/hwmon/as370-hwmon.c
> +++ b/drivers/hwmon/as370-hwmon.c
> @@ -103,7 +103,6 @@ static const struct hwmon_chip_info as37
>
> static int as370_hwmon_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct device *hwmon_dev;
> struct as370_hwmon *hwmon;
> struct device *dev = &pdev->dev;
> @@ -112,8 +111,7 @@ static int as370_hwmon_probe(struct plat
> if (!hwmon)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - hwmon->base = devm_ioremap_resource(&pdev->dev, res);
> + hwmon->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(hwmon->base))
> return PTR_ERR(hwmon->base);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-03 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 4:47 [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings Julia Lawall
2019-09-03 5:32 ` Jisheng Zhang
2019-09-03 14:05 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).