linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Cc: robh+dt@kernel.org, jdelvare@suse.com,
	krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
	andrew@aj.id.au, eajames@linux.ibm.com,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6 0/5] hwmon: (pmbus/acbel-fsg032) Add Acbel power supply
Date: Wed, 12 Apr 2023 08:27:14 -0700	[thread overview]
Message-ID: <b32aacbb-9f5c-4db9-bd93-d3f96aa1e6a9@roeck-us.net> (raw)
In-Reply-To: <20230412052305.1369521-1-lakshmiy@us.ibm.com>

On Wed, Apr 12, 2023 at 12:23:00AM -0500, Lakshmi Yadlapati wrote:
> Adding new acbel,fsg032 driver and documentation updates.
> 
> Changes since V5:
> Add symlink from manufacturer serial number to ccin since ccin is not
> available in acbel-fsg032 power supply driver.

Sorry, I fail to understand this change, and I am not inclined
to accept it. There is no "as required by hwmon".

Guenter

> 
> Lakshmi Yadlapati (5):
>   dt-bindings: vendor-prefixes: Add prefix for acbel
>   dt-bindings: trivial-devices: Add acbel,fsg032
>   hwmon: (pmbus/acbel-fsg032) Add Acbel power supply
>   docs: hwmon: Add documentaion for acbel-fsg032 PSU
>   ARM: dts: aspeed: p10bmc: Change power supply info
> 
>  .../devicetree/bindings/trivial-devices.yaml  |  2 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  Documentation/hwmon/acbel-fsg032.rst          | 80 ++++++++++++++++
>  Documentation/hwmon/index.rst                 |  1 +
>  arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts  | 12 +--
>  drivers/hwmon/pmbus/Kconfig                   |  9 ++
>  drivers/hwmon/pmbus/Makefile                  |  1 +
>  drivers/hwmon/pmbus/acbel-fsg032.c            | 95 +++++++++++++++++++
>  8 files changed, 196 insertions(+), 6 deletions(-)
>  create mode 100644 Documentation/hwmon/acbel-fsg032.rst
>  create mode 100644 drivers/hwmon/pmbus/acbel-fsg032.c
> 
> -- 
> 2.37.2
> 

      parent reply	other threads:[~2023-04-12 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  5:23 [PATCH v6 0/5] hwmon: (pmbus/acbel-fsg032) Add Acbel power supply Lakshmi Yadlapati
2023-04-12  5:23 ` [PATCH v6 1/5] dt-bindings: vendor-prefixes: Add prefix for acbel Lakshmi Yadlapati
2023-04-12  5:23 ` [PATCH v6 2/5] dt-bindings: trivial-devices: Add acbel,fsg032 Lakshmi Yadlapati
2023-04-12  5:23 ` [PATCH v6 3/5] hwmon: (pmbus/acbel-fsg032) Add Acbel power supply Lakshmi Yadlapati
2023-04-12 15:33   ` Guenter Roeck
2023-04-12  5:23 ` [PATCH v6 4/5] docs: hwmon: Add documentaion for acbel-fsg032 PSU Lakshmi Yadlapati
2023-04-12  5:23 ` [PATCH v6 5/5] ARM: dts: aspeed: p10bmc: Change power supply info Lakshmi Yadlapati
2023-04-12 15:27 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32aacbb-9f5c-4db9-bd93-d3f96aa1e6a9@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.ibm.com \
    --cc=jdelvare@suse.com \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lakshmiy@us.ibm.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).