From: Logan Shaw <Logan.Shaw@alliedtelesis.co.nz>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joshua Scott <Joshua.Scott@alliedtelesis.co.nz>,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] dt-bindings: hwmon: (adt7475) Added missing adt7475 documentation
Date: Wed, 29 Jan 2020 23:52:49 +0000 [thread overview]
Message-ID: <b6829b7582fd777babcad066f7b4c5c3684e4919.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <CAL_Jsq+UZvX-Avz7mA=RmhNU3hjKd2se1KODfGt9dfdbn_ACKQ@mail.gmail.com>
On Wed, 2020-01-29 at 11:27 -0600, Rob Herring wrote:
> On Tue, Jan 28, 2020 at 10:30 PM Logan Shaw
> <Logan.Shaw@alliedtelesis.co.nz> wrote:
> >
> > On Mon, 2020-01-27 at 09:48 -0600, Rob Herring wrote:
> > > On Mon, Jan 27, 2020 at 11:10:14AM +1300, Logan Shaw wrote:
> > > > Added a new file documenting the adt7475 devicetree and added
> > > > the
> > > > four
> > > > new properties to it.
> > > >
> > > > Signed-off-by: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
> > > > ---
> > > > + bypass-attenuator-in0:
> > >
> > > Needs a vendor prefix and a type ref.
> >
> > Adi (Analog Devices) sold the ADT product line (amongst other
> > things)
> > to On Semiconductor. As changing the vendor of these chips (in
> > code)
> > would break backwards compatibility should we keep the vendor as
> > adi?
>
> Yes. It should match what's used in the compatible string(s).
>
> > To confirm, would this make the property "adi,adt7476,bypass-
> > attenuator-in0"?
> >
> > So used in conjunction with patternProperties you would end up with
> > something like:
> >
> > "adi,(adt7473|adt7475|adt7476|adt7490),bypass-attenuator-in[0134]"
>
> No for the part #'s. Just add 'adi,'. Maybe you thought for type ref
> that's what I meant? A type ref is:
>
> $ref: /schemas/types.yaml#/definitions/uint32
Yes, I was a little confused but now I am on the right track.
next prev parent reply other threads:[~2020-01-29 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:10 [PATCH v6 0/2] hwmon: (adt7475) Added attenuator bypass support Logan Shaw
2020-01-26 22:10 ` [PATCH v6 1/2] " Logan Shaw
2020-01-26 22:10 ` [PATCH v6 2/2] dt-bindings: hwmon: (adt7475) Added missing adt7475 documentation Logan Shaw
2020-01-27 15:48 ` Rob Herring
2020-01-29 4:30 ` Logan Shaw
2020-01-29 9:51 ` Guenter Roeck
2020-01-29 17:27 ` Rob Herring
2020-01-29 23:52 ` Logan Shaw [this message]
2020-01-30 3:07 ` Logan Shaw
2020-02-05 0:48 ` Logan Shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6829b7582fd777babcad066f7b4c5c3684e4919.camel@alliedtelesis.co.nz \
--to=logan.shaw@alliedtelesis.co.nz \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Joshua.Scott@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).