From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:39547 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbeLHQxA (ORCPT ); Sat, 8 Dec 2018 11:53:00 -0500 Received: by mail-pl1-f194.google.com with SMTP id 101so3243917pld.6 for ; Sat, 08 Dec 2018 08:53:00 -0800 (PST) Subject: Re: [PATCH] dell-smm-hwmon.c: Additional temperature sensors To: Michele Sorcinelli , =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Jean Delvare , linux-hwmon@vger.kernel.org References: <20181207202927.14168-1-michelesr@autistici.org> <20181208005603.11721-1-michelesr@autistici.org> <3f1b847e-2b70-70bb-f5e6-5f68ffbc63ed@roeck-us.net> From: Guenter Roeck Message-ID: Date: Sat, 8 Dec 2018 08:52:56 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On 12/8/18 7:34 AM, Michele Sorcinelli wrote: >> Please _always_ version your patches, and add a changelog, at least if you >> would like to see it applied. I have now two patches which look almost the same, >> meaning I would have to pull both versions, compare, and hope to apply the >> correct one. > > The only change is in i8k_is_visible(): Please consider reading Documentation/process/submitting-patches.rst, chapter 2). For simplicity, I am copying the relevant paragraph here. " When you submit or resubmit a patch or patch series, include the complete patch description and justification for it. Don't just say that this is version N of the patch (series). Don't expect the subsystem maintainer to refer back to earlier patch versions or referenced URLs to find the patch description and put that into the patch. I.e., the patch (series) and its description should be self-contained. This benefits both the maintainers and reviewers. Some reviewers probably didn't even receive earlier versions of the patch. " Thanks, Guenter