Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610
       [not found] ` <20190722192451.1947348-2-vijaykhemka@fb.com>
@ 2019-07-22 20:06   ` Guenter Roeck
  2019-07-23  0:12     ` Vijay Khemka
  0 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2019-07-22 20:06 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Jean Delvare, Rob Herring, Mark Rutland, Joel Stanley,
	Andrew Jeffery, linux-hwmon, devicetree, linux-kernel,
	linux-arm-kernel, linux-aspeed, openbmc @ lists . ozlabs . org,
	sdasari

On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
> Added new DT binding document for Infineon PXE1610 devices.
> 
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
>  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> new file mode 100644
> index 000000000000..635daf4955db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> @@ -0,0 +1,15 @@
> +pxe1610 properties
> +
> +Required properties:
> +- compatible: Must be one of the following:
> +	- "infineon,pxe1610" for pxe1610
> +	- "infineon,pxe1110" for pxe1610
> +	- "infineon,pxm1310" for pxm1310
> +- reg: I2C address
> +
> +Example:
> +
> +vr@48 {
> +	compatible = "infineon,pxe1610";
> +	reg = <0x48>;
> +};

Wouldn't it be better to add this to
./Documentation/devicetree/bindings/trivial-devices.txt ?

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices
       [not found] <20190722192451.1947348-1-vijaykhemka@fb.com>
       [not found] ` <20190722192451.1947348-2-vijaykhemka@fb.com>
@ 2019-07-23  0:11 ` Andrew Jeffery
  2019-07-23  0:33   ` Vijay Khemka
       [not found] ` <20190722192451.1947348-3-vijaykhemka@fb.com>
  2 siblings, 1 reply; 8+ messages in thread
From: Andrew Jeffery @ 2019-07-23  0:11 UTC (permalink / raw)
  To: Vijay Khemka, Jean Delvare, Guenter Roeck, Rob Herring,
	Mark Rutland, Joel Stanley, linux-hwmon, devicetree,
	linux-kernel, linux-arm-kernel, linux-aspeed
  Cc: openbmc @ lists . ozlabs . org, Sai Dasari

Hi Vijay,

A few nitpicks.

On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote:
> Addes

Typo: Adds

> Voltage

Unnecessary capitalisation.

> regulators Infineon pxe1610 devices to Facebook
> tiogapass platform.
> 
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
>  .../dts/aspeed-bmc-facebook-tiogapass.dts     | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts 
> b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index c4521eda787c..b7783833a58c 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -144,6 +144,42 @@
>  &i2c5 {
>  	status = "okay";
>  	// CPU Voltage regulators
> +	vr@48 {

The recommended generic name is 'regulator', so e.g. regulator@48

> +		compatible = "infineon,pxe1610";
> +		reg = <0x48>;
> +	};
> +	vr@4a {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x4a>;
> +	};
> +	vr@50 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x50>;
> +	};
> +	vr@52 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x52>;
> +	};
> +	vr@58 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x58>;
> +	};
> +	vr@5a {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x5a>;
> +	};
> +	vr@68 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x68>;
> +	};
> +	vr@70 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x70>;
> +	};
> +	vr@72 {
> +		compatible = "infineon,pxe1610";
> +		reg = <0x72>;
> +	};
>  };
>  
>  &i2c6 {
> -- 
> 2.17.1
> 
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610
  2019-07-22 20:06   ` [PATCH] dt-bindings: hwmon: Add binding for pxe1610 Guenter Roeck
@ 2019-07-23  0:12     ` Vijay Khemka
  2019-07-23  1:56       ` Guenter Roeck
  0 siblings, 1 reply; 8+ messages in thread
From: Vijay Khemka @ 2019-07-23  0:12 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Jean Delvare, Rob Herring, Mark Rutland, Joel Stanley,
	Andrew Jeffery, linux-hwmon, devicetree, linux-kernel,
	linux-arm-kernel, linux-aspeed, openbmc @ lists . ozlabs . org,
	Sai Dasari



On 7/22/19, 1:06 PM, "Guenter Roeck" <groeck7@gmail.com on behalf of linux@roeck-us.net> wrote:

    On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
    > Added new DT binding document for Infineon PXE1610 devices.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    > ---
    >  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
    >  1 file changed, 15 insertions(+)
    >  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > 
    > diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > new file mode 100644
    > index 000000000000..635daf4955db
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > @@ -0,0 +1,15 @@
    > +pxe1610 properties
    > +
    > +Required properties:
    > +- compatible: Must be one of the following:
    > +	- "infineon,pxe1610" for pxe1610
    > +	- "infineon,pxe1110" for pxe1610
    > +	- "infineon,pxm1310" for pxm1310
    > +- reg: I2C address
    > +
    > +Example:
    > +
    > +vr@48 {
    > +	compatible = "infineon,pxe1610";
    > +	reg = <0x48>;
    > +};
    
    Wouldn't it be better to add this to
    ./Documentation/devicetree/bindings/trivial-devices.txt ?
Sure, I didn't know about this file. I will add and send another patch. It is 
Documentation/devicetree/bindings/trivial-devices.yaml. How do I abandon 
this patch or just leave it.
    
    Thanks,
    Guenter
    


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices
  2019-07-23  0:11 ` [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices Andrew Jeffery
@ 2019-07-23  0:33   ` Vijay Khemka
  0 siblings, 0 replies; 8+ messages in thread
From: Vijay Khemka @ 2019-07-23  0:33 UTC (permalink / raw)
  To: Andrew Jeffery, Jean Delvare, Guenter Roeck, Rob Herring,
	Mark Rutland, Joel Stanley, linux-hwmon, devicetree,
	linux-kernel, linux-arm-kernel, linux-aspeed
  Cc: openbmc @ lists . ozlabs . org, Sai Dasari



On 7/22/19, 5:12 PM, "Andrew Jeffery" <andrew@aj.id.au> wrote:

    Hi Vijay,
    
    A few nitpicks.
    
    On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote:
    > Addes
    
    Typo: Adds
Ack
    
    > Voltage
    
    Unnecessary capitalisation.
Ack
    
    > regulators Infineon pxe1610 devices to Facebook
    > tiogapass platform.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    > ---
    >  .../dts/aspeed-bmc-facebook-tiogapass.dts     | 36 +++++++++++++++++++
    >  1 file changed, 36 insertions(+)
    > 
    > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts 
    > b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > index c4521eda787c..b7783833a58c 100644
    > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > @@ -144,6 +144,42 @@
    >  &i2c5 {
    >  	status = "okay";
    >  	// CPU Voltage regulators
    > +	vr@48 {
    
    The recommended generic name is 'regulator', so e.g. regulator@48
Ack: Submitted v2 for this patch.
    
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x48>;
    > +	};
    > +	vr@4a {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x4a>;
    > +	};
    > +	vr@50 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x50>;
    > +	};
    > +	vr@52 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x52>;
    > +	};
    > +	vr@58 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x58>;
    > +	};
    > +	vr@5a {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x5a>;
    > +	};
    > +	vr@68 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x68>;
    > +	};
    > +	vr@70 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x70>;
    > +	};
    > +	vr@72 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x72>;
    > +	};
    >  };
    >  
    >  &i2c6 {
    > -- 
    > 2.17.1
    > 
    >
    


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610
  2019-07-23  0:12     ` Vijay Khemka
@ 2019-07-23  1:56       ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2019-07-23  1:56 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Jean Delvare, Rob Herring, Mark Rutland, Joel Stanley,
	Andrew Jeffery, linux-hwmon, devicetree, linux-kernel,
	linux-arm-kernel, linux-aspeed, openbmc @ lists . ozlabs . org,
	Sai Dasari

On 7/22/19 5:12 PM, Vijay Khemka wrote:
> 
> 
> On 7/22/19, 1:06 PM, "Guenter Roeck" <groeck7@gmail.com on behalf of linux@roeck-us.net> wrote:
> 
>      On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
>      > Added new DT binding document for Infineon PXE1610 devices.
>      >
>      > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
>      > ---
>      >  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
>      >  1 file changed, 15 insertions(+)
>      >  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      >
>      > diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      > new file mode 100644
>      > index 000000000000..635daf4955db
>      > --- /dev/null
>      > +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      > @@ -0,0 +1,15 @@
>      > +pxe1610 properties
>      > +
>      > +Required properties:
>      > +- compatible: Must be one of the following:
>      > +	- "infineon,pxe1610" for pxe1610
>      > +	- "infineon,pxe1110" for pxe1610
>      > +	- "infineon,pxm1310" for pxm1310
>      > +- reg: I2C address
>      > +
>      > +Example:
>      > +
>      > +vr@48 {
>      > +	compatible = "infineon,pxe1610";
>      > +	reg = <0x48>;
>      > +};
>      
>      Wouldn't it be better to add this to
>      ./Documentation/devicetree/bindings/trivial-devices.txt ?
> Sure, I didn't know about this file. I will add and send another patch. It is
> Documentation/devicetree/bindings/trivial-devices.yaml. How do I abandon
> this patch or just leave it.
>      

When you send v2, just add the device to the trivial-devices file instead
and describe the differences to v1 (ie this patch).

Guenter


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card
       [not found] ` <20190722192451.1947348-3-vijaykhemka@fb.com>
@ 2019-07-23 17:22   ` Vijay Khemka
  2019-07-23 22:33     ` Joel Stanley
  0 siblings, 1 reply; 8+ messages in thread
From: Vijay Khemka @ 2019-07-23 17:22 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland,
	Joel Stanley, Andrew Jeffery, linux-hwmon, devicetree,
	linux-kernel, linux-arm-kernel, linux-aspeed
  Cc: openbmc @ lists . ozlabs . org, Sai Dasari

Team,
This patch also needs review. I separated first patch with v2 and that was acked. Please review this as well.

Regards
-Vijay

On 7/22/19, 12:41 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:

    Added i2c mux for riser card and multiple ava card and its sensor
    components for Facebook Tiogapass platform
    
    Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    ---
     .../dts/aspeed-bmc-facebook-tiogapass.dts     | 230 ++++++++++++++++++
     1 file changed, 230 insertions(+)
    
    diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    index b7783833a58c..8d0bcb3cd419 100644
    --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    @@ -12,6 +12,27 @@
     	aliases {
     		serial0 = &uart1;
     		serial4 = &uart5;
    +
    +		/*
    +		 * Hardcode the bus number of i2c switches' channels to
    +		 * avoid breaking the legacy applications.
    +		 */
    +		i2c16 = &imux16;
    +		i2c17 = &imux17;
    +		i2c18 = &imux18;
    +		i2c19 = &imux19;
    +		i2c20 = &imux20;
    +		i2c21 = &imux21;
    +		i2c22 = &imux22;
    +		i2c23 = &imux23;
    +		i2c24 = &imux24;
    +		i2c25 = &imux25;
    +		i2c26 = &imux26;
    +		i2c27 = &imux27;
    +		i2c28 = &imux28;
    +		i2c29 = &imux29;
    +		i2c30 = &imux30;
    +		i2c31 = &imux31;
     	};
     	chosen {
     		stdout-path = &uart5;
    @@ -124,6 +145,215 @@
     &i2c1 {
     	status = "okay";
     	//X24 Riser
    +	i2c-switch@71 {
    +		compatible = "nxp,pca9544";
    +		#address-cells = <1>;
    +		#size-cells = <0>;
    +		reg = <0x71>;
    +
    +		imux16: i2c@0 {
    +			#address-cells = <1>;
    +			#size-cells = <0>;
    +			reg = <0>;
    +
    +			ina219@45 {
    +				compatible = "ti,ina219";
    +				reg = <0x45>;
    +			};
    +
    +			tmp75@48 {
    +				compatible = "ti,tmp75";
    +				reg = <0x48>;
    +			};
    +
    +			tmp421@49 {
    +				compatible = "ti,tmp75";
    +				reg = <0x49>;
    +			};
    +
    +			eeprom@50 {
    +				compatible = "atmel,24c64";
    +				reg = <0x50>;
    +				pagesize = <32>;
    +			};
    +
    +			i2c-switch@73 {
    +				compatible = "nxp,pca9546";
    +				#address-cells = <1>;
    +				#size-cells = <0>;
    +				reg = <0x73>;
    +
    +				imux20: i2c@0 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <0>;
    +				};
    +
    +				imux21: i2c@1 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <1>;
    +				};
    +
    +				imux22: i2c@2 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <2>;
    +				};
    +
    +				imux23: i2c@3 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <3>;
    +				};
    +
    +			};
    +
    +		};
    +
    +		imux17: i2c@1 {
    +			#address-cells = <1>;
    +			#size-cells = <0>;
    +			reg = <1>;
    +
    +			ina219@45 {
    +				compatible = "ti,ina219";
    +				reg = <0x45>;
    +			};
    +
    +			tmp421@48 {
    +				compatible = "ti,tmp75";
    +				reg = <0x48>;
    +			};
    +
    +			tmp421@49 {
    +				compatible = "ti,tmp75";
    +				reg = <0x49>;
    +			};
    +
    +			eeprom@50 {
    +				compatible = "atmel,24c64";
    +				reg = <0x50>;
    +				pagesize = <32>;
    +			};
    +
    +			i2c-switch@73 {
    +				compatible = "nxp,pca9546";
    +				#address-cells = <1>;
    +				#size-cells = <0>;
    +				reg = <0x73>;
    +
    +				imux24: i2c@0 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <0>;
    +				};
    +
    +				imux25: i2c@1 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <1>;
    +				};
    +
    +				imux26: i2c@2 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <2>;
    +				};
    +
    +				imux27: i2c@3 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <3>;
    +				};
    +
    +			};
    +
    +		};
    +
    +		imux18: i2c@2 {
    +			#address-cells = <1>;
    +			#size-cells = <0>;
    +			reg = <2>;
    +
    +			ina219@45 {
    +				compatible = "ti,ina219";
    +				reg = <0x45>;
    +			};
    +
    +			tmp421@48 {
    +				compatible = "ti,tmp75";
    +				reg = <0x48>;
    +			};
    +
    +			tmp421@49 {
    +				compatible = "ti,tmp75";
    +				reg = <0x49>;
    +			};
    +
    +			eeprom@50 {
    +				compatible = "atmel,24c64";
    +				reg = <0x50>;
    +				pagesize = <32>;
    +			};
    +
    +			i2c-switch@73 {
    +				compatible = "nxp,pca9546";
    +				#address-cells = <1>;
    +				#size-cells = <0>;
    +				reg = <0x73>;
    +
    +				imux28: i2c@0 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <0>;
    +				};
    +
    +				imux29: i2c@1 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <1>;
    +				};
    +
    +				imux30: i2c@2 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <2>;
    +				};
    +
    +				imux31: i2c@3 {
    +					#address-cells = <1>;
    +					#size-cells = <0>;
    +					reg = <3>;
    +				};
    +
    +			};
    +
    +		};
    +
    +		imux19: i2c@3 {
    +			#address-cells = <1>;
    +			#size-cells = <0>;
    +			reg = <3>;
    +
    +			i2c-switch@40 {
    +				compatible = "ti,ina219";
    +				reg = <0x40>;
    +			};
    +
    +			i2c-switch@41 {
    +				compatible = "ti,ina219";
    +				reg = <0x41>;
    +			};
    +
    +			i2c-switch@45 {
    +				compatible = "ti,ina219";
    +				reg = <0x45>;
    +			};
    +
    +		};
    +
    +	};
     };
     
     &i2c2 {
    -- 
    2.17.1
    
    


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card
  2019-07-23 17:22   ` [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card Vijay Khemka
@ 2019-07-23 22:33     ` Joel Stanley
  2019-07-24 20:42       ` Vijay Khemka
  0 siblings, 1 reply; 8+ messages in thread
From: Joel Stanley @ 2019-07-23 22:33 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland,
	Andrew Jeffery, linux-hwmon, devicetree, linux-kernel,
	linux-arm-kernel, linux-aspeed, openbmc @ lists . ozlabs . org,
	Sai Dasari

On Tue, 23 Jul 2019 at 17:22, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Team,
> This patch also needs review. I separated first patch with v2 and that was acked. Please review this as well.

Do you have a coworker who has access to the schematics and can review
the device tree? They would make a great reviewer.

If no reviewer steps forward I will merge it next time I'm merging patches.

Cheers,

Joel

>
> Regards
> -Vijay
>
> On 7/22/19, 12:41 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
>
>     Added i2c mux for riser card and multiple ava card and its sensor
>     components for Facebook Tiogapass platform
>
>     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
>     ---
>      .../dts/aspeed-bmc-facebook-tiogapass.dts     | 230 ++++++++++++++++++
>      1 file changed, 230 insertions(+)
>
>     diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     index b7783833a58c..8d0bcb3cd419 100644
>     --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     @@ -12,6 +12,27 @@
>         aliases {
>                 serial0 = &uart1;
>                 serial4 = &uart5;
>     +
>     +           /*
>     +            * Hardcode the bus number of i2c switches' channels to
>     +            * avoid breaking the legacy applications.
>     +            */
>     +           i2c16 = &imux16;
>     +           i2c17 = &imux17;
>     +           i2c18 = &imux18;
>     +           i2c19 = &imux19;
>     +           i2c20 = &imux20;
>     +           i2c21 = &imux21;
>     +           i2c22 = &imux22;
>     +           i2c23 = &imux23;
>     +           i2c24 = &imux24;
>     +           i2c25 = &imux25;
>     +           i2c26 = &imux26;
>     +           i2c27 = &imux27;
>     +           i2c28 = &imux28;
>     +           i2c29 = &imux29;
>     +           i2c30 = &imux30;
>     +           i2c31 = &imux31;
>         };
>         chosen {
>                 stdout-path = &uart5;
>     @@ -124,6 +145,215 @@
>      &i2c1 {
>         status = "okay";
>         //X24 Riser
>     +   i2c-switch@71 {
>     +           compatible = "nxp,pca9544";
>     +           #address-cells = <1>;
>     +           #size-cells = <0>;
>     +           reg = <0x71>;
>     +
>     +           imux16: i2c@0 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <0>;
>     +
>     +                   ina219@45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp75@48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421@49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom@50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch@73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux20: i2c@0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux21: i2c@1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux22: i2c@2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux23: i2c@3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux17: i2c@1 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <1>;
>     +
>     +                   ina219@45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp421@48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421@49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom@50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch@73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux24: i2c@0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux25: i2c@1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux26: i2c@2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux27: i2c@3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux18: i2c@2 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <2>;
>     +
>     +                   ina219@45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp421@48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421@49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom@50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch@73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux28: i2c@0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux29: i2c@1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux30: i2c@2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux31: i2c@3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux19: i2c@3 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <3>;
>     +
>     +                   i2c-switch@40 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x40>;
>     +                   };
>     +
>     +                   i2c-switch@41 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x41>;
>     +                   };
>     +
>     +                   i2c-switch@45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +           };
>     +
>     +   };
>      };
>
>      &i2c2 {
>     --
>     2.17.1
>
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card
  2019-07-23 22:33     ` Joel Stanley
@ 2019-07-24 20:42       ` Vijay Khemka
  0 siblings, 0 replies; 8+ messages in thread
From: Vijay Khemka @ 2019-07-24 20:42 UTC (permalink / raw)
  To: Joel Stanley
  Cc: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland,
	Andrew Jeffery, linux-hwmon, devicetree, linux-kernel,
	linux-arm-kernel, linux-aspeed, openbmc @ lists . ozlabs . org,
	Sai Dasari



On 7/23/19, 3:34 PM, "Joel Stanley" <joel@jms.id.au> wrote:

    On Tue, 23 Jul 2019 at 17:22, Vijay Khemka <vijaykhemka@fb.com> wrote:
    >
    > Team,
    > This patch also needs review. I separated first patch with v2 and that was acked. Please review this as well.
    
    Do you have a coworker who has access to the schematics and can review
    the device tree? They would make a great reviewer.
Thanks Joel, Please see there is v2 for this and I will ask coworker to review.
    
    If no reviewer steps forward I will merge it next time I'm merging patches.
    
    Cheers,
    
    Joel
    
    >
    > Regards
    > -Vijay
    >
    > On 7/22/19, 12:41 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
    >
    >     Added i2c mux for riser card and multiple ava card and its sensor
    >     components for Facebook Tiogapass platform
    >
    >     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    >     ---
    >      .../dts/aspeed-bmc-facebook-tiogapass.dts     | 230 ++++++++++++++++++
    >      1 file changed, 230 insertions(+)
    >
    >     diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    >     index b7783833a58c..8d0bcb3cd419 100644
    >     --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    >     +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    >     @@ -12,6 +12,27 @@
    >         aliases {
    >                 serial0 = &uart1;
    >                 serial4 = &uart5;
    >     +
    >     +           /*
    >     +            * Hardcode the bus number of i2c switches' channels to
    >     +            * avoid breaking the legacy applications.
    >     +            */
    >     +           i2c16 = &imux16;
    >     +           i2c17 = &imux17;
    >     +           i2c18 = &imux18;
    >     +           i2c19 = &imux19;
    >     +           i2c20 = &imux20;
    >     +           i2c21 = &imux21;
    >     +           i2c22 = &imux22;
    >     +           i2c23 = &imux23;
    >     +           i2c24 = &imux24;
    >     +           i2c25 = &imux25;
    >     +           i2c26 = &imux26;
    >     +           i2c27 = &imux27;
    >     +           i2c28 = &imux28;
    >     +           i2c29 = &imux29;
    >     +           i2c30 = &imux30;
    >     +           i2c31 = &imux31;
    >         };
    >         chosen {
    >                 stdout-path = &uart5;
    >     @@ -124,6 +145,215 @@
    >      &i2c1 {
    >         status = "okay";
    >         //X24 Riser
    >     +   i2c-switch@71 {
    >     +           compatible = "nxp,pca9544";
    >     +           #address-cells = <1>;
    >     +           #size-cells = <0>;
    >     +           reg = <0x71>;
    >     +
    >     +           imux16: i2c@0 {
    >     +                   #address-cells = <1>;
    >     +                   #size-cells = <0>;
    >     +                   reg = <0>;
    >     +
    >     +                   ina219@45 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x45>;
    >     +                   };
    >     +
    >     +                   tmp75@48 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x48>;
    >     +                   };
    >     +
    >     +                   tmp421@49 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x49>;
    >     +                   };
    >     +
    >     +                   eeprom@50 {
    >     +                           compatible = "atmel,24c64";
    >     +                           reg = <0x50>;
    >     +                           pagesize = <32>;
    >     +                   };
    >     +
    >     +                   i2c-switch@73 {
    >     +                           compatible = "nxp,pca9546";
    >     +                           #address-cells = <1>;
    >     +                           #size-cells = <0>;
    >     +                           reg = <0x73>;
    >     +
    >     +                           imux20: i2c@0 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <0>;
    >     +                           };
    >     +
    >     +                           imux21: i2c@1 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <1>;
    >     +                           };
    >     +
    >     +                           imux22: i2c@2 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <2>;
    >     +                           };
    >     +
    >     +                           imux23: i2c@3 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <3>;
    >     +                           };
    >     +
    >     +                   };
    >     +
    >     +           };
    >     +
    >     +           imux17: i2c@1 {
    >     +                   #address-cells = <1>;
    >     +                   #size-cells = <0>;
    >     +                   reg = <1>;
    >     +
    >     +                   ina219@45 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x45>;
    >     +                   };
    >     +
    >     +                   tmp421@48 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x48>;
    >     +                   };
    >     +
    >     +                   tmp421@49 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x49>;
    >     +                   };
    >     +
    >     +                   eeprom@50 {
    >     +                           compatible = "atmel,24c64";
    >     +                           reg = <0x50>;
    >     +                           pagesize = <32>;
    >     +                   };
    >     +
    >     +                   i2c-switch@73 {
    >     +                           compatible = "nxp,pca9546";
    >     +                           #address-cells = <1>;
    >     +                           #size-cells = <0>;
    >     +                           reg = <0x73>;
    >     +
    >     +                           imux24: i2c@0 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <0>;
    >     +                           };
    >     +
    >     +                           imux25: i2c@1 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <1>;
    >     +                           };
    >     +
    >     +                           imux26: i2c@2 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <2>;
    >     +                           };
    >     +
    >     +                           imux27: i2c@3 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <3>;
    >     +                           };
    >     +
    >     +                   };
    >     +
    >     +           };
    >     +
    >     +           imux18: i2c@2 {
    >     +                   #address-cells = <1>;
    >     +                   #size-cells = <0>;
    >     +                   reg = <2>;
    >     +
    >     +                   ina219@45 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x45>;
    >     +                   };
    >     +
    >     +                   tmp421@48 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x48>;
    >     +                   };
    >     +
    >     +                   tmp421@49 {
    >     +                           compatible = "ti,tmp75";
    >     +                           reg = <0x49>;
    >     +                   };
    >     +
    >     +                   eeprom@50 {
    >     +                           compatible = "atmel,24c64";
    >     +                           reg = <0x50>;
    >     +                           pagesize = <32>;
    >     +                   };
    >     +
    >     +                   i2c-switch@73 {
    >     +                           compatible = "nxp,pca9546";
    >     +                           #address-cells = <1>;
    >     +                           #size-cells = <0>;
    >     +                           reg = <0x73>;
    >     +
    >     +                           imux28: i2c@0 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <0>;
    >     +                           };
    >     +
    >     +                           imux29: i2c@1 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <1>;
    >     +                           };
    >     +
    >     +                           imux30: i2c@2 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <2>;
    >     +                           };
    >     +
    >     +                           imux31: i2c@3 {
    >     +                                   #address-cells = <1>;
    >     +                                   #size-cells = <0>;
    >     +                                   reg = <3>;
    >     +                           };
    >     +
    >     +                   };
    >     +
    >     +           };
    >     +
    >     +           imux19: i2c@3 {
    >     +                   #address-cells = <1>;
    >     +                   #size-cells = <0>;
    >     +                   reg = <3>;
    >     +
    >     +                   i2c-switch@40 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x40>;
    >     +                   };
    >     +
    >     +                   i2c-switch@41 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x41>;
    >     +                   };
    >     +
    >     +                   i2c-switch@45 {
    >     +                           compatible = "ti,ina219";
    >     +                           reg = <0x45>;
    >     +                   };
    >     +
    >     +           };
    >     +
    >     +   };
    >      };
    >
    >      &i2c2 {
    >     --
    >     2.17.1
    >
    >
    >
    


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190722192451.1947348-1-vijaykhemka@fb.com>
     [not found] ` <20190722192451.1947348-2-vijaykhemka@fb.com>
2019-07-22 20:06   ` [PATCH] dt-bindings: hwmon: Add binding for pxe1610 Guenter Roeck
2019-07-23  0:12     ` Vijay Khemka
2019-07-23  1:56       ` Guenter Roeck
2019-07-23  0:11 ` [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices Andrew Jeffery
2019-07-23  0:33   ` Vijay Khemka
     [not found] ` <20190722192451.1947348-3-vijaykhemka@fb.com>
2019-07-23 17:22   ` [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card Vijay Khemka
2019-07-23 22:33     ` Joel Stanley
2019-07-24 20:42       ` Vijay Khemka

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox