Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Iker Perez del Palomar <iker.perez@codethink.co.uk>
To: Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 0/5] Help with lm75.c changes
Date: Tue, 9 Jul 2019 16:11:18 +0100
Message-ID: <d786c56d-e518-d310-ea57-60a8fbefc787@codethink.co.uk> (raw)
In-Reply-To: <48ef8bb0-b420-24a4-16a2-c8d6e5d30eee@roeck-us.net>

Hi,


Thank you for offering to coach me!  You are right, I don't have
experience of writing kernel drivers at all.  I would like to be
coached by you.  I have a system with an tmp75b device to test with.

At the moment I haven't been given any project to work in. so I decided
to work in this driver.  We were using this driver and I wanted
to give a boost to it, while I learn more about the kernel drivers.
However I am open to any suggestions you might have, although If I am
given a new project I won't be able to work on this as much as now.

Thanks for your feedback and for offering to coach me,

Iker

On 09/07/2019 14:43, Guenter Roeck wrote:
> Hi,
> 
> On 7/9/19 2:50 AM, Iker Perez wrote:
>> From: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
>> 
>> Hello,
>> 
>> I have been working in the lm75.c driver, trying to add a variable
>>  update_time to the tmp75b device.
>> 
>> I am not very confident about, if what I am doing and how I am 
>> doing it is the best way it could be done. For that reason, I 
>> decided to send my current changes, so maybe I could be helped and 
>> my code revised.
>> 
>> I decided to separate my all my changes in probably more than 
>> needed commits because I thought that it would b easier to 
>> understand at first place. After the feedback and my changes are 
>> ready to submit I will squash the ones that are related between 
>> them and the patch series will be much shorter.
>> 
>> Thanks in advance for your help,
>> 
> 
> Looking through your patch series, I can't help thinking that you 
> don't have much experience writing kernel drivers. I am open to 
> coaching you through this, but I have to ask: Do you have an actual 
> use case ? This is not something we'll want to do as a coding 
> exercise, since it will add a non-trivial amount of code to the 
> kernel.
> 
> Thanks, Guenter
> 
>> Regards,
>> 
>> Iker
>> 
>> Iker Perez del Palomar Sustatxa (5): hwmon: (lm75) Add kind field 
>> to struct lm75_data hwmon: (lm75) Include hwmon_chip in the 
>> permitted types to be writen hwmon: (lm75) Give write permission
>> to hwmon_chip_update_interval hwmon: (lm75) Create function from
>> code to write into registers First approach to sample time writing
>>  method
>> 
>> drivers/hwmon/lm75.c | 166 
>> +++++++++++++++++++++++++++++++++------------------ 1 file
>> changed, 108 insertions(+), 58 deletions(-)
>> 
> 
> 

-- 
Iker Perez del Palomar, Software Engineer
Codethink Ltd                             35 Dale St, Manchester M1 2HF
http://www.codethink.co.uk/          Manchester, M1 2JW, United Kingdom
We respect your privacy.   See https://www.codethink.co.uk/privacy.html

      reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  9:50 Iker Perez
2019-07-09  9:50 ` [PATCH v1 1/5] hwmon: (lm75) Add kind field to struct lm75_data Iker Perez
2019-07-09 13:20   ` Guenter Roeck
2019-07-09  9:50 ` [PATCH v1 2/5] hwmon: (lm75) Include hwmon_chip in the permitted types to be writen Iker Perez
2019-07-09 13:26   ` Guenter Roeck
2019-07-09  9:50 ` [PATCH v1 3/5] hwmon: (lm75) Give write permission to hwmon_chip_update_interval Iker Perez
2019-07-09  9:50 ` [PATCH v1 4/5] hwmon: (lm75) Create function from code to write into registers Iker Perez
2019-07-09 13:39   ` Guenter Roeck
2019-07-09  9:50 ` [PATCH v1 5/5] First approach to sample time writing method Iker Perez
2019-07-09 13:33   ` Guenter Roeck
2019-07-09 13:43 ` [PATCH v1 0/5] Help with lm75.c changes Guenter Roeck
2019-07-09 15:11   ` Iker Perez del Palomar [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d786c56d-e518-d310-ea57-60a8fbefc787@codethink.co.uk \
    --to=iker.perez@codethink.co.uk \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox