From: Armin Wolf <W_Armin@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>, pali@kernel.org
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v6 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api
Date: Wed, 28 Jul 2021 23:40:21 +0200 [thread overview]
Message-ID: <db21294b-48cf-65ad-77dd-494a779650dc@gmx.de> (raw)
In-Reply-To: <938db8a5-3199-d468-5979-9978171bb138@roeck-us.net>
Am 28.07.21 um 23:37 schrieb Guenter Roeck:
> On 7/28/21 2:34 PM, Armin Wolf wrote:
>> Am 28.07.21 um 23:28 schrieb Guenter Roeck:
>>> On 7/28/21 2:19 PM, Armin Wolf wrote:
>>>> On 28.07.21 23:07 Guenter Roeck wrote:
>>>>> On 7/28/21 1:51 PM, W_Armin@gmx.de wrote:
>>>>>> From: Armin Wolf <W_Armin@gmx.de>
>>>>>>
>>>>>> This patch series is converting the dell-smm-hwmon driver
>>>>>> to the new hwmon registration API. In order to do so,
>>>>>> it introduces a platform device in the first patch, and
>>>>>> applies some optimisations in the next three patches.
>>>>>> The switch to the new hwmon registration API is done in
>>>>>> the next patch. The last patch is fixing a small bug.
>>>>>>
>>>>>> The caching of the fan/temp values was modified to better fit
>>>>>> the new hwmon API.
>>>>>>
>>>>>> The patches work fine for my Dell Latitude C600, but i whould
>>>>>> appreciate someone testing the code on another model too.
>>>>>>
>>>>>> Changes in v6:
>>>>>> - Make pwm1_enable permissions write-only
>>>>>
>>>>> Sorry, guess I am missing something. Why ?
>>>>>
>>>>> Guenter
>>>>>
>>>> pwm1_enable used SENSOR_DEVICE_ATTR_WO before the patch, so the file
>>>> permissions where 0200.
>>>> In the v5 patch series however, the file permission where not 0200,
>>>> so i
>>>> changed that.
>>>>
>>>
>>> Is there a _reason_ for declaring this attribute write only, other than
>>> "it used to be that way" ?
>>>
>>> Guenter
>>
>> I dont think so, dell_smm_read will just return -EOPNOTSUPP if
>> someone tries to read pwm1_enable.
>>
>> Armin
>>
> That is not what I meant. Is there a reason to not report
> the current status of pwm1_enable to the user ? In other
> words, does the firmware not report its current status ?
>
> Guenter
Pali said the driver cannot query the state of pwm1_enable from the BIOS, and with userspace tools being able to change
the state of BIOS fan control behind our back, we cannot simply return the last set value.
next prev parent reply other threads:[~2021-07-28 21:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 20:51 [PATCH v6 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api W_Armin
2021-07-28 20:51 ` [PATCH v6 1/6] hwmon: (dell-smm-hwmon) Use platform device W_Armin
2021-07-28 20:51 ` [PATCH v6 2/6] hwmon: (dell-smm-hwmon) Mark functions as __init W_Armin
2021-07-28 20:51 ` [PATCH v6 3/6] hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset() W_Armin
2021-07-28 20:51 ` [PATCH v6 4/6] hwmon: (dell-smm-hwmon) Move variables into a driver private data structure W_Armin
2021-07-28 20:51 ` [PATCH v6 5/6] hwmon: (dell-smm-hwmon) Convert to devm_hwmon_device_register_with_info() W_Armin
2021-07-28 20:51 ` [PATCH v6 6/6] hwmon: (dell-smm-hwmon) Fix fan mutliplier detection for 3rd fan W_Armin
2021-07-28 21:07 ` [PATCH v6 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api Guenter Roeck
2021-07-28 21:19 ` Armin Wolf
2021-07-28 21:28 ` Guenter Roeck
2021-07-28 21:34 ` Armin Wolf
2021-07-28 21:37 ` Guenter Roeck
2021-07-28 21:40 ` Armin Wolf [this message]
2021-07-28 21:54 ` Pali Rohár
2021-07-28 22:36 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db21294b-48cf-65ad-77dd-494a779650dc@gmx.de \
--to=w_armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).