linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "linux@roeck-us.net" <linux@roeck-us.net>,
	"guillaume.ligneul@gmail.com" <guillaume.ligneul@gmail.com>,
	Henry Shen <Henry.Shen@alliedtelesis.co.nz>,
	"jdelvare@suse.com" <jdelvare@suse.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table
Date: Tue, 11 Feb 2020 02:32:39 +0000	[thread overview]
Message-ID: <dfae85e86f5a75b462f4cc23a158f608ef368685.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <e8c2b347-5af2-e48c-0f9d-2a6860171171@roeck-us.net>

On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote:
> On 2/10/20 6:21 PM, Chris Packham wrote:
> > On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
> > > Add the of_match_table.
> > 
> > Needs your Signed-off-by line.
> > 
> 
> ti,lm73 would also have to be documented as trivial device.
> 

Yes there's another patch for that. I'll work with Henry to send a v2
series instead of individual patches.

> Guenter
> 
> > > ---
> > >   drivers/hwmon/lm73.c | 10 ++++++++++
> > >   1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
> > > index 1eeb9d7de2a0..733c48bf6c98 100644
> > > --- a/drivers/hwmon/lm73.c
> > > +++ b/drivers/hwmon/lm73.c
> > > @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
> > >   	return 0;
> > >   }
> > >   
> > > +static const struct of_device_id lm73_of_match[] = {
> > > +	{
> > > +		.compatible = "ti,lm73",
> > > +	},
> > > +	{ },
> > > +};
> > > +
> > > +MODULE_DEVICE_TABLE(of, lm73_of_match);
> > > +
> > >   static struct i2c_driver lm73_driver = {
> > >   	.class		= I2C_CLASS_HWMON,
> > >   	.driver = {
> > >   		.name	= "lm73",
> > > +		.of_match_table = lm73_of_match,
> > >   	},
> > >   	.probe		= lm73_probe,
> > >   	.id_table	= lm73_ids,
> 
> 

  reply	other threads:[~2020-02-11  2:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200205010657.29483-1-henry.shen@alliedtelesis.co.nz>
     [not found] ` <20200205010657.29483-2-henry.shen@alliedtelesis.co.nz>
2020-02-11  2:21   ` [PATCH] hwmon: (lm73) Add support for of_match_table Chris Packham
2020-02-11  2:30     ` Guenter Roeck
2020-02-11  2:32       ` Chris Packham [this message]
2020-02-11  5:34         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfae85e86f5a75b462f4cc23a158f608ef368685.camel@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=Henry.Shen@alliedtelesis.co.nz \
    --cc=guillaume.ligneul@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).