From: Guenter Roeck <linux@roeck-us.net>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: Naveen Krishna Chatradhi <nchatrad@amd.com>,
linux-hwmon@vger.kernel.org, naveenkrishna.ch@gmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] hwmon: amd_energy: modify the visibility of the counters
Date: Fri, 13 Nov 2020 06:47:18 -0800 [thread overview]
Message-ID: <e15bce7b-2aa7-1bd6-8419-b35233b9cca8@roeck-us.net> (raw)
In-Reply-To: <20201113135834.GA354992@eldamar.lan>
On 11/13/20 5:58 AM, Salvatore Bonaccorso wrote:
> Hi,
>
> On Thu, Nov 12, 2020 at 09:24:22AM -0800, Guenter Roeck wrote:
>> On 11/12/20 9:21 AM, Naveen Krishna Chatradhi wrote:
>>> This patch limits the visibility to owner and groups only for the
>>> energy counters exposed through the hwmon based amd_energy driver.
>>>
>>> Cc: stable@vger.kernel.org
>>> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
>>
>> This is very unusual, and may mess up the "sensors" command.
>> What problem is this trying to solve ?
>
> Is this related to
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1897402
> https://support.lenovo.com/lu/uk/product_security/LEN-50481
> https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12912
>
I guess so. The real fix would presumably be to read the power
in the background. Of course, that won't work because reading
it continuously or frequently causes power fluctuations. I'll
apply the patch, but if there are complaints from users
afterwards that "sensors" is broken I'll simply revert the
entire driver.
Guenter
next prev parent reply other threads:[~2020-11-13 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:21 [PATCH] hwmon: amd_energy: modify the visibility of the counters Naveen Krishna Chatradhi
2020-11-12 17:24 ` Guenter Roeck
2020-11-13 13:58 ` Salvatore Bonaccorso
2020-11-13 14:47 ` Guenter Roeck [this message]
2020-11-22 6:56 ` Chatradhi, Naveen Krishna
2020-11-22 13:30 ` Guenter Roeck
2020-11-22 16:42 ` Chatradhi, Naveen Krishna
2020-11-22 18:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15bce7b-2aa7-1bd6-8419-b35233b9cca8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=carnil@debian.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=nchatrad@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).