* Re: [PATCH] hwmon: (lm73) Add support for of_match_table [not found] ` <20200205010657.29483-2-henry.shen@alliedtelesis.co.nz> @ 2020-02-11 2:21 ` Chris Packham 2020-02-11 2:30 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Chris Packham @ 2020-02-11 2:21 UTC (permalink / raw) To: linux, guillaume.ligneul, Henry Shen, jdelvare; +Cc: linux-kernel, linux-hwmon On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote: > Add the of_match_table. Needs your Signed-off-by line. > --- > drivers/hwmon/lm73.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c > index 1eeb9d7de2a0..733c48bf6c98 100644 > --- a/drivers/hwmon/lm73.c > +++ b/drivers/hwmon/lm73.c > @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client, > return 0; > } > > +static const struct of_device_id lm73_of_match[] = { > + { > + .compatible = "ti,lm73", > + }, > + { }, > +}; > + > +MODULE_DEVICE_TABLE(of, lm73_of_match); > + > static struct i2c_driver lm73_driver = { > .class = I2C_CLASS_HWMON, > .driver = { > .name = "lm73", > + .of_match_table = lm73_of_match, > }, > .probe = lm73_probe, > .id_table = lm73_ids, ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (lm73) Add support for of_match_table 2020-02-11 2:21 ` [PATCH] hwmon: (lm73) Add support for of_match_table Chris Packham @ 2020-02-11 2:30 ` Guenter Roeck 2020-02-11 2:32 ` Chris Packham 0 siblings, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2020-02-11 2:30 UTC (permalink / raw) To: Chris Packham, guillaume.ligneul, Henry Shen, jdelvare Cc: linux-kernel, linux-hwmon On 2/10/20 6:21 PM, Chris Packham wrote: > On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote: >> Add the of_match_table. > > Needs your Signed-off-by line. > ti,lm73 would also have to be documented as trivial device. Guenter >> --- >> drivers/hwmon/lm73.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c >> index 1eeb9d7de2a0..733c48bf6c98 100644 >> --- a/drivers/hwmon/lm73.c >> +++ b/drivers/hwmon/lm73.c >> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client, >> return 0; >> } >> >> +static const struct of_device_id lm73_of_match[] = { >> + { >> + .compatible = "ti,lm73", >> + }, >> + { }, >> +}; >> + >> +MODULE_DEVICE_TABLE(of, lm73_of_match); >> + >> static struct i2c_driver lm73_driver = { >> .class = I2C_CLASS_HWMON, >> .driver = { >> .name = "lm73", >> + .of_match_table = lm73_of_match, >> }, >> .probe = lm73_probe, >> .id_table = lm73_ids, ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (lm73) Add support for of_match_table 2020-02-11 2:30 ` Guenter Roeck @ 2020-02-11 2:32 ` Chris Packham 2020-02-11 5:34 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Chris Packham @ 2020-02-11 2:32 UTC (permalink / raw) To: linux, guillaume.ligneul, Henry Shen, jdelvare; +Cc: linux-kernel, linux-hwmon On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote: > On 2/10/20 6:21 PM, Chris Packham wrote: > > On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote: > > > Add the of_match_table. > > > > Needs your Signed-off-by line. > > > > ti,lm73 would also have to be documented as trivial device. > Yes there's another patch for that. I'll work with Henry to send a v2 series instead of individual patches. > Guenter > > > > --- > > > drivers/hwmon/lm73.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c > > > index 1eeb9d7de2a0..733c48bf6c98 100644 > > > --- a/drivers/hwmon/lm73.c > > > +++ b/drivers/hwmon/lm73.c > > > @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client, > > > return 0; > > > } > > > > > > +static const struct of_device_id lm73_of_match[] = { > > > + { > > > + .compatible = "ti,lm73", > > > + }, > > > + { }, > > > +}; > > > + > > > +MODULE_DEVICE_TABLE(of, lm73_of_match); > > > + > > > static struct i2c_driver lm73_driver = { > > > .class = I2C_CLASS_HWMON, > > > .driver = { > > > .name = "lm73", > > > + .of_match_table = lm73_of_match, > > > }, > > > .probe = lm73_probe, > > > .id_table = lm73_ids, > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (lm73) Add support for of_match_table 2020-02-11 2:32 ` Chris Packham @ 2020-02-11 5:34 ` Guenter Roeck 0 siblings, 0 replies; 4+ messages in thread From: Guenter Roeck @ 2020-02-11 5:34 UTC (permalink / raw) To: Chris Packham, guillaume.ligneul, Henry Shen, jdelvare Cc: linux-kernel, linux-hwmon On 2/10/20 6:32 PM, Chris Packham wrote: > On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote: >> On 2/10/20 6:21 PM, Chris Packham wrote: >>> On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote: >>>> Add the of_match_table. >>> >>> Needs your Signed-off-by line. >>> >> >> ti,lm73 would also have to be documented as trivial device. >> > > Yes there's another patch for that. I'll work with Henry to send a v2 > series instead of individual patches. > DT patches need to be separate patches, or you'll get a complaint from Rob. On a side note, I don't see the actual patch on hwmon's patchwork, and I don't recall being copied on it. Guenter >> Guenter >> >>>> --- >>>> drivers/hwmon/lm73.c | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c >>>> index 1eeb9d7de2a0..733c48bf6c98 100644 >>>> --- a/drivers/hwmon/lm73.c >>>> +++ b/drivers/hwmon/lm73.c >>>> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client, >>>> return 0; >>>> } >>>> >>>> +static const struct of_device_id lm73_of_match[] = { >>>> + { >>>> + .compatible = "ti,lm73", >>>> + }, >>>> + { }, >>>> +}; >>>> + >>>> +MODULE_DEVICE_TABLE(of, lm73_of_match); >>>> + >>>> static struct i2c_driver lm73_driver = { >>>> .class = I2C_CLASS_HWMON, >>>> .driver = { >>>> .name = "lm73", >>>> + .of_match_table = lm73_of_match, >>>> }, >>>> .probe = lm73_probe, >>>> .id_table = lm73_ids, >> >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-11 5:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200205010657.29483-1-henry.shen@alliedtelesis.co.nz>
[not found] ` <20200205010657.29483-2-henry.shen@alliedtelesis.co.nz>
2020-02-11 2:21 ` [PATCH] hwmon: (lm73) Add support for of_match_table Chris Packham
2020-02-11 2:30 ` Guenter Roeck
2020-02-11 2:32 ` Chris Packham
2020-02-11 5:34 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).